From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A29C54E76 for ; Thu, 5 Jan 2023 11:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232148AbjAELfq (ORCPT ); Thu, 5 Jan 2023 06:35:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232667AbjAELfn (ORCPT ); Thu, 5 Jan 2023 06:35:43 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B304C713; Thu, 5 Jan 2023 03:35:40 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id D884FE0002; Thu, 5 Jan 2023 11:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1672918539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3hfoi/7J5CIyjBCsT+TUV6DEwamqcoR9VCTKwBJrmg=; b=hsppRdJjuG5g9j+sYuy6WsOGIwlIs+4HO4DWCdjJXncW83/1btIOw+qUW73uWhLgjAOPGW eb3q/nFosbt3NHTYnkXaup63uNmMPycnb/UaDgkvte60YOgpaYwfp2dARiTniY28MUG5Ba rxAMj8jKtnG4PQz+z5T4bk2myQWwJ4/OJQcK9PW+XLtr25QmYKyQBLhQ2TlbnUCewG1tau 4ADrH4lvlATEjRdPDqRRjN/vamUugdk3UxOzp6wAIMpR/P02DCnUwA8l6rSq4/X3krSCxg xStHQmidHMlF6PyorE+5NziSlASS6eC927LDkSJoUf+cHwZxuKUC6RydjbRoxQ== Date: Thu, 5 Jan 2023 12:35:34 +0100 From: Miquel Raynal To: Alexander Stein Cc: Michael Walle , Srinivas Kandagatla , Jonathan Corbet , Rob Herring , Frank Rowand , Sascha Hauer , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v5 00/21] nvmem: core: introduce NVMEM layouts Message-ID: <20230105123534.38a70640@xps-13> In-Reply-To: <2143916.GUh0CODmnK@steina-w> References: <20221206200740.3567551-1-michael@walle.cc> <20230103163902.218cb5c7@xps-13> <2143916.GUh0CODmnK@steina-w> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hello, alexander.stein@ew.tq-group.com wrote on Thu, 05 Jan 2023 12:04:52 +0100: > Am Dienstag, 3. Januar 2023, 16:51:31 CET schrieb Srinivas Kandagatla: > > Hi Miquel, > >=20 > > On 03/01/2023 15:39, Miquel Raynal wrote: =20 > > > Hi Srinivas, > > >=20 > > > michael@walle.cc wrote on Tue, 6 Dec 2022 21:07:19 +0100: =20 > > >> This is now the third attempt to fetch the MAC addresses from the VPD > > >> for the Kontron sl28 boards. Previous discussions can be found here: > > >> https://lore.kernel.org/lkml/20211228142549.1275412-1-michael@walle.= cc/ > > >>=20 > > >>=20 > > >> NVMEM cells are typically added by board code or by the devicetree. = But > > >> as the cells get more complex, there is (valid) push back from the > > >> devicetree maintainers to not put that handling in the devicetree. > > >>=20 > > >> Therefore, introduce NVMEM layouts. They operate on the NVMEM device= and > > >> can add cells during runtime. That way it is possible to add more co= mplex > > >> cells than it is possible right now with the offset/length/bits > > >> description in the device tree. For example, you can have post proce= ssing > > >> for individual cells (think of endian swapping, or ethernet offset > > >> handling). > > >>=20 > > >> The imx-ocotp driver is the only user of the global post processing = hook, > > >> convert it to nvmem layouts and drop the global post pocessing hook. > > >>=20 > > >> For now, the layouts are selected by the device tree. But the idea is > > >> that also board files or other drivers could set a layout. Although = no > > >> code for that exists yet. > > >>=20 > > >> Thanks to Miquel, the device tree bindings are already approved and > > >> merged. > > >>=20 > > >> NVMEM layouts as modules? > > >> While possible in principle, it doesn't make any sense because the N= VMEM > > >> core can't be compiled as a module. The layouts needs to be availabl= e at > > >> probe time. (That is also the reason why they get registered with > > >> subsys_initcall().) So if the NVMEM core would be a module, the layo= uts > > >> could be modules, too. =20 > > >=20 > > > I believe this series still applies even though -rc1 (and -rc2) are o= ut > > > now, may we know if you consider merging it anytime soon or if there > > > are still discrepancies in the implementation you would like to > > > discuss? Otherwise I would really like to see this laying in -next a > > > few weeks before being sent out to Linus, just in case. =20 > >=20 > > Thanks for the work! > >=20 > > Lets get some testing in -next. =20 >=20 > This causes the following errors on existing boards (imx8mq-tqma8mq- > mba8mx.dtb): > root@tqma8-common:~# uname -r > 6.2.0-rc2-next-20230105 >=20 > > OF: /soc@0: could not get #nvmem-cell-cells for /soc@0/bus@30000000/ =20 > efuse@30350000/soc-uid@4 > > OF: /soc@0/bus@30800000/ethernet@30be0000: could not get #nvmem-cell-ce= lls =20 > for /soc@0/bus@30000000/efuse@30350000/mac-address@90 >=20 > These are caused because '#nvmem-cell-cells =3D <0>;' is not explicitly s= et in=20 > DT. >=20 > > TI DP83867 30be0000.ethernet-1:0e: error -EINVAL: failed to get nvmem c= ell =20 > io_impedance_ctrl > > TI DP83867: probe of 30be0000.ethernet-1:0e failed with error -22 =20 >=20 > These are caused because of_nvmem_cell_get() now returns -EINVAL instead = of - > ENODEV if the requested nvmem cell is not available. Should we just assume #nvmem-cell-cells =3D <0> by default? I guess it's a safe assumption. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75E9AC3DA7A for ; Thu, 5 Jan 2023 20:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RyvYvV9ZAPRi91ILdeT9VGPxQunygDDghGDktdQCBA8=; b=zL4z222IQcMT/p ncZiaAbOjh1ncCNZLq50mfrI2TYnOazz683n8VR3vEC8X/aUNNpTT4D1F0j2Hc9Ri4Y1os9HbvNgq aAPi8xf92o8EMUM7QgqSM4Qa0d46E5x8WrKkF4cREEg8LsqRE7Fy+GJqHYVR0dKyisdOPU7wOcAdb RAKa8tkRijz/bDEa+7XHC+Nc41VKcVeaAuDHL57Z6r7UjXtFoRzH33Evmf06yJAoPAbkvTrx99kFF ozXwKzCYP9yiBIhNGpbBUyEIomfBkX65/Vv7UX7QwLrqwOcQeDmlt8qac1Cf+C92LRpsmZf+gAfHJ 2sKE/xSOhsacqsMDEK2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDWxf-00Ec4Q-1E; Thu, 05 Jan 2023 20:35:39 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDOX8-00Bw3u-Na for linux-arm-kernel@lists.infradead.org; Thu, 05 Jan 2023 11:35:45 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id D884FE0002; Thu, 5 Jan 2023 11:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1672918539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3hfoi/7J5CIyjBCsT+TUV6DEwamqcoR9VCTKwBJrmg=; b=hsppRdJjuG5g9j+sYuy6WsOGIwlIs+4HO4DWCdjJXncW83/1btIOw+qUW73uWhLgjAOPGW eb3q/nFosbt3NHTYnkXaup63uNmMPycnb/UaDgkvte60YOgpaYwfp2dARiTniY28MUG5Ba rxAMj8jKtnG4PQz+z5T4bk2myQWwJ4/OJQcK9PW+XLtr25QmYKyQBLhQ2TlbnUCewG1tau 4ADrH4lvlATEjRdPDqRRjN/vamUugdk3UxOzp6wAIMpR/P02DCnUwA8l6rSq4/X3krSCxg xStHQmidHMlF6PyorE+5NziSlASS6eC927LDkSJoUf+cHwZxuKUC6RydjbRoxQ== Date: Thu, 5 Jan 2023 12:35:34 +0100 From: Miquel Raynal To: Alexander Stein Cc: Michael Walle , Srinivas Kandagatla , Jonathan Corbet , Rob Herring , Frank Rowand , Sascha Hauer , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v5 00/21] nvmem: core: introduce NVMEM layouts Message-ID: <20230105123534.38a70640@xps-13> In-Reply-To: <2143916.GUh0CODmnK@steina-w> References: <20221206200740.3567551-1-michael@walle.cc> <20230103163902.218cb5c7@xps-13> <2143916.GUh0CODmnK@steina-w> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230105_033543_204858_CAE28ECD X-CRM114-Status: GOOD ( 36.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgphbGV4YW5kZXIuc3RlaW5AZXcudHEtZ3JvdXAuY29tIHdyb3RlIG9uIFRodSwgMDUg SmFuIDIwMjMgMTI6MDQ6NTIKKzAxMDA6Cgo+IEFtIERpZW5zdGFnLCAzLiBKYW51YXIgMjAyMywg MTY6NTE6MzEgQ0VUIHNjaHJpZWIgU3Jpbml2YXMgS2FuZGFnYXRsYToKPiA+IEhpIE1pcXVlbCwK PiA+IAo+ID4gT24gMDMvMDEvMjAyMyAxNTozOSwgTWlxdWVsIFJheW5hbCB3cm90ZTogIAo+ID4g PiBIaSBTcmluaXZhcywKPiA+ID4gCj4gPiA+IG1pY2hhZWxAd2FsbGUuY2Mgd3JvdGUgb24gVHVl LCAgNiBEZWMgMjAyMiAyMTowNzoxOSArMDEwMDogIAo+ID4gPj4gVGhpcyBpcyBub3cgdGhlIHRo aXJkIGF0dGVtcHQgdG8gZmV0Y2ggdGhlIE1BQyBhZGRyZXNzZXMgZnJvbSB0aGUgVlBECj4gPiA+ PiBmb3IgdGhlIEtvbnRyb24gc2wyOCBib2FyZHMuIFByZXZpb3VzIGRpc2N1c3Npb25zIGNhbiBi ZSBmb3VuZCBoZXJlOgo+ID4gPj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8yMDIxMTIy ODE0MjU0OS4xMjc1NDEyLTEtbWljaGFlbEB3YWxsZS5jYy8KPiA+ID4+IAo+ID4gPj4gCj4gPiA+ PiBOVk1FTSBjZWxscyBhcmUgdHlwaWNhbGx5IGFkZGVkIGJ5IGJvYXJkIGNvZGUgb3IgYnkgdGhl IGRldmljZXRyZWUuIEJ1dAo+ID4gPj4gYXMgdGhlIGNlbGxzIGdldCBtb3JlIGNvbXBsZXgsIHRo ZXJlIGlzICh2YWxpZCkgcHVzaCBiYWNrIGZyb20gdGhlCj4gPiA+PiBkZXZpY2V0cmVlIG1haW50 YWluZXJzIHRvIG5vdCBwdXQgdGhhdCBoYW5kbGluZyBpbiB0aGUgZGV2aWNldHJlZS4KPiA+ID4+ IAo+ID4gPj4gVGhlcmVmb3JlLCBpbnRyb2R1Y2UgTlZNRU0gbGF5b3V0cy4gVGhleSBvcGVyYXRl IG9uIHRoZSBOVk1FTSBkZXZpY2UgYW5kCj4gPiA+PiBjYW4gYWRkIGNlbGxzIGR1cmluZyBydW50 aW1lLiBUaGF0IHdheSBpdCBpcyBwb3NzaWJsZSB0byBhZGQgbW9yZSBjb21wbGV4Cj4gPiA+PiBj ZWxscyB0aGFuIGl0IGlzIHBvc3NpYmxlIHJpZ2h0IG5vdyB3aXRoIHRoZSBvZmZzZXQvbGVuZ3Ro L2JpdHMKPiA+ID4+IGRlc2NyaXB0aW9uIGluIHRoZSBkZXZpY2UgdHJlZS4gRm9yIGV4YW1wbGUs IHlvdSBjYW4gaGF2ZSBwb3N0IHByb2Nlc3NpbmcKPiA+ID4+IGZvciBpbmRpdmlkdWFsIGNlbGxz ICh0aGluayBvZiBlbmRpYW4gc3dhcHBpbmcsIG9yIGV0aGVybmV0IG9mZnNldAo+ID4gPj4gaGFu ZGxpbmcpLgo+ID4gPj4gCj4gPiA+PiBUaGUgaW14LW9jb3RwIGRyaXZlciBpcyB0aGUgb25seSB1 c2VyIG9mIHRoZSBnbG9iYWwgcG9zdCBwcm9jZXNzaW5nIGhvb2ssCj4gPiA+PiBjb252ZXJ0IGl0 IHRvIG52bWVtIGxheW91dHMgYW5kIGRyb3AgdGhlIGdsb2JhbCBwb3N0IHBvY2Vzc2luZyBob29r Lgo+ID4gPj4gCj4gPiA+PiBGb3Igbm93LCB0aGUgbGF5b3V0cyBhcmUgc2VsZWN0ZWQgYnkgdGhl IGRldmljZSB0cmVlLiBCdXQgdGhlIGlkZWEgaXMKPiA+ID4+IHRoYXQgYWxzbyBib2FyZCBmaWxl cyBvciBvdGhlciBkcml2ZXJzIGNvdWxkIHNldCBhIGxheW91dC4gQWx0aG91Z2ggbm8KPiA+ID4+ IGNvZGUgZm9yIHRoYXQgZXhpc3RzIHlldC4KPiA+ID4+IAo+ID4gPj4gVGhhbmtzIHRvIE1pcXVl bCwgdGhlIGRldmljZSB0cmVlIGJpbmRpbmdzIGFyZSBhbHJlYWR5IGFwcHJvdmVkIGFuZAo+ID4g Pj4gbWVyZ2VkLgo+ID4gPj4gCj4gPiA+PiBOVk1FTSBsYXlvdXRzIGFzIG1vZHVsZXM/Cj4gPiA+ PiBXaGlsZSBwb3NzaWJsZSBpbiBwcmluY2lwbGUsIGl0IGRvZXNuJ3QgbWFrZSBhbnkgc2Vuc2Ug YmVjYXVzZSB0aGUgTlZNRU0KPiA+ID4+IGNvcmUgY2FuJ3QgYmUgY29tcGlsZWQgYXMgYSBtb2R1 bGUuIFRoZSBsYXlvdXRzIG5lZWRzIHRvIGJlIGF2YWlsYWJsZSBhdAo+ID4gPj4gcHJvYmUgdGlt ZS4gKFRoYXQgaXMgYWxzbyB0aGUgcmVhc29uIHdoeSB0aGV5IGdldCByZWdpc3RlcmVkIHdpdGgK PiA+ID4+IHN1YnN5c19pbml0Y2FsbCgpLikgU28gaWYgdGhlIE5WTUVNIGNvcmUgd291bGQgYmUg YSBtb2R1bGUsIHRoZSBsYXlvdXRzCj4gPiA+PiBjb3VsZCBiZSBtb2R1bGVzLCB0b28uICAKPiA+ ID4gCj4gPiA+IEkgYmVsaWV2ZSB0aGlzIHNlcmllcyBzdGlsbCBhcHBsaWVzIGV2ZW4gdGhvdWdo IC1yYzEgKGFuZCAtcmMyKSBhcmUgb3V0Cj4gPiA+IG5vdywgbWF5IHdlIGtub3cgaWYgeW91IGNv bnNpZGVyIG1lcmdpbmcgaXQgYW55dGltZSBzb29uIG9yIGlmIHRoZXJlCj4gPiA+IGFyZSBzdGls bCBkaXNjcmVwYW5jaWVzIGluIHRoZSBpbXBsZW1lbnRhdGlvbiB5b3Ugd291bGQgbGlrZSB0bwo+ ID4gPiBkaXNjdXNzPyBPdGhlcndpc2UgSSB3b3VsZCByZWFsbHkgbGlrZSB0byBzZWUgdGhpcyBs YXlpbmcgaW4gLW5leHQgYQo+ID4gPiBmZXcgd2Vla3MgYmVmb3JlIGJlaW5nIHNlbnQgb3V0IHRv IExpbnVzLCBqdXN0IGluIGNhc2UuICAKPiA+IAo+ID4gVGhhbmtzIGZvciB0aGUgd29yayEKPiA+ IAo+ID4gTGV0cyBnZXQgc29tZSB0ZXN0aW5nIGluIC1uZXh0LiAgCj4gCj4gVGhpcyBjYXVzZXMg dGhlIGZvbGxvd2luZyBlcnJvcnMgb24gZXhpc3RpbmcgYm9hcmRzIChpbXg4bXEtdHFtYThtcS0K PiBtYmE4bXguZHRiKToKPiByb290QHRxbWE4LWNvbW1vbjp+IyB1bmFtZSAtcgo+IDYuMi4wLXJj Mi1uZXh0LTIwMjMwMTA1Cj4gCj4gPiBPRjogL3NvY0AwOiBjb3VsZCBub3QgZ2V0ICNudm1lbS1j ZWxsLWNlbGxzIGZvciAvc29jQDAvYnVzQDMwMDAwMDAwLyAgCj4gZWZ1c2VAMzAzNTAwMDAvc29j LXVpZEA0Cj4gPiBPRjogL3NvY0AwL2J1c0AzMDgwMDAwMC9ldGhlcm5ldEAzMGJlMDAwMDogY291 bGQgbm90IGdldCAjbnZtZW0tY2VsbC1jZWxscyAgIAo+IGZvciAvc29jQDAvYnVzQDMwMDAwMDAw L2VmdXNlQDMwMzUwMDAwL21hYy1hZGRyZXNzQDkwCj4gCj4gVGhlc2UgYXJlIGNhdXNlZCBiZWNh dXNlICcjbnZtZW0tY2VsbC1jZWxscyA9IDwwPjsnIGlzIG5vdCBleHBsaWNpdGx5IHNldCBpbiAK PiBEVC4KPiAKPiA+IFRJIERQODM4NjcgMzBiZTAwMDAuZXRoZXJuZXQtMTowZTogZXJyb3IgLUVJ TlZBTDogZmFpbGVkIHRvIGdldCBudm1lbSBjZWxsICAgCj4gaW9faW1wZWRhbmNlX2N0cmwKPiA+ IFRJIERQODM4Njc6IHByb2JlIG9mIDMwYmUwMDAwLmV0aGVybmV0LTE6MGUgZmFpbGVkIHdpdGgg ZXJyb3IgLTIyICAKPiAKPiBUaGVzZSBhcmUgY2F1c2VkIGJlY2F1c2Ugb2ZfbnZtZW1fY2VsbF9n ZXQoKSBub3cgcmV0dXJucyAtRUlOVkFMIGluc3RlYWQgb2YgLQo+IEVOT0RFViBpZiB0aGUgcmVx dWVzdGVkIG52bWVtIGNlbGwgaXMgbm90IGF2YWlsYWJsZS4KClNob3VsZCB3ZSBqdXN0IGFzc3Vt ZSAjbnZtZW0tY2VsbC1jZWxscyA9IDwwPiBieSBkZWZhdWx0PyBJIGd1ZXNzIGl0J3MKYSBzYWZl IGFzc3VtcHRpb24uCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK