From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21A98494 for ; Thu, 5 Jan 2023 13:07:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58E2EC433D2; Thu, 5 Jan 2023 13:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672924036; bh=M0VL0V9wsFdAk1SYxaJibh+m/E+jAgH7thX8k1zU5Dk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U90h+xbzjaBGCrywDkRk8nlYVPPRJtBGEN0y3K6k7sbub4EmHApmUzH2C5fOFGxdI fGkIrZElGnWDosfUmoafZ//xsUnclExAQqqboZOKeb9czZJpgmLpzTsnnZARggx4RH dAcsc+0IwO0TNuRrTbX5spK9SXTGLY7KDWzsFebo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hans de Goede , Mark Brown , Sasha Levin Subject: [PATCH 4.9 213/251] ASoC: rt5670: Remove unbalanced pm_runtime_put() Date: Thu, 5 Jan 2023 13:55:50 +0100 Message-Id: <20230105125344.617602301@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230105125334.727282894@linuxfoundation.org> References: <20230105125334.727282894@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Hans de Goede [ Upstream commit 6c900dcc3f7331a67ed29739d74524e428d137fb ] For some reason rt5670_i2c_probe() does a pm_runtime_put() at the end of a successful probe. But it has never done a pm_runtime_get() leading to the following error being logged into dmesg: rt5670 i2c-10EC5640:00: Runtime PM usage count underflow! Fix this by removing the unnecessary pm_runtime_put(). Fixes: 64e89e5f5548 ("ASoC: rt5670: Add runtime PM support") Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20221213123319.11285-1-hdegoede@redhat.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/rt5670.c | 2 -- 1 file changed, 2 deletions(-) --- a/sound/soc/codecs/rt5670.c +++ b/sound/soc/codecs/rt5670.c @@ -3028,8 +3028,6 @@ static int rt5670_i2c_probe(struct i2c_c if (ret < 0) goto err; - pm_runtime_put(&i2c->dev); - return 0; err: pm_runtime_disable(&i2c->dev);