From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC3F9C63797 for ; Fri, 6 Jan 2023 22:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbjAFWJg (ORCPT ); Fri, 6 Jan 2023 17:09:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236846AbjAFWJD (ORCPT ); Fri, 6 Jan 2023 17:09:03 -0500 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C19584BEE for ; Fri, 6 Jan 2023 14:08:59 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E92045C00D8; Fri, 6 Jan 2023 17:08:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 06 Jan 2023 17:08:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tyhicks.com; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1673042938; x=1673129338; bh=dozno7prfTcaYWAUVFCcyR2pt pV2cJYPN6XphVvRlWA=; b=oD3Eg4RdvjchAF9BWDjGcrp2jZ9jA75XYssizxBzk lNTed9GHtpXsN2kiah+1htWQJvh45LBkYwt6NTDboCZkpPRw7boyV+TJatSMdBF7 8gauuh9UBMUMJmmT7c7FHAOh5h9YGNY1eaigFgsiXVzw2utsIdcXIb5fZ5460vv5 oL7nkMlAj4yzKNL/32tNZf2aD0+KYojrib/3p0bZc0yCQjDAzMBN4ZMGadfjtYdH cO8b0JJnl9qFMqtXOKjjBhcpmo38ln9QiLBp8edi4EvMumASAkSXLAHk8AHLFOfU 4xSoAB0UQ4eBLLO5Srso6B3y9xWTwHyTEW2ybddUKyPHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1673042938; x=1673129338; bh=dozno7prfTcaYWAUVFCcyR2ptpV2cJYPN6X phVvRlWA=; b=ML0uK/N5ieplGzOsXXd0ay6/uVAu/nEgLxXNgqQVJ1YPuKjuGb/ a5a71A8P+3Ki2hiHpGvESjom1SNIHNHtdoVVqkJeT4/WCK2fVtA5UwgzqIZ+4uCC W0oySbkrV1KrIYNcprcTyic9hy5D6TLXTWTxSQHdyimzDM94XRlsc0Gv0purxi1K WForK7pWJm+4NkTRieu/uqVZG4IadPw2kHM7Cm1byCsWW+P/hyYgsgwhJ9tZPrMo Asn+efPW9lH/fa/30AccAc3HOsBzW/rdREdKaz1n2yfujKnojSsxDGnbhpeuBO93 qMJ8WLdH84DJk18jGPoFahxmEIWi1TJGXKQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkedtgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepvfihlhgvrhcu jfhitghkshcuoegtohguvgesthihhhhitghkshdrtghomheqnecuggftrfgrthhtvghrnh epjeetteejvdefleekuddtgfelgeejudefieegfeekjeehtedvgefgfeffvdegudeknecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghouggvse hthihhihgtkhhsrdgtohhm X-ME-Proxy: Feedback-ID: i78e14604:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Jan 2023 17:08:58 -0500 (EST) From: Tyler Hicks To: stable@vger.kernel.org Cc: Shuah Khan , Muhammad Usama Anjum , "Tyler Hicks" Subject: [PATCH 5.4 0/2] Fix kselftest builds when specifying an output dir Date: Fri, 6 Jan 2023 16:08:42 -0600 Message-Id: <20230106220844.763870-1-code@tyhicks.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: "Tyler Hicks" When attempting to build kselftests with a separate output directory, a number of the tests fail to build. For example, $ rm -rf build && \ make INSTALL_HDR_PATH=build/usr headers_install > /dev/null && \ make O=build FORCE_TARGETS=1 TARGETS=breakpoints -C tools/testing/selftests > /dev/null /usr/bin/ld: cannot open output file build/kselftest/breakpoints/step_after_suspend_test: No such file or directory collect2: error: ld returned 1 exit status make[1]: *** [../lib.mk:146: build/kselftest/breakpoints/step_after_suspend_test] Error 1 make: *** [Makefile:163: all] Error 2 This has already been addressed upstream with v5.18 commit 5ad51ab618de ("selftests: set the BUILD variable to absolute path"). It does not cleanly cherry pick to the linux-5.4.y branch without v5.7 commit 29e911ef7b70 ("selftests: Fix kselftest O=objdir build from cluttering top level objdir"). Commit 5ad51ab618de was written in a way that assumes that the kselftests aren't build in the top level objdir so it makes sense to bring the pre-req commit back but it does represent a slight change in behavior since the kselftests will now be built in a subdir of the specified objdir (O=). Tyler Muhammad Usama Anjum (1): selftests: set the BUILD variable to absolute path Shuah Khan (1): selftests: Fix kselftest O=objdir build from cluttering top level objdir tools/testing/selftests/Makefile | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) -- 2.34.1