[PATCH 0/2] Fix EUD dt-binding doc & sc7280 EUD node syntax

[PATCH 0/2] Fix EUD dt-binding doc & sc7280 EUD node syntax

[Bhupesh Sharma]

This patchset fixes the EUD dt-binding doc & sc7280 EUD node syntax.

Cc: Souradeep Chowdhury <quic_schowdhu@quicinc.com>

Bhupesh Sharma (2):
  arm64: dts: qcom: sc7280: Fix EUD dt node syntax
  dt-bindings: soc: qcom: eud: Fix identation issues in the example

 .../bindings/soc/qcom/qcom,eud.yaml           |  8 +++--
 arch/arm64/boot/dts/qcom/sc7280.dtsi          | 32 ++++++++++++-------
 2 files changed, 25 insertions(+), 15 deletions(-)

-- 
2.38.1

[PATCH 1/2] arm64: dts: qcom: sc7280: Fix EUD dt node syntax

[Bhupesh Sharma]

As noted by Konrad while reviewing [1], fix the EUD and DWC3
node syntax in sc7280 dtsi file.

While at it also fix the errors reported by '$ make dtbs_check'
for the EUD node:

 arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: eud@88e0000: ports:
    'oneOf' conditional failed, one must be fixed:
	'port' is a required property
	'#address-cells' is a required property
	'#size-cells' is a required property
  From schema: Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml

[1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 32 +++++++++++++++++-----------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 0adf13399e649..f4c87059919e4 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -623,6 +623,18 @@ cpu7_opp_3014mhz: opp-3014400000 {
 		};
 	};
 
+	eud_typec: connector {
+		compatible = "usb-c-connector";
+
+		ports {
+			port@0 {
+				con_eud: endpoint {
+					remote-endpoint = <&eud_con>;
+				};
+			};
+		};
+	};
+
 	memory@80000000 {
 		device_type = "memory";
 		/* We expect the bootloader to fill in the size */
@@ -3411,6 +3423,7 @@ usb_2_dwc3: usb@8c00000 {
 				phy-names = "usb2-phy";
 				maximum-speed = "high-speed";
 				usb-role-switch;
+
 				port {
 					usb2_role_switch: endpoint {
 						remote-endpoint = <&eud_ep>;
@@ -3585,17 +3598,23 @@ system-cache-controller@9200000 {
 		};
 
 		eud: eud@88e0000 {
-			compatible = "qcom,sc7280-eud","qcom,eud";
+			compatible = "qcom,sc7280-eud", "qcom,eud";
 			reg = <0 0x88e0000 0 0x2000>,
 			      <0 0x88e2000 0 0x1000>;
 			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
+
 			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
 				port@0 {
+					reg = <0>;
 					eud_ep: endpoint {
 						remote-endpoint = <&usb2_role_switch>;
 					};
 				};
+
 				port@1 {
+					reg = <1>;
 					eud_con: endpoint {
 						remote-endpoint = <&con_eud>;
 					};
@@ -3603,17 +3622,6 @@ eud_con: endpoint {
 			};
 		};
 
-		eud_typec: connector {
-			compatible = "usb-c-connector";
-			ports {
-				port@0 {
-					con_eud: endpoint {
-						remote-endpoint = <&eud_con>;
-					};
-				};
-			};
-		};
-
 		nsp_noc: interconnect@a0c0000 {
 			reg = <0 0x0a0c0000 0 0x10000>;
 			compatible = "qcom,sc7280-nsp-noc";
-- 
2.38.1

[PATCH 2/2] dt-bindings: soc: qcom: eud: Fix identation issues in the example

[Bhupesh Sharma]

As noted by Konrad while reviewing [1], the example
node in the EUD yaml documentation has identation
issues.

So fix them.

[1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
index c98aab209bc5d..385ebd7cbbf0c 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
@@ -55,9 +55,10 @@ additionalProperties: false
 examples:
   - |
     eud@88e0000 {
-           compatible = "qcom,sc7280-eud","qcom,eud";
-           reg = <0x88e0000 0x2000>,
-                 <0x88e2000 0x1000>;
+           compatible = "qcom,sc7280-eud", "qcom,eud";
+           reg = <0 0x88e0000 0 0x2000>,
+                 <0 0x88e2000 0 0x1000>;
+
            ports {
                    #address-cells = <1>;
                    #size-cells = <0>;
@@ -67,6 +68,7 @@ examples:
                                    remote-endpoint = <&usb2_role_switch>;
                            };
                    };
+
                    port@1 {
                            reg = <1>;
                            eud_con: endpoint {
-- 
2.38.1

Re: [PATCH 2/2] dt-bindings: soc: qcom: eud: Fix identation issues in the example

[Rob Herring]

On Wed, 04 Jan 2023 14:49:22 +0530, Bhupesh Sharma wrote:
> As noted by Konrad while reviewing [1], the example
> node in the EUD yaml documentation has identation
> issues.
> 
> So fix them.
> 
> [1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,eud.example.dtb: eud@88e0000: reg: [[0, 143523840], [0, 8192], [0, 143532032], [0, 4096]] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230104091922.3959602-3-bhupesh.sharma@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 2/2] dt-bindings: soc: qcom: eud: Fix identation issues in the example

[Bhupesh Sharma]

On Thu, 5 Jan 2023 at 08:24, Rob Herring <robh@kernel.org> wrote:
>
>
> On Wed, 04 Jan 2023 14:49:22 +0530, Bhupesh Sharma wrote:
> > As noted by Konrad while reviewing [1], the example
> > node in the EUD yaml documentation has identation
> > issues.
> >
> > So fix them.
> >
> > [1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,eud.example.dtb: eud@88e0000: reg: [[0, 143523840], [0, 8192], [0, 143532032], [0, 4096]] is too long
>         From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230104091922.3959602-3-bhupesh.sharma@linaro.org
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

Ok, let me try and fix this via v2.

Thanks.

Re: [PATCH 2/2] dt-bindings: soc: qcom: eud: Fix identation issues in the example

[Rob Herring]

On Wed, Jan 04, 2023 at 02:49:22PM +0530, Bhupesh Sharma wrote:
> As noted by Konrad while reviewing [1], the example
> node in the EUD yaml documentation has identation
> issues.

I don't see any indentation changes...

> 
> So fix them.
> 
> [1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> index c98aab209bc5d..385ebd7cbbf0c 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> @@ -55,9 +55,10 @@ additionalProperties: false
>  examples:
>    - |
>      eud@88e0000 {
> -           compatible = "qcom,sc7280-eud","qcom,eud";
> -           reg = <0x88e0000 0x2000>,
> -                 <0x88e2000 0x1000>;
> +           compatible = "qcom,sc7280-eud", "qcom,eud";
> +           reg = <0 0x88e0000 0 0x2000>,
> +                 <0 0x88e2000 0 0x1000>;
> +
>             ports {
>                     #address-cells = <1>;
>                     #size-cells = <0>;
> @@ -67,6 +68,7 @@ examples:
>                                     remote-endpoint = <&usb2_role_switch>;
>                             };
>                     };
> +
>                     port@1 {
>                             reg = <1>;
>                             eud_con: endpoint {
> -- 
> 2.38.1
> 
> 

Re: (subset) [PATCH 0/2] Fix EUD dt-binding doc & sc7280 EUD node syntax

[Bjorn Andersson]

On Wed, 4 Jan 2023 14:49:20 +0530, Bhupesh Sharma wrote:
> This patchset fixes the EUD dt-binding doc & sc7280 EUD node syntax.
> 
> Cc: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> 
> Bhupesh Sharma (2):
>   arm64: dts: qcom: sc7280: Fix EUD dt node syntax
>   dt-bindings: soc: qcom: eud: Fix identation issues in the example
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sc7280: Fix EUD dt node syntax
      commit: 9ee402ccfeb1638a039f2e0d455300b5f8600a81

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>