From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92448C54EBD for ; Sun, 8 Jan 2023 16:24:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9673C854DB; Sun, 8 Jan 2023 17:24:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="XnGZsOMU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 20E10854EF; Sun, 8 Jan 2023 17:24:46 +0100 (CET) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2BEBD8546C for ; Sun, 8 Jan 2023 17:24:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id t17so4609064qvw.6 for ; Sun, 08 Jan 2023 08:24:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s9P+FeBkHg/slX231YhiPvPmp98Q67sFsq5dpHfuhmo=; b=XnGZsOMUwHIsJapxNRYsK95cBevYjaXjo83Sn4r5+bJ3AZS3VlXeF3vlDXRfhS+SXW In4K8lcaPtD7UnhetUC7Iz7pNZdZFJKnH8mQ8DtYuP2+VeZjN2VJE7zX25nnWFZA06aA fyl7QlHmsM2LkRGERC7xyja41F3u4NFNhFa0A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s9P+FeBkHg/slX231YhiPvPmp98Q67sFsq5dpHfuhmo=; b=7d5G71tJ4fUg17ex05oF1omr41QnU2MR7iBGEl/U6vpyRgcwv/MZvqvGgfvrpPiNpr wkLJUMQYcm8PBbcu6vQks592B8+Qd2TF2lFzIZWol3NhaxqvP21L5RHqmmgRG/4mtDtx cMYPgl/QGrR4Rd1DVJzlOD9iPeJ6G72vl0rHlTF1QhLNMs2aN9t+L05NdwKGgyb4Sef8 xnMPcFPxbcbxGZqlQn4a9TkEAisr3HwQDDs5740bOfxzWLYNrPnXRaCUeK5FssVpxJWn ItwypVMUxVeW6tb2g+hbpSljnPbDejWZsgtjJC+JUJCUib45nU8SoFako3HROQEWKCRl d5xg== X-Gm-Message-State: AFqh2kqhskTBrGq2zKjwhgYJ4mk7Fo/61o5j+LGe3+3wpdwgp/BDDf41 J0EysEcSW14NOTSlpbxjXO00kg== X-Google-Smtp-Source: AMrXdXsxOK9ZT8ekOFil32L6bIInbwIaN6WT0pjXNRAumXvDKx0w5I1BRQpzGC0raVk1eIu7xn9eaw== X-Received: by 2002:a05:6214:1848:b0:532:2d6c:5dd7 with SMTP id d8-20020a056214184800b005322d6c5dd7mr2464099qvy.50.1673195082005; Sun, 08 Jan 2023 08:24:42 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a51c-8a60-c39b-2d7f.res6.spectrum.com. [2603:6081:7b00:6400:a51c:8a60:c39b:2d7f]) by smtp.gmail.com with ESMTPSA id y15-20020a05620a0e0f00b006f7ee901674sm3919101qkm.2.2023.01.08.08.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 08:24:40 -0800 (PST) Date: Sun, 8 Jan 2023 11:24:38 -0500 From: Tom Rini To: Simon Glass , Michal Simek , Luca Ceresoli Cc: U-Boot Mailing List , Roger Quadros , Alper Nebi Yasak , Peter Geis , Jerome Forissier , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , Ivan Mikhaylov , Quentin Schulz , Philippe Reynes Subject: Re: [PATCH v9 14/14] treewide: Disable USE_SPL_FIT_GENERATOR by default Message-ID: <20230108162438.GC3787616@bill-the-cat> References: <20230107210721.478062-1-sjg@chromium.org> <20230107210721.478062-15-sjg@chromium.org> <20230108134132.GY3787616@bill-the-cat> <20230108160605.GB3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nVMl+Xd24KGjE657" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --nVMl+Xd24KGjE657 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 08, 2023 at 09:20:09AM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Sun, 8 Jan 2023 at 09:06, Tom Rini wrote: > > > > On Sun, Jan 08, 2023 at 08:48:37AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sun, 8 Jan 2023 at 06:41, Tom Rini wrote: > > > > > > > > On Sat, Jan 07, 2023 at 02:07:21PM -0700, Simon Glass wrote: > > > > > > > > > This option is deprecated and only used by two boards. Enable it = for just > > > > > those two boards, so others don't accidentally enable it. > > > > > > > > > > Signed-off-by: Simon Glass > > > > [snip] > > > > > diff --git a/boot/Kconfig b/boot/Kconfig > > > > > index 55f06761ef8..7ab0dd14211 100644 > > > > > --- a/boot/Kconfig > > > > > +++ b/boot/Kconfig > > > > > @@ -282,12 +282,13 @@ config SPL_FIT_SOURCE > > > > > config USE_SPL_FIT_GENERATOR > > > > > bool "Use a script to generate the .its script" > > > > > depends on SPL_FIT > > > > > - default y if SPL_FIT && ARCH_ZYNQMP > > > > > + help > > > > > + This is deprecated. Please do not use it. Use binman inst= ead. > > > > > > > > Lets remove the text around bool so it can't be enabled, and move to > > > > select'ing it from the two boards that need it. Michal, Luca, what's > > > > needed to move your two platforms > > > > (avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0 and xilinx_zynqmp_vir= t off > > > > of this very legacy option, given that other xilinx platforms have > > > > already migrated to binman ? > > > > > > That's a good idea, but these two boards do not have TARGET Kconfig > > > options so it is not possible without adding some Kconfig specific to > > > those boards, then defining it in the defconfig files. > > > > > > We already have the legacy warning. > > > > Yes, but I swear these are new legacy users as when we started trying to > > kill off this option it was just a few i.MX platforms lagging behind. > > > > Maybe make ARCH_ZYNQMP select DEPRECATED, USE_SPL_FIT_GENERATOR depend > > on DEPRECATED and add "DERECATED" to the end of the text line? Or maybe > > Michal or Luca will speak up soon and migrate these over quickly so we > > can just nuke this. >=20 > Isn't that just more tortuous? I can disable SPL_LOAD_FIT on these two > boards since they don't appear in CI. Then they can convert them when > ready. >=20 > That way we can drop the option now, if that is your goal. I thought xilinx_zynqmp_virt was in CI, but I see I'm mistaken. I still don't want to break platforms outright, and since it's Sunday right now afterall, we should let Michal and Luca a chance to catch up and chime in. I hope it's either going to be a quick conversion or expose something missing and needed in binman, as to why these still haven't been converted. --=20 Tom --nVMl+Xd24KGjE657 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO67jsACgkQFHw5/5Y0 tywfdgv/VBkFCaiUGbjttpv7vFU8aItbRy3nkMJV6dQE9NmyTHB4ZYmXALxVP/94 5kaC6Bc7A+l2QXF+w0Dy55Xqm4X7epQEfV5Gj7JQ5qFoGo8EL9cs2yEc/8k8xJkg NCY7MtskR46QTxGhbFiKY9pvbRNzSJvMixQpup6sEqkm1N7BFniB1bsWhaZblGET tPJrUSRjYTqyxnlb0DDDeCZM4Ujsp+obc3fR/QsgXCO/9fSxcEPUls4BZ4jaApkf XO2F5Cjpd0ke+AtkoesqmnsDihV5SK94E+8sBmatF3QdXIdpm/bSFI+ROymuiG6+ Jar/x539sHQzOQ7ZgkgcVmDex6SsLrXjSzVQYFzlinm3LGHEjpTcqFWhMlI89SQo gw4+8e/TFFlNNc73i4gnRbHHyfO/WY1AEqvVgfZmk2xBTJEvD3VNYvoPxTo/8QGk Rtuk9YSZPDUUquuLNHRlhhJ+NpWjnmFX6DhlUoYr8Oxcev7XGoB9fYSN7jbt0HEV 7GTSBKFy =cHJB -----END PGP SIGNATURE----- --nVMl+Xd24KGjE657--