From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Shawn Guo <shawn.guo@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Richard Acayan <mailingradian@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
krishna Lanka <quic_vamslank@quicinc.com>,
Iskren Chernev <me@iskren.info>,
Martin Botka <martin.botka@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: add input-enable and bias-bus-hold
Date: Sun, 8 Jan 2023 14:08:45 -0600 [thread overview]
Message-ID: <20230108200845.GA212886-robh@kernel.org> (raw)
In-Reply-To: <20221230135645.56401-2-krzysztof.kozlowski@linaro.org>
On Fri, Dec 30, 2022 at 02:56:38PM +0100, Krzysztof Kozlowski wrote:
> Allow bias-bus-hold and input-enable properties (already used in
> SC8280XP LPASS LPI nodes):
>
> sa8540p-ride.dtb: pinctrl@33c0000: tx-swr-default-state: 'oneOf' conditional failed, one must be fixed:
> 'pins' is a required property
> 'function' is a required property
> 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+'
> 'bias-bus-hold' does not match any of the regexes: 'pinctrl-[0-9]+'
> 'gpio2' does not match '^gpio([0-1]|1[0-8])$'
Wrong warning?
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml
> index 309d3dd9013b..9a3f1fb8c2f7 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml
> @@ -94,14 +94,12 @@ $defs:
> 2: Lower Slew rate (slower edges)
> 3: Reserved (No adjustments)
>
> + bias-bus-hold: true
> bias-pull-down: true
> -
> bias-pull-up: true
> -
> bias-disable: true
> -
> + input-enable: true
> output-high: true
> -
> output-low: true
>
> required:
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2023-01-08 20:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 13:56 [PATCH 1/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: correct pins pattern Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 2/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: add input-enable and bias-bus-hold Krzysztof Kozlowski
2023-01-08 20:08 ` Rob Herring [this message]
2023-01-09 9:19 ` Krzysztof Kozlowski
2023-01-13 10:50 ` (subset) " Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 3/9] dt-bindings: pinctrl: qcom,sm6350-tlmm: add gpio-line-names Krzysztof Kozlowski
2023-01-08 20:09 ` Rob Herring
2023-01-13 10:50 ` (subset) " Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 4/9] dt-bindings: pinctrl: qcom,sm8350-tlmm: " Krzysztof Kozlowski
2023-01-08 20:10 ` Rob Herring
2023-01-13 10:50 ` (subset) " Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 5/9] dt-bindings: pinctrl: qcom,sm6350-tlmm: correct pins pattern Krzysztof Kozlowski
2023-01-08 20:10 ` Rob Herring
2023-01-13 10:50 ` (subset) " Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 6/9] dt-bindings: pinctrl: qcom,sm8350-tlmm: " Krzysztof Kozlowski
2023-01-08 20:11 ` Rob Herring
2023-01-13 10:50 ` (subset) " Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 7/9] dt-bindings: pinctrl: qcom: allow nine interrupts on SM6350 Krzysztof Kozlowski
2023-01-08 20:13 ` Rob Herring
2023-01-13 10:50 ` (subset) " Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 8/9] arm64: dts: qcom: msm8916-samsung-a2015: correct motor pinctrl node name Krzysztof Kozlowski
2022-12-30 13:56 ` [PATCH 9/9] arm64: dts: qcom: sc7280-idp: add amp pin config function Krzysztof Kozlowski
2023-01-08 20:08 ` [PATCH 1/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: correct pins pattern Rob Herring
2023-01-13 10:50 ` (subset) " Krzysztof Kozlowski
2023-01-18 23:55 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108200845.GA212886-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=martin.botka@somainline.org \
--cc=me@iskren.info \
--cc=quic_vamslank@quicinc.com \
--cc=shawn.guo@linaro.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.