All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Anders F Björklund" <anders.f.bjorklund@gmail.com>,
	"Andrey Smirnov" <andrew.smirnov@gmail.com>,
	"Samuel Martin" <s.martin49@gmail.com>,
	"Dominik Michael Rauh" <dmrauh@posteo.de>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org,
	"Fabrice Fontaine" <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH 2/4] package/zstd: disable ccache for host package
Date: Sun, 8 Jan 2023 22:44:54 +0100	[thread overview]
Message-ID: <20230108214454.GH151997@scaer> (raw)
In-Reply-To: <20230107010437.2471513-2-james.hilliard1@gmail.com>

James, All,

+Dominik +Anders

On 2023-01-06 18:04 -0700, James Hilliard spake thusly:
> We need to disable ccache when building host-zstd as the upcoming
> ccache update depends on host-zstd.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/zstd/zstd.mk | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk
> index e8f6315222..cb4f4cc611 100644
> --- a/package/zstd/zstd.mk
> +++ b/package/zstd/zstd.mk
> @@ -98,12 +98,16 @@ endef
>  HOST_ZSTD_OPTS += PREFIX=$(HOST_DIR)
>  
>  define HOST_ZSTD_BUILD_CMDS
> -	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) $(HOST_ZSTD_OPTS) \
> +	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) \
> +	CC="$(HOSTCC_NOCCACHE)" CXX="$(HOSTCXX_NOCCACHE)" \
> +	$(MAKE) $(HOST_ZSTD_OPTS) \
>  		-C $(@D) zstd-release lib-release
>  endef
>  
>  define HOST_ZSTD_INSTALL_CMDS
> -	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) $(HOST_ZSTD_OPTS) \
> +	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) \
> +	CC="$(HOSTCC_NOCCACHE)" CXX="$(HOSTCXX_NOCCACHE)" \
> +	$(MAKE) $(HOST_ZSTD_OPTS) \

Rather than duplicating the environment in both _CMDS, I've introduce
HOST_ZSTD_ENV.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  		-C $(@D) install
>  endef
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-01-08 21:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-07  1:04 [Buildroot] [PATCH 1/4] package/hiredis: enable host package James Hilliard
2023-01-07  1:04 ` [Buildroot] [PATCH 2/4] package/zstd: disable ccache for " James Hilliard
2023-01-08 21:44   ` Yann E. MORIN [this message]
2023-01-07  1:04 ` [Buildroot] [PATCH 3/4] package/pkgconf: " James Hilliard
2023-01-08 21:58   ` Yann E. MORIN
2023-01-07  1:04 ` [Buildroot] [PATCH 4/4] package/ccache: bump to version 4.7.4 James Hilliard
2023-01-08 22:29   ` Yann E. MORIN
2023-01-09  0:22     ` James Hilliard
2023-01-09 19:21     ` Dominik Michael Rauh
2023-01-09 19:55       ` James Hilliard
2023-01-08 21:15 ` [Buildroot] [PATCH 1/4] package/hiredis: enable host package Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230108214454.GH151997@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=anders.f.bjorklund@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=dmrauh@posteo.de \
    --cc=fontaine.fabrice@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=s.martin49@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.