From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, Jason Wang <jasowang@redhat.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Cornelia Huck <cohuck@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH v7] virtio-net: support inner header hash
Date: Mon, 9 Jan 2023 06:39:40 -0500 [thread overview]
Message-ID: <20230109063654-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230104071401.31746-1-hengqi@linux.alibaba.com>
On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote:
> +are defined below:
> +
> +\begin{lstlisting}
> +#define VIRTIO_NET_HASH_REPORT_TUNNEL_NONE 0
> +#define VIRTIO_NET_HASH_REPORT_GRE 1
> +#define VIRTIO_NET_HASH_REPORT_VXLAN 2
> +#define VIRTIO_NET_HASH_REPORT_GENEVE 3
> +\end{lstlisting}
Btw this "are defined below" all over the place is just contributing
to making the spec unnecesarily verbose. Simple "are:" will do.
--
MST
next prev parent reply other threads:[~2023-01-09 11:39 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 7:14 [PATCH v7] virtio-net: support inner header hash Heng Qi
2023-01-04 12:34 ` [virtio-comment] " Heng Qi
2023-01-04 12:37 ` Michael S. Tsirkin
2023-01-06 5:27 ` Michael S. Tsirkin
2023-01-06 6:42 ` [virtio-comment] " Heng Qi
2023-01-06 6:59 ` Michael S. Tsirkin
2023-01-09 2:43 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-01-09 8:59 ` Jason Wang
2023-01-09 11:34 ` Michael S. Tsirkin
2023-01-10 2:06 ` Jason Wang
2023-01-10 5:24 ` Michael S. Tsirkin
2023-01-10 5:57 ` Michael S. Tsirkin
2023-01-10 7:26 ` Heng Qi
2023-01-11 3:22 ` [virtio-comment] " Heng Qi
2023-01-11 4:45 ` Jason Wang
2023-01-11 9:49 ` Michael S. Tsirkin
2023-01-09 11:36 ` Michael S. Tsirkin
2023-01-10 7:46 ` Heng Qi
2023-01-09 11:39 ` Michael S. Tsirkin [this message]
2023-01-10 7:47 ` [virtio-comment] " Heng Qi
2023-01-11 9:45 ` Michael S. Tsirkin
2023-01-16 8:01 ` [virtio-comment] " Heng Qi
2023-01-16 8:18 ` [virtio-dev] " Cornelia Huck
2023-01-31 5:31 ` Heng Qi
2023-01-16 8:42 ` Jason Wang
2023-01-31 5:28 ` [virtio-dev] " Heng Qi
2023-02-08 2:30 ` Heng Qi
2023-02-08 3:19 ` Parav Pandit
2023-02-08 3:24 ` Heng Qi
2023-02-08 5:18 ` Parav Pandit
2023-02-08 6:11 ` Heng Qi
2023-02-08 12:21 ` Parav Pandit
2023-02-09 5:20 ` [virtio-comment] " Heng Qi
2023-02-09 5:34 ` Parav Pandit
2023-02-09 9:57 ` Heng Qi
2023-02-11 2:08 ` [virtio-comment] " Heng Qi
2023-02-08 13:31 ` [virtio-comment] " Michael S. Tsirkin
2023-02-08 13:38 ` Parav Pandit
2023-02-08 13:52 ` Michael S. Tsirkin
2023-02-08 14:00 ` Parav Pandit
2023-02-08 14:09 ` Michael S. Tsirkin
2023-02-08 14:29 ` Parav Pandit
2023-02-09 5:12 ` Heng Qi
2023-02-09 6:05 ` [virtio-dev] " Heng Qi
2023-02-08 14:05 ` Parav Pandit
2023-02-08 14:10 ` Michael S. Tsirkin
2023-01-18 23:45 ` [virtio-dev] " Parav Pandit
2023-01-31 5:57 ` [virtio-comment] " Heng Qi
2023-02-01 1:51 ` Parav Pandit
2023-02-01 6:47 ` Michael S. Tsirkin
2023-02-01 6:56 ` Michael S. Tsirkin
2023-02-02 3:55 ` Parav Pandit
2023-02-02 6:55 ` Heng Qi
2023-02-01 7:14 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109063654-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.