From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCHv3 net-next] sched: multicast sched extack messages
Date: Mon, 9 Jan 2023 11:43:06 -0800 [thread overview]
Message-ID: <20230109114306.07d81e76@kernel.org> (raw)
In-Reply-To: <CAM0EoMkw8GA=KA_FXV8v4a-RKYCibK64ngp9hRQeT1UzXY4LCg@mail.gmail.com>
On Mon, 9 Jan 2023 10:56:00 -0500 Jamal Hadi Salim wrote:
> IMO the feature is useful. The idea of using a single tool to get the
> details improves the operational experience.
> And in this case this is a valid event (someone tried to add an entry to
> hardware and s/ware and it worked for
> one and not the other).
> I think Jakub's objection is in the approach.
Right.
> Jakub, would using specific attributes restricted to
> just QDISC/FILTER/ACTION work for you?
Yes, specific attr to wrap the extack seems acceptable.
next prev parent reply other threads:[~2023-01-09 19:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:16 [PATCHv3 net-next] sched: multicast sched extack messages Hangbin Liu
2023-01-05 4:01 ` Jakub Kicinski
2023-01-05 10:12 ` Hangbin Liu
2023-01-09 15:57 ` Jamal Hadi Salim
[not found] ` <CAM0EoMkw8GA=KA_FXV8v4a-RKYCibK64ngp9hRQeT1UzXY4LCg@mail.gmail.com>
2023-01-09 19:43 ` Jakub Kicinski [this message]
2023-01-10 10:17 ` Hangbin Liu
2023-01-10 17:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109114306.07d81e76@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.