From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67F7AC5479D for ; Mon, 9 Jan 2023 15:05:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4756C85606; Mon, 9 Jan 2023 16:05:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="KdeBBkWK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B3E6885507; Mon, 9 Jan 2023 16:05:42 +0100 (CET) Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 28BC28547C for ; Mon, 9 Jan 2023 16:05:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-482363a1232so116431847b3.3 for ; Mon, 09 Jan 2023 07:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=43KjoTU2EGeMg5WJ3yDPpkZ1+VjxA7rNzCTu9gooRGk=; b=KdeBBkWKi6YMGXDzi9ZUmT2ahHnEj+2DSRrUAdvMcu+UmgZUrft8Cw6SKfugER/NZm VSdfqXPetFYBbX+CcPM7Ox0EgEBh0sGpIUDiC7iyZCL4N1/0xonRQzCZy6r59hWAUEXg aMXks7vUzu206eDV8F0syq6dfbQSXdxgkiRbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=43KjoTU2EGeMg5WJ3yDPpkZ1+VjxA7rNzCTu9gooRGk=; b=eJO2ERk3oG8XgEOL5vb/2sCo4XpE96eLviCU7kqg/J0LPH5bg8VSgJLB0bJ536OF8c NQLj77uqtwa0jY1DFsrWNAsBdEGDoxbZuvZlgPGYkd9kipPuqEiplgKxC2mVzCKeA63k gLF+GWctLK/HwKrQJuidwk8Jz8896eYmBgRPXCU568vSn447PemRX5352AoPnnrsJGiI cc32BmdeW0i5IkBT4J2cV5+UZ0anYwI8bwbFVaUIz8w/QmcnwCEzdJsMdRHjtqiT6rc2 jiU8MUSMg2YCzbAqwLkJtGocXU5ygfCxLQPpXG+HoVDFDaGInV8hGtacwqkPUZxi5MWT Vnkw== X-Gm-Message-State: AFqh2kr5GMsReEZt1QsE/IMRl3J4cAMcRVqr2EDeWMCNgUKBUyk+N2Hu uR8e4QbFnDrdLw5RGwempgX55g== X-Google-Smtp-Source: AMrXdXtUY2/WrrHyGPmJe1EtIK7wCX9ilCyNySYBmnyziqp2NuMgYZrdmXOnfRv38rD6b/zXdP10IA== X-Received: by 2002:a05:7500:460f:b0:ee:5696:2cca with SMTP id ge15-20020a057500460f00b000ee56962ccamr3766827gab.59.1673276737720; Mon, 09 Jan 2023 07:05:37 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0159-9ce3-e1a8-fcba.res6.spectrum.com. [2603:6081:7b00:6400:159:9ce3:e1a8:fcba]) by smtp.gmail.com with ESMTPSA id w19-20020a05620a445300b006fc3fa1f589sm5463505qkp.114.2023.01.09.07.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:05:37 -0800 (PST) Date: Mon, 9 Jan 2023 10:05:34 -0500 From: Tom Rini To: Michal Simek Cc: Simon Glass , Luca Ceresoli , U-Boot Mailing List , Roger Quadros , Alper Nebi Yasak , Peter Geis , Jerome Forissier , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , Ivan Mikhaylov , Quentin Schulz , Philippe Reynes Subject: Re: [PATCH v9 14/14] treewide: Disable USE_SPL_FIT_GENERATOR by default Message-ID: <20230109150534.GL3787616@bill-the-cat> References: <20230107210721.478062-15-sjg@chromium.org> <20230108134132.GY3787616@bill-the-cat> <20230108160605.GB3787616@bill-the-cat> <20230108162438.GC3787616@bill-the-cat> <128e89b7-db5b-a842-6990-19c52de9da22@amd.com> <20230109141215.GI3787616@bill-the-cat> <725130e5-9de2-6c90-a903-f5669db7001b@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YhDNl1M+szlB4wef" Content-Disposition: inline In-Reply-To: <725130e5-9de2-6c90-a903-f5669db7001b@amd.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --YhDNl1M+szlB4wef Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 09, 2023 at 03:37:20PM +0100, Michal Simek wrote: >=20 >=20 > On 1/9/23 15:12, Tom Rini wrote: > > On Mon, Jan 09, 2023 at 12:07:05PM +0100, Michal Simek wrote: > > > Hi, > > >=20 > > > On 1/8/23 20:36, Simon Glass wrote: > > > > Hi Tom, > > > >=20 > > > > On Sun, 8 Jan 2023 at 09:24, Tom Rini wrote: > > > > >=20 > > > > > On Sun, Jan 08, 2023 at 09:20:09AM -0700, Simon Glass wrote: > > > > > > Hi Tom, > > > > > >=20 > > > > > > On Sun, 8 Jan 2023 at 09:06, Tom Rini wrot= e: > > > > > > >=20 > > > > > > > On Sun, Jan 08, 2023 at 08:48:37AM -0700, Simon Glass wrote: > > > > > > > > Hi Tom, > > > > > > > >=20 > > > > > > > > On Sun, 8 Jan 2023 at 06:41, Tom Rini = wrote: > > > > > > > > >=20 > > > > > > > > > On Sat, Jan 07, 2023 at 02:07:21PM -0700, Simon Glass wro= te: > > > > > > > > >=20 > > > > > > > > > > This option is deprecated and only used by two boards. = Enable it for just > > > > > > > > > > those two boards, so others don't accidentally enable i= t. > > > > > > > > > >=20 > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > [snip] > > > > > > > > > > diff --git a/boot/Kconfig b/boot/Kconfig > > > > > > > > > > index 55f06761ef8..7ab0dd14211 100644 > > > > > > > > > > --- a/boot/Kconfig > > > > > > > > > > +++ b/boot/Kconfig > > > > > > > > > > @@ -282,12 +282,13 @@ config SPL_FIT_SOURCE > > > > > > > > > > config USE_SPL_FIT_GENERATOR > > > > > > > > > > bool "Use a script to generate the .its script" > > > > > > > > > > depends on SPL_FIT > > > > > > > > > > - default y if SPL_FIT && ARCH_ZYNQMP > > > > > > > > > > + help > > > > > > > > > > + This is deprecated. Please do not use it. Use b= inman instead. > > > > > > > > >=20 > > > > > > > > > Lets remove the text around bool so it can't be enabled, = and move to > > > > > > > > > select'ing it from the two boards that need it. Michal, L= uca, what's > > > > > > > > > needed to move your two platforms > > > > > > > > > (avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0 and xilinx_= zynqmp_virt off > > > > > > > > > of this very legacy option, given that other xilinx platf= orms have > > > > > > > > > already migrated to binman ? > > > > > > > >=20 > > > > > > > > That's a good idea, but these two boards do not have TARGET= Kconfig > > > > > > > > options so it is not possible without adding some Kconfig s= pecific to > > > > > > > > those boards, then defining it in the defconfig files. > > > > > > > >=20 > > > > > > > > We already have the legacy warning. > > > > > > >=20 > > > > > > > Yes, but I swear these are new legacy users as when we starte= d trying to > > > > > > > kill off this option it was just a few i.MX platforms lagging= behind. > > > > > > >=20 > > > > > > > Maybe make ARCH_ZYNQMP select DEPRECATED, USE_SPL_FIT_GENERAT= OR depend > > > > > > > on DEPRECATED and add "DERECATED" to the end of the text line= ? Or maybe > > > > > > > Michal or Luca will speak up soon and migrate these over quic= kly so we > > > > > > > can just nuke this. > > > > > >=20 > > > > > > Isn't that just more tortuous? I can disable SPL_LOAD_FIT on th= ese two > > > > > > boards since they don't appear in CI. Then they can convert the= m when > > > > > > ready. > > > > > >=20 > > > > > > That way we can drop the option now, if that is your goal. > > > > >=20 > > > > > I thought xilinx_zynqmp_virt was in CI, but I see I'm mistaken. I= still > > > > > don't want to break platforms outright, and since it's Sunday rig= ht now > > > > > afterall, we should let Michal and Luca a chance to catch up and = chime > > > > > in. I hope it's either going to be a quick conversion or expose > > > > > something missing and needed in binman, as to why these still hav= en't > > > > > been converted. > > > > >=20 > > > >=20 > > > > OK let's hold off on this patch for now. It is just a clean-up anyw= ay. > > >=20 > > > First of all. ZynqMP is not wired in CI simply because we are missing= some > > > bits and pieces in upstream qemu to run it. If we can wire it with Xi= linx > > > version we can do it. I have asked to fix it our qemu team but they h= ave > > > never done it. > >=20 > > Ah yes, I remember you saying that now. I guess it comes down to how > > hard it would be to patch that support in to 6.1.0 (or, move us up to a > > newer release and patch on top of that) in tools/docker/Dockerfile. We > > special-case the nokia_rx51 support in QEMU because it's so old, so I'd > > rather avoid that for another platform if we can. >=20 > Issue is with firmware interface which is going over mailbox to microblaze > unit which runs power management firmware. It means it not single qemu > instance which Xilinx uses. There are 2. One microblaze and second ARM and > IIRC communication is done via socket. > I don't think this will get to Qemu anytime soon. > But on the other hand in past we normally run arm core without any firmwa= re > on Microblaze. We would have to disable communication between ARM and > Microblaze and work with fixed clock. After it we should be able to run > zynqmp under CI. > I have already asked my colleagues to fix drivers which can't work with > ZYNQMP_FIRMWARE off. Also I have seen one missing Kconfig dependency. >=20 > And then next step would be to identify some registers which Qemu doesn't > model but u-boot is reading. I don't think they are modeled now. >=20 > IIRC we still have internal task to get ZynqMP CI in our tracking system > that's why we will get there at some point. OK, I'll be hopeful things get resolved at least internally sometime soon, more CI is always better. Thanks for explaining. --=20 Tom --YhDNl1M+szlB4wef Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO8LTQACgkQFHw5/5Y0 tyxh6gv+LqFDpxyGN7S/NfihzxgH+b7/xd0ev8RycKBpa3xQuMqlm3BQ92eDEvdy 0EvNnvAe81Q74nPjAdmTlWdpf3+G16bHgluIhvopAFUwswY4UZCgHeUkeIeTxPeS W5SLUHoxUHMtsB1eiLnZBaNyEH3NxnljyZ46+utgs4GV2/5qlxq+QLD76F55TyhH cBTw40bct834kbzvR/A9E1EI3p4Giplt4tSAtQ+IiUbF4OH5AT08i9mmgYD0BOJD bUo8xQoPcHGKtLstMDNTIUWCeAME01ap7/xK3ebzUJC2FetaStKqtGj8q5+nQx2c BcWEXfyedXFL+0dbNn02QRn8HHyKD7RaCE+R09rhPgiSLc9I5/RluMVckYwXPzHz Rd4RemCGhn7vBW1P1y35+dE1KhGfEU1+ehNmi59TpIIzqit2sPWGeBSLUp5PksV4 MKBdpSIsWqrNeQByH6IIhC6aipj4tu204BZ5jCl3zVhHuFrQPIS6XDHJD9I0hRPi 9mcZw9xg =VbUQ -----END PGP SIGNATURE----- --YhDNl1M+szlB4wef--