Hi Mark,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on rafael-pm/linux-next arm/for-next arm/fixes kvmarm/next soc/for-next xilinx-xlnx/master linus/master v6.2-rc3 next-20230109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mark-Rutland/Compiler-attributes-GCC-function-alignment-workarounds/20230109-220351
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
patch link:    https://lore.kernel.org/r/20230109135828.879136-5-mark.rutland%40arm.com
patch subject: [PATCH 4/8] ftrace: Add DYNAMIC_FTRACE_WITH_CALL_OPS
config: mips-allmodconfig
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2a23faafde92f517fcb8d1a56b2f89dddf0d693e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mark-Rutland/Compiler-attributes-GCC-function-alignment-workarounds/20230109-220351
        git checkout 2a23faafde92f517fcb8d1a56b2f89dddf0d693e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/compiler_types.h:79,
                    from <command-line>:
   include/linux/compiler_attributes.h:41:5: warning: "CONFIG_FUNCTION_ALIGNMENT" is not defined, evaluates to 0 [-Wundef]
      41 | #if CONFIG_FUNCTION_ALIGNMENT > 0
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler_attributes.h:96:36: warning: "CONFIG_FUNCTION_ALIGNMENT" is not defined, evaluates to 0 [-Wundef]
      96 | #if !defined(CONFIG_CC_IS_GCC) || (CONFIG_FUNCTION_ALIGNMENT == 0)
         |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from kernel/trace/ftrace.c:29:
   include/linux/ftrace.h:62:50: warning: 'struct dyn_ftrace' declared inside parameter list will not be visible outside of this definition or declaration
      62 | struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec);
         |                                                  ^~~~~~~~~~
   kernel/trace/ftrace.c:326:5: warning: no previous prototype for '__register_ftrace_function' [-Wmissing-prototypes]
     326 | int __register_ftrace_function(struct ftrace_ops *ops)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/trace/ftrace.c:369:5: warning: no previous prototype for '__unregister_ftrace_function' [-Wmissing-prototypes]
     369 | int __unregister_ftrace_function(struct ftrace_ops *ops)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/trace/ftrace.c:2504:1: error: conflicting types for 'ftrace_find_unique_ops'; have 'struct ftrace_ops *(struct dyn_ftrace *)'
    2504 | ftrace_find_unique_ops(struct dyn_ftrace *rec)
         | ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/ftrace.h:62:20: note: previous declaration of 'ftrace_find_unique_ops' with type 'struct ftrace_ops *(struct dyn_ftrace *)'
      62 | struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec);
         |                    ^~~~~~~~~~~~~~~~~~~~~~
   kernel/trace/ftrace.c:4096:15: warning: no previous prototype for 'arch_ftrace_match_adjust' [-Wmissing-prototypes]
    4096 | char * __weak arch_ftrace_match_adjust(char *str, const char *search)
         |               ^~~~~~~~~~~~~~~~~~~~~~~~


vim +2504 kernel/trace/ftrace.c

  2502	
  2503	struct ftrace_ops *
> 2504	ftrace_find_unique_ops(struct dyn_ftrace *rec)
  2505	{
  2506		struct ftrace_ops *op, *found = NULL;
  2507		unsigned long ip = rec->ip;
  2508	
  2509		do_for_each_ftrace_op(op, ftrace_ops_list) {
  2510	
  2511			if (hash_contains_ip(ip, op->func_hash)) {
  2512				if (found)
  2513					return NULL;
  2514				found = op;
  2515			}
  2516	
  2517		} while_for_each_ftrace_op(op);
  2518	
  2519		return found;
  2520	}
  2521	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests