From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60627C54EBE for ; Tue, 10 Jan 2023 08:07:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B6914DB82; Tue, 10 Jan 2023 09:07:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B6914DB82 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673338071; bh=5GTi7+RPVgkRxMgzw1d9Z/gZXCJ0yFSZeXCQR2MvDtE=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=ukhWmp5X9TVpp73jGFbs8TRLYmuKTqZRsXl2IfCyKg4+MhyoQZqXGGCOo4etgFqsj qtl76AXaXVv+mN51lMFf617tP28iD8xrUHlQBxVYkeS8oDlOlf4JuJlqVyHiGjAQL5 xtmjtcFSCEhOssOX6DZvW/jLYKkluy3pHpRThdZc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 696C4F804BD; Tue, 10 Jan 2023 09:07:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8A0E6F804C1; Tue, 10 Jan 2023 09:06:59 +0100 (CET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C6E2DF8019B for ; Tue, 10 Jan 2023 09:06:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C6E2DF8019B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=O1Opaji6 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D5F824000B; Tue, 10 Jan 2023 08:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tanCnt41dmd3a1gqbCEA0TYYO9/oTjI6yAv4OQDOAo=; b=O1Opaji665s44TE1LAeK3X1D4fYZJDuZSpYGeI1q8gABik0Z1kaEh03swno0937SJj0yue 74GZCclMht4rcz4psoZvlBrAchwISnRoslZZufPnjF5IrvTUhHz2LldITerMDLfGFUgTms vHXaY1Ki1l23UicholMhpxt39CFMdnggwaNe0ljcsOiKVXKdvXP2KpthwiBLx9AG+xADXI wI6theO2IKhw2keeah0YYzKanAJEVpCPQbhCl2DFoZDmnrFIHdKhbfqupQ7yd24kqen1xf RUnZhIVGv4EnLnguFl4GNBxmLEakSSnAOCuv1ahzmgXZYkitFZFF9fqzE/f3GA== Date: Tue, 10 Jan 2023 09:06:50 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v2 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230110090650.2138edf0@bootlin.com> In-Reply-To: <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-6-herve.codina@bootlin.com> <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Christophe Leroy , Krzysztof Kozlowski , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Krzysztof, On Sun, 8 Jan 2023 16:14:47 +0100 Krzysztof Kozlowski wrote: [...] > > + > > + interrupts: > > + description: SCC interrupt line in the CPM interrupt controller =20 >=20 > Missing constraints. 'maxItems: 1' will be added in v3 >=20 > > + > > + fsl,cpm-command: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Cf. soc/fsl/cpm_qe/cpm.txt =20 >=20 > Missing description. 'fsl,cpm-command' will be removed in v3. The value needed is determined based on other information. This is not needed in the DT. >=20 > > + > > + tsa: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the TSA =20 >=20 > Missing vendor prefix. Does not look like a generic property. Will be be changed to 'fsl,tsa' and also 'tsa-cell-id' will be changed to 'fsl,tsa-cell-id' >=20 [...] > > + > > +patternProperties: > > + "^channel@([0-9]|[1-5][0-9]|6[0-3])$": > > + description: > > + A channel managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The channel number > > + > > + fsl,mode: > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [transparent, hdlc] > > + default: transparent > > + description: Operational mode =20 >=20 > And what do they mean? I will change with description: | The channel operational mode - hdlc: The channel handles HDLC frames - transparent: The channel handles raw data without any processing >=20 > > + > > + fsl,reverse-data: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The bit order as seen on the channels is reversed, > > + transmitting/receiving the MSB of each octet first. > > + This flag is used only in 'transparent' mode. > > + > > + tx-ts-mask: =20 >=20 > Missing vendor prefix. Will be added, also on rx-ts-mask. >=20 > > + $ref: /schemas/types.yaml#/definitions/uint64 > > + description: > > + Channel assigned Tx time-slots within the Tx time-slots rout= ed > > + by the TSA to this cell. > > + > > + rx-ts-mask: > > + $ref: /schemas/types.yaml#/definitions/uint64 > > + description: > > + Channel assigned Rx time-slots within the Rx time-slots rout= ed > > + by the TSA to this cell. > > + > > + required: > > + - reg > > + - tx-ts-mask > > + - rx-ts-mask > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - interrupts > > + - tsa > > + - tsa-cell-id > > + - '#address-cells' > > + - '#size-cells' > > + - '#chan-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + scc_qmc@a60 { =20 >=20 > No underscores in node names. >=20 > Node names should be generic. > https://devicetree-specification.readthedocs.io/en/latest/chapter2-device= tree-basics.html#generic-names-recommendation Will be changed to qmc@a60 >=20 > > + compatible =3D "fsl,mpc885-scc-qmc", "fsl,cpm1-scc-qmc"; > > + reg =3D <0xa60 0x20>, > > + <0x3f00 0xc0>, > > + <0x2000 0x1000>; > > + reg-names =3D "scc_regs", "scc_pram", "dpram"; > > + interrupts =3D <27>; > > + interrupt-parent =3D <&CPM_PIC>; > > + fsl,cpm-command =3D <0xc0>; > > + > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + #chan-cells =3D <1>; > > + > > + tsa =3D <&tsa>; > > + tsa-cell-id =3D ; > > + > > + channel@16 { > > + /* Ch16 : First 4 even TS from all routed from TSA */ > > + reg =3D <16>; > > + fsl,mode =3D "transparent"; > > + fsl,reverse-data; > > + tx-ts-mask =3D <0x00000000 0x000000AA>; > > + rx-ts-mask =3D <0x00000000 0x000000AA>; =20 >=20 > Keep case consistent. lower-case hex. Will be fixed >=20 > Best regards, > Krzysztof >=20 Thanks for the review, Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 444BBC46467 for ; Tue, 10 Jan 2023 08:07:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Nrk2M4zLpz3ch8 for ; Tue, 10 Jan 2023 19:07:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=O1Opaji6; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::221; helo=relay1-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=O1Opaji6; dkim-atps=neutral Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Nrk1M03sLz3c6G for ; Tue, 10 Jan 2023 19:07:02 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D5F824000B; Tue, 10 Jan 2023 08:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tanCnt41dmd3a1gqbCEA0TYYO9/oTjI6yAv4OQDOAo=; b=O1Opaji665s44TE1LAeK3X1D4fYZJDuZSpYGeI1q8gABik0Z1kaEh03swno0937SJj0yue 74GZCclMht4rcz4psoZvlBrAchwISnRoslZZufPnjF5IrvTUhHz2LldITerMDLfGFUgTms vHXaY1Ki1l23UicholMhpxt39CFMdnggwaNe0ljcsOiKVXKdvXP2KpthwiBLx9AG+xADXI wI6theO2IKhw2keeah0YYzKanAJEVpCPQbhCl2DFoZDmnrFIHdKhbfqupQ7yd24kqen1xf RUnZhIVGv4EnLnguFl4GNBxmLEakSSnAOCuv1ahzmgXZYkitFZFF9fqzE/f3GA== Date: Tue, 10 Jan 2023 09:06:50 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v2 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230110090650.2138edf0@bootlin.com> In-Reply-To: <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-6-herve.codina@bootlin.com> <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Krzysztof, On Sun, 8 Jan 2023 16:14:47 +0100 Krzysztof Kozlowski wrote: [...] > > + > > + interrupts: > > + description: SCC interrupt line in the CPM interrupt controller =20 >=20 > Missing constraints. 'maxItems: 1' will be added in v3 >=20 > > + > > + fsl,cpm-command: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Cf. soc/fsl/cpm_qe/cpm.txt =20 >=20 > Missing description. 'fsl,cpm-command' will be removed in v3. The value needed is determined based on other information. This is not needed in the DT. >=20 > > + > > + tsa: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the TSA =20 >=20 > Missing vendor prefix. Does not look like a generic property. Will be be changed to 'fsl,tsa' and also 'tsa-cell-id' will be changed to 'fsl,tsa-cell-id' >=20 [...] > > + > > +patternProperties: > > + "^channel@([0-9]|[1-5][0-9]|6[0-3])$": > > + description: > > + A channel managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The channel number > > + > > + fsl,mode: > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [transparent, hdlc] > > + default: transparent > > + description: Operational mode =20 >=20 > And what do they mean? I will change with description: | The channel operational mode - hdlc: The channel handles HDLC frames - transparent: The channel handles raw data without any processing >=20 > > + > > + fsl,reverse-data: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The bit order as seen on the channels is reversed, > > + transmitting/receiving the MSB of each octet first. > > + This flag is used only in 'transparent' mode. > > + > > + tx-ts-mask: =20 >=20 > Missing vendor prefix. Will be added, also on rx-ts-mask. >=20 > > + $ref: /schemas/types.yaml#/definitions/uint64 > > + description: > > + Channel assigned Tx time-slots within the Tx time-slots rout= ed > > + by the TSA to this cell. > > + > > + rx-ts-mask: > > + $ref: /schemas/types.yaml#/definitions/uint64 > > + description: > > + Channel assigned Rx time-slots within the Rx time-slots rout= ed > > + by the TSA to this cell. > > + > > + required: > > + - reg > > + - tx-ts-mask > > + - rx-ts-mask > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - interrupts > > + - tsa > > + - tsa-cell-id > > + - '#address-cells' > > + - '#size-cells' > > + - '#chan-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + scc_qmc@a60 { =20 >=20 > No underscores in node names. >=20 > Node names should be generic. > https://devicetree-specification.readthedocs.io/en/latest/chapter2-device= tree-basics.html#generic-names-recommendation Will be changed to qmc@a60 >=20 > > + compatible =3D "fsl,mpc885-scc-qmc", "fsl,cpm1-scc-qmc"; > > + reg =3D <0xa60 0x20>, > > + <0x3f00 0xc0>, > > + <0x2000 0x1000>; > > + reg-names =3D "scc_regs", "scc_pram", "dpram"; > > + interrupts =3D <27>; > > + interrupt-parent =3D <&CPM_PIC>; > > + fsl,cpm-command =3D <0xc0>; > > + > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + #chan-cells =3D <1>; > > + > > + tsa =3D <&tsa>; > > + tsa-cell-id =3D ; > > + > > + channel@16 { > > + /* Ch16 : First 4 even TS from all routed from TSA */ > > + reg =3D <16>; > > + fsl,mode =3D "transparent"; > > + fsl,reverse-data; > > + tx-ts-mask =3D <0x00000000 0x000000AA>; > > + rx-ts-mask =3D <0x00000000 0x000000AA>; =20 >=20 > Keep case consistent. lower-case hex. Will be fixed >=20 > Best regards, > Krzysztof >=20 Thanks for the review, Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91173C46467 for ; Tue, 10 Jan 2023 08:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f1SxBlkoDPOvxtBbCVuwjIIe+SduVPZmDfxheSURbbc=; b=Y+1Tc4FbwVKHPQ Upn98/2hH2k9Dhi1WG59JCFXDu0cHkrUpi/aJ84BaADPQWQMw0RZ1WimfZASxtbvrhOgz94351zh2 Be51clPGfPqVRSrXivgaUH0e90iuyBGAcAIRgdwSXEsN8iJ/+AI+LIsS8DbsY2xjrCiCEiSTlSn9w 1cxVITnSJ7w5XKtzYftZ/4f/4790JalGvN2twxaki5eYuLOUKKAYJYuSulmWTZUBJI+AHVeRA5Qav EFHrIIlwkaFjm0ldAj2UpaoHpUdwAiBaqLkL/FdYsjClyBzPGfn5hhST2XLXA39nlsmbLL5w/wDiI HHV5ZaAfPI7M+j+jOqYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF9f0-005i29-6K; Tue, 10 Jan 2023 08:07:06 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF9eu-005hxN-Uz for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 08:07:03 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D5F824000B; Tue, 10 Jan 2023 08:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tanCnt41dmd3a1gqbCEA0TYYO9/oTjI6yAv4OQDOAo=; b=O1Opaji665s44TE1LAeK3X1D4fYZJDuZSpYGeI1q8gABik0Z1kaEh03swno0937SJj0yue 74GZCclMht4rcz4psoZvlBrAchwISnRoslZZufPnjF5IrvTUhHz2LldITerMDLfGFUgTms vHXaY1Ki1l23UicholMhpxt39CFMdnggwaNe0ljcsOiKVXKdvXP2KpthwiBLx9AG+xADXI wI6theO2IKhw2keeah0YYzKanAJEVpCPQbhCl2DFoZDmnrFIHdKhbfqupQ7yd24kqen1xf RUnZhIVGv4EnLnguFl4GNBxmLEakSSnAOCuv1ahzmgXZYkitFZFF9fqzE/f3GA== Date: Tue, 10 Jan 2023 09:06:50 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230110090650.2138edf0@bootlin.com> In-Reply-To: <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-6-herve.codina@bootlin.com> <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_000701_360720_97A24B93 X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKT24gU3VuLCA4IEphbiAyMDIzIDE2OjE0OjQ3ICswMTAwCktyenlzenRv ZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4gd3JvdGU6CgpbLi4u XQo+ID4gKwo+ID4gKyAgaW50ZXJydXB0czoKPiA+ICsgICAgZGVzY3JpcHRpb246IFNDQyBpbnRl cnJ1cHQgbGluZSBpbiB0aGUgQ1BNIGludGVycnVwdCBjb250cm9sbGVyICAKPiAKPiBNaXNzaW5n IGNvbnN0cmFpbnRzLgoKJ21heEl0ZW1zOiAxJyB3aWxsIGJlIGFkZGVkIGluIHYzCgo+IAo+ID4g Kwo+ID4gKyAgZnNsLGNwbS1jb21tYW5kOgo+ID4gKyAgICAkcmVmOiAvc2NoZW1hcy90eXBlcy55 YW1sIy9kZWZpbml0aW9ucy91aW50MzIKPiA+ICsgICAgZGVzY3JpcHRpb246IENmLiBzb2MvZnNs L2NwbV9xZS9jcG0udHh0ICAKPiAKPiBNaXNzaW5nIGRlc2NyaXB0aW9uLgoKJ2ZzbCxjcG0tY29t bWFuZCcgd2lsbCBiZSByZW1vdmVkIGluIHYzLgpUaGUgdmFsdWUgbmVlZGVkIGlzIGRldGVybWlu ZWQgYmFzZWQgb24gb3RoZXIgaW5mb3JtYXRpb24uClRoaXMgaXMgbm90IG5lZWRlZCBpbiB0aGUg RFQuCgo+IAo+ID4gKwo+ID4gKyAgdHNhOgo+ID4gKyAgICAkcmVmOiAvc2NoZW1hcy90eXBlcy55 YW1sIy9kZWZpbml0aW9ucy9waGFuZGxlCj4gPiArICAgIGRlc2NyaXB0aW9uOiBwaGFuZGxlIHRv IHRoZSBUU0EgIAo+IAo+IE1pc3NpbmcgdmVuZG9yIHByZWZpeC4gRG9lcyBub3QgbG9vayBsaWtl IGEgZ2VuZXJpYyBwcm9wZXJ0eS4KCldpbGwgYmUgYmUgY2hhbmdlZCB0byAnZnNsLHRzYScKYW5k IGFsc28gJ3RzYS1jZWxsLWlkJyB3aWxsIGJlIGNoYW5nZWQgdG8gJ2ZzbCx0c2EtY2VsbC1pZCcK Cj4gClsuLi5dCj4gPiArCj4gPiArcGF0dGVyblByb3BlcnRpZXM6Cj4gPiArICAiXmNoYW5uZWxA KFswLTldfFsxLTVdWzAtOV18NlswLTNdKSQiOgo+ID4gKyAgICBkZXNjcmlwdGlvbjoKPiA+ICsg ICAgICBBIGNoYW5uZWwgbWFuYWdlZCBieSB0aGlzIGNvbnRyb2xsZXIKPiA+ICsgICAgdHlwZTog b2JqZWN0Cj4gPiArCj4gPiArICAgIHByb3BlcnRpZXM6Cj4gPiArICAgICAgcmVnOgo+ID4gKyAg ICAgICAgbWluaW11bTogMAo+ID4gKyAgICAgICAgbWF4aW11bTogNjMKPiA+ICsgICAgICAgIGRl c2NyaXB0aW9uOgo+ID4gKyAgICAgICAgICBUaGUgY2hhbm5lbCBudW1iZXIKPiA+ICsKPiA+ICsg ICAgICBmc2wsbW9kZToKPiA+ICsgICAgICAgICRyZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2Rl ZmluaXRpb25zL3N0cmluZwo+ID4gKyAgICAgICAgZW51bTogW3RyYW5zcGFyZW50LCBoZGxjXQo+ ID4gKyAgICAgICAgZGVmYXVsdDogdHJhbnNwYXJlbnQKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9u OiBPcGVyYXRpb25hbCBtb2RlICAKPiAKPiBBbmQgd2hhdCBkbyB0aGV5IG1lYW4/CgpJIHdpbGwg Y2hhbmdlIHdpdGgKICBkZXNjcmlwdGlvbjogfAogICAgVGhlIGNoYW5uZWwgb3BlcmF0aW9uYWwg bW9kZQogICAgIC0gaGRsYzogVGhlIGNoYW5uZWwgaGFuZGxlcyBIRExDIGZyYW1lcwogICAgIC0g dHJhbnNwYXJlbnQ6IFRoZSBjaGFubmVsIGhhbmRsZXMgcmF3IGRhdGEgd2l0aG91dCBhbnkgcHJv Y2Vzc2luZwoKPiAKPiA+ICsKPiA+ICsgICAgICBmc2wscmV2ZXJzZS1kYXRhOgo+ID4gKyAgICAg ICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvZmxhZwo+ID4gKyAgICAg ICAgZGVzY3JpcHRpb246Cj4gPiArICAgICAgICAgIFRoZSBiaXQgb3JkZXIgYXMgc2VlbiBvbiB0 aGUgY2hhbm5lbHMgaXMgcmV2ZXJzZWQsCj4gPiArICAgICAgICAgIHRyYW5zbWl0dGluZy9yZWNl aXZpbmcgdGhlIE1TQiBvZiBlYWNoIG9jdGV0IGZpcnN0Lgo+ID4gKyAgICAgICAgICBUaGlzIGZs YWcgaXMgdXNlZCBvbmx5IGluICd0cmFuc3BhcmVudCcgbW9kZS4KPiA+ICsKPiA+ICsgICAgICB0 eC10cy1tYXNrOiAgCj4gCj4gTWlzc2luZyB2ZW5kb3IgcHJlZml4LgoKV2lsbCBiZSBhZGRlZCwg YWxzbyBvbiByeC10cy1tYXNrLgoKPiAKPiA+ICsgICAgICAgICRyZWY6IC9zY2hlbWFzL3R5cGVz LnlhbWwjL2RlZmluaXRpb25zL3VpbnQ2NAo+ID4gKyAgICAgICAgZGVzY3JpcHRpb246Cj4gPiAr ICAgICAgICAgIENoYW5uZWwgYXNzaWduZWQgVHggdGltZS1zbG90cyB3aXRoaW4gdGhlIFR4IHRp bWUtc2xvdHMgcm91dGVkCj4gPiArICAgICAgICAgIGJ5IHRoZSBUU0EgdG8gdGhpcyBjZWxsLgo+ ID4gKwo+ID4gKyAgICAgIHJ4LXRzLW1hc2s6Cj4gPiArICAgICAgICAkcmVmOiAvc2NoZW1hcy90 eXBlcy55YW1sIy9kZWZpbml0aW9ucy91aW50NjQKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOgo+ ID4gKyAgICAgICAgICBDaGFubmVsIGFzc2lnbmVkIFJ4IHRpbWUtc2xvdHMgd2l0aGluIHRoZSBS eCB0aW1lLXNsb3RzIHJvdXRlZAo+ID4gKyAgICAgICAgICBieSB0aGUgVFNBIHRvIHRoaXMgY2Vs bC4KPiA+ICsKPiA+ICsgICAgcmVxdWlyZWQ6Cj4gPiArICAgICAgLSByZWcKPiA+ICsgICAgICAt IHR4LXRzLW1hc2sKPiA+ICsgICAgICAtIHJ4LXRzLW1hc2sKPiA+ICsKPiA+ICtyZXF1aXJlZDoK PiA+ICsgIC0gY29tcGF0aWJsZQo+ID4gKyAgLSByZWcKPiA+ICsgIC0gcmVnLW5hbWVzCj4gPiAr ICAtIGludGVycnVwdHMKPiA+ICsgIC0gdHNhCj4gPiArICAtIHRzYS1jZWxsLWlkCj4gPiArICAt ICcjYWRkcmVzcy1jZWxscycKPiA+ICsgIC0gJyNzaXplLWNlbGxzJwo+ID4gKyAgLSAnI2NoYW4t Y2VsbHMnCj4gPiArCj4gPiArYWRkaXRpb25hbFByb3BlcnRpZXM6IGZhbHNlCj4gPiArCj4gPiAr ZXhhbXBsZXM6Cj4gPiArICAtIHwKPiA+ICsgICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL3NvYy9m c2wtdHNhLmg+Cj4gPiArCj4gPiArICAgIHNjY19xbWNAYTYwIHsgIAo+IAo+IE5vIHVuZGVyc2Nv cmVzIGluIG5vZGUgbmFtZXMuCj4gCj4gTm9kZSBuYW1lcyBzaG91bGQgYmUgZ2VuZXJpYy4KPiBo dHRwczovL2RldmljZXRyZWUtc3BlY2lmaWNhdGlvbi5yZWFkdGhlZG9jcy5pby9lbi9sYXRlc3Qv Y2hhcHRlcjItZGV2aWNldHJlZS1iYXNpY3MuaHRtbCNnZW5lcmljLW5hbWVzLXJlY29tbWVuZGF0 aW9uCgpXaWxsIGJlIGNoYW5nZWQgdG8gcW1jQGE2MAoKPiAKPiA+ICsgICAgICAgIGNvbXBhdGli bGUgPSAiZnNsLG1wYzg4NS1zY2MtcW1jIiwgImZzbCxjcG0xLXNjYy1xbWMiOwo+ID4gKyAgICAg ICAgcmVnID0gPDB4YTYwIDB4MjA+LAo+ID4gKyAgICAgICAgICAgICAgPDB4M2YwMCAweGMwPiwK PiA+ICsgICAgICAgICAgICAgIDwweDIwMDAgMHgxMDAwPjsKPiA+ICsgICAgICAgIHJlZy1uYW1l cyA9ICJzY2NfcmVncyIsICJzY2NfcHJhbSIsICJkcHJhbSI7Cj4gPiArICAgICAgICBpbnRlcnJ1 cHRzID0gPDI3PjsKPiA+ICsgICAgICAgIGludGVycnVwdC1wYXJlbnQgPSA8JkNQTV9QSUM+Owo+ ID4gKyAgICAgICAgZnNsLGNwbS1jb21tYW5kID0gPDB4YzA+Owo+ID4gKwo+ID4gKyAgICAgICAg I2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPiArICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPiA+ ICsgICAgICAgICNjaGFuLWNlbGxzID0gPDE+Owo+ID4gKwo+ID4gKyAgICAgICAgdHNhID0gPCZ0 c2E+Owo+ID4gKyAgICAgICAgdHNhLWNlbGwtaWQgPSA8RlNMX0NQTV9UU0FfU0NDND47Cj4gPiAr Cj4gPiArICAgICAgICBjaGFubmVsQDE2IHsKPiA+ICsgICAgICAgICAgICAvKiBDaDE2IDogRmly c3QgNCBldmVuIFRTIGZyb20gYWxsIHJvdXRlZCBmcm9tIFRTQSAqLwo+ID4gKyAgICAgICAgICAg IHJlZyA9IDwxNj47Cj4gPiArICAgICAgICAgICAgZnNsLG1vZGUgPSAidHJhbnNwYXJlbnQiOwo+ ID4gKyAgICAgICAgICAgIGZzbCxyZXZlcnNlLWRhdGE7Cj4gPiArICAgICAgICAgICAgdHgtdHMt bWFzayA9IDwweDAwMDAwMDAwIDB4MDAwMDAwQUE+Owo+ID4gKyAgICAgICAgICAgIHJ4LXRzLW1h c2sgPSA8MHgwMDAwMDAwMCAweDAwMDAwMEFBPjsgIAo+IAo+IEtlZXAgY2FzZSBjb25zaXN0ZW50 LiBsb3dlci1jYXNlIGhleC4KCldpbGwgYmUgZml4ZWQKCj4gCj4gQmVzdCByZWdhcmRzLAo+IEty enlzenRvZgo+IAoKVGhhbmtzIGZvciB0aGUgcmV2aWV3LAoKQmVzdCByZWdhcmRzLApIZXJ2w6kK Ci0tIApIZXJ2w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5n aW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE2FC46467 for ; Tue, 10 Jan 2023 08:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbjAJIHP (ORCPT ); Tue, 10 Jan 2023 03:07:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235654AbjAJIG6 (ORCPT ); Tue, 10 Jan 2023 03:06:58 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CE6843E56; Tue, 10 Jan 2023 00:06:57 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3D5F824000B; Tue, 10 Jan 2023 08:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tanCnt41dmd3a1gqbCEA0TYYO9/oTjI6yAv4OQDOAo=; b=O1Opaji665s44TE1LAeK3X1D4fYZJDuZSpYGeI1q8gABik0Z1kaEh03swno0937SJj0yue 74GZCclMht4rcz4psoZvlBrAchwISnRoslZZufPnjF5IrvTUhHz2LldITerMDLfGFUgTms vHXaY1Ki1l23UicholMhpxt39CFMdnggwaNe0ljcsOiKVXKdvXP2KpthwiBLx9AG+xADXI wI6theO2IKhw2keeah0YYzKanAJEVpCPQbhCl2DFoZDmnrFIHdKhbfqupQ7yd24kqen1xf RUnZhIVGv4EnLnguFl4GNBxmLEakSSnAOCuv1ahzmgXZYkitFZFF9fqzE/f3GA== Date: Tue, 10 Jan 2023 09:06:50 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230110090650.2138edf0@bootlin.com> In-Reply-To: <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-6-herve.codina@bootlin.com> <76077f5f-fbda-800b-b8d8-6a3f6600f4d1@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Sun, 8 Jan 2023 16:14:47 +0100 Krzysztof Kozlowski wrote: [...] > > + > > + interrupts: > > + description: SCC interrupt line in the CPM interrupt controller =20 >=20 > Missing constraints. 'maxItems: 1' will be added in v3 >=20 > > + > > + fsl,cpm-command: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Cf. soc/fsl/cpm_qe/cpm.txt =20 >=20 > Missing description. 'fsl,cpm-command' will be removed in v3. The value needed is determined based on other information. This is not needed in the DT. >=20 > > + > > + tsa: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the TSA =20 >=20 > Missing vendor prefix. Does not look like a generic property. Will be be changed to 'fsl,tsa' and also 'tsa-cell-id' will be changed to 'fsl,tsa-cell-id' >=20 [...] > > + > > +patternProperties: > > + "^channel@([0-9]|[1-5][0-9]|6[0-3])$": > > + description: > > + A channel managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The channel number > > + > > + fsl,mode: > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [transparent, hdlc] > > + default: transparent > > + description: Operational mode =20 >=20 > And what do they mean? I will change with description: | The channel operational mode - hdlc: The channel handles HDLC frames - transparent: The channel handles raw data without any processing >=20 > > + > > + fsl,reverse-data: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The bit order as seen on the channels is reversed, > > + transmitting/receiving the MSB of each octet first. > > + This flag is used only in 'transparent' mode. > > + > > + tx-ts-mask: =20 >=20 > Missing vendor prefix. Will be added, also on rx-ts-mask. >=20 > > + $ref: /schemas/types.yaml#/definitions/uint64 > > + description: > > + Channel assigned Tx time-slots within the Tx time-slots rout= ed > > + by the TSA to this cell. > > + > > + rx-ts-mask: > > + $ref: /schemas/types.yaml#/definitions/uint64 > > + description: > > + Channel assigned Rx time-slots within the Rx time-slots rout= ed > > + by the TSA to this cell. > > + > > + required: > > + - reg > > + - tx-ts-mask > > + - rx-ts-mask > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - interrupts > > + - tsa > > + - tsa-cell-id > > + - '#address-cells' > > + - '#size-cells' > > + - '#chan-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + scc_qmc@a60 { =20 >=20 > No underscores in node names. >=20 > Node names should be generic. > https://devicetree-specification.readthedocs.io/en/latest/chapter2-device= tree-basics.html#generic-names-recommendation Will be changed to qmc@a60 >=20 > > + compatible =3D "fsl,mpc885-scc-qmc", "fsl,cpm1-scc-qmc"; > > + reg =3D <0xa60 0x20>, > > + <0x3f00 0xc0>, > > + <0x2000 0x1000>; > > + reg-names =3D "scc_regs", "scc_pram", "dpram"; > > + interrupts =3D <27>; > > + interrupt-parent =3D <&CPM_PIC>; > > + fsl,cpm-command =3D <0xc0>; > > + > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + #chan-cells =3D <1>; > > + > > + tsa =3D <&tsa>; > > + tsa-cell-id =3D ; > > + > > + channel@16 { > > + /* Ch16 : First 4 even TS from all routed from TSA */ > > + reg =3D <16>; > > + fsl,mode =3D "transparent"; > > + fsl,reverse-data; > > + tx-ts-mask =3D <0x00000000 0x000000AA>; > > + rx-ts-mask =3D <0x00000000 0x000000AA>; =20 >=20 > Keep case consistent. lower-case hex. Will be fixed >=20 > Best regards, > Krzysztof >=20 Thanks for the review, Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com