From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E265C46467 for ; Tue, 10 Jan 2023 08:08:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10A9CDB87; Tue, 10 Jan 2023 09:07:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10A9CDB87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673338116; bh=h4ANQNaGsH08Jgn0Mm4rergXT4JVzFRkOUTF86L6lIk=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=A3mSVCaHgEnZ9QtQWh61XJr9UqdIgadWiycOifbhbqRSsorSM+Z/28YIoRZhifeKi IEeLv1ZY1CiMvD7bbMFQ2Rx0RhgLa3+jjVY4VxEE1E1ed8Yz0N0/zlNKfz7ZMfJfLU U7sUNriTzyfuA+FCGGAa7W+uT9lmYUjhBQcoDyLE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B63BBF804D9; Tue, 10 Jan 2023 09:07:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 98399F804DC; Tue, 10 Jan 2023 09:07:44 +0100 (CET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 457A2F8026A for ; Tue, 10 Jan 2023 09:07:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 457A2F8026A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Ys6OT1+2 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E6D8C100002; Tue, 10 Jan 2023 08:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZgsA3blZRkDhqGMnNA0R6u5EyqOGZtYvAT+Wv5NomZg=; b=Ys6OT1+2bp2JYHo9mPYmhymzvJZTYOD3fMVHRIhU3ImPlylTaTP7MZa3uFgOrz/CvgzjQ/ 1770lhQoUVCHCn6xm1iLySNLgGab8ZMbMBPrT0Tf7XEAWvlCyjIs7qirDks6ATZh0a9YW+ SnMEN1s7lQrmNRTdKOhgPXLHBVDJRmy/u5Ckqs0h+snkD02n7c/E/4kW86C7QvebMmpVRJ flMpdVvpFa9DDU074ocMpMNQ8oL1KzCJCLr9FgSCoSe0oflZ0zwZ7U+NvwaPZnxhccaYnd my4L007gwd/5XXRVFJlvE483mkgyDZofuuUDwZGPggBYVPuPUXQ7PzpEhXpK8w== Date: Tue, 10 Jan 2023 09:07:28 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v2 08/10] dt-bindings: sound: Add support for QMC audio Message-ID: <20230110090728.2024b5eb@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-9-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Christophe Leroy , Krzysztof Kozlowski , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Krzysztof, On Sun, 8 Jan 2023 16:16:24 +0100 Krzysztof Kozlowski wrote: > On 06/01/2023 17:37, Herve Codina wrote: > > The QMC (QUICC mutichannel controller) is a controller > > present in some PowerQUICC SoC such as MPC885. > > The QMC audio is an ASoC component that uses the QMC > > controller to transfer the audio data. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/sound/fsl,qmc-audio.yaml | 110 ++++++++++++++++++ > > 1 file changed, 110 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,qmc-aud= io.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml= b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > > new file mode 100644 > > index 000000000000..b3774be36c19 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > > @@ -0,0 +1,110 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/fsl,qmc-audio.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: QMC audio > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > + The QMC audio is an ASoC component which uses QMC (QUICC Multichannel > > + Controller) channels to transfer the audio data. > > + It provides as many DAI as the number of QMC channel used. > > + > > +properties: > > + compatible: > > + items: =20 >=20 > Drop items. Will be dropped. >=20 > > + - const: fsl,qmc-audio > > + > > + '#address-cells': > > + const: 1 > > + '#size-cells': > > + const: 0 > > + '#sound-dai-cells': > > + const: 1 > > + > > +patternProperties: > > + "^dai@([0-9]|[1-5][0-9]|6[0-3])$": > > + description: > > + A DAI managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The DAI number > > + > > + qmc-chan: =20 >=20 > Missing vendor prefix. Will be changed to 'fsl,qmc-chan' >=20 > > + $ref: /schemas/types.yaml#/definitions/phandle-array =20 >=20 > Why this is not a phandle? I have try '$ref: /schemas/types.yaml#/definitions/phandle' I have an error from make dt_binding_check:=20 dai@16:fsl,qmc-chan:0: [4294967295, 16] is too long I need a phandle with an argument ie <&qmc 16>. Is there an alternative to phandle-array to handle this case ? >=20 > > + description: phandle to the QMC channel> + maxItems: 1 > > + > > + required: > > + - reg > > + - qmc-chan > > + > > +required: > > + - compatible > > + - '#address-cells' > > + - '#size-cells' > > + - '#sound-dai-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + qmc_audio: qmc_audio { =20 >=20 > Same problem as in previous patch. Changed to 'audio-controller'. >=20 > > + compatible =3D "fsl,qmc-audio"; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + #sound-dai-cells =3D <1>; > > + dai@16 { > > + reg =3D <16>; > > + qmc-chan =3D <&scc_qmc 16>; > > + }; > > + dai@17 { > > + reg =3D <17>; > > + qmc-chan =3D <&scc_qmc 17>; > > + }; > > + }; =20 >=20 > Best regards, > Krzysztof >=20 Thanks for the review. Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B088C46467 for ; Tue, 10 Jan 2023 08:09:42 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Nrk4P11wsz3fCw for ; Tue, 10 Jan 2023 19:09:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Ys6OT1+2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::231; helo=relay11.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Ys6OT1+2; dkim-atps=neutral Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Nrk292Hdqz3cdD for ; Tue, 10 Jan 2023 19:07:44 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E6D8C100002; Tue, 10 Jan 2023 08:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZgsA3blZRkDhqGMnNA0R6u5EyqOGZtYvAT+Wv5NomZg=; b=Ys6OT1+2bp2JYHo9mPYmhymzvJZTYOD3fMVHRIhU3ImPlylTaTP7MZa3uFgOrz/CvgzjQ/ 1770lhQoUVCHCn6xm1iLySNLgGab8ZMbMBPrT0Tf7XEAWvlCyjIs7qirDks6ATZh0a9YW+ SnMEN1s7lQrmNRTdKOhgPXLHBVDJRmy/u5Ckqs0h+snkD02n7c/E/4kW86C7QvebMmpVRJ flMpdVvpFa9DDU074ocMpMNQ8oL1KzCJCLr9FgSCoSe0oflZ0zwZ7U+NvwaPZnxhccaYnd my4L007gwd/5XXRVFJlvE483mkgyDZofuuUDwZGPggBYVPuPUXQ7PzpEhXpK8w== Date: Tue, 10 Jan 2023 09:07:28 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v2 08/10] dt-bindings: sound: Add support for QMC audio Message-ID: <20230110090728.2024b5eb@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-9-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Krzysztof, On Sun, 8 Jan 2023 16:16:24 +0100 Krzysztof Kozlowski wrote: > On 06/01/2023 17:37, Herve Codina wrote: > > The QMC (QUICC mutichannel controller) is a controller > > present in some PowerQUICC SoC such as MPC885. > > The QMC audio is an ASoC component that uses the QMC > > controller to transfer the audio data. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/sound/fsl,qmc-audio.yaml | 110 ++++++++++++++++++ > > 1 file changed, 110 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,qmc-aud= io.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml= b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > > new file mode 100644 > > index 000000000000..b3774be36c19 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > > @@ -0,0 +1,110 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/fsl,qmc-audio.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: QMC audio > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > + The QMC audio is an ASoC component which uses QMC (QUICC Multichannel > > + Controller) channels to transfer the audio data. > > + It provides as many DAI as the number of QMC channel used. > > + > > +properties: > > + compatible: > > + items: =20 >=20 > Drop items. Will be dropped. >=20 > > + - const: fsl,qmc-audio > > + > > + '#address-cells': > > + const: 1 > > + '#size-cells': > > + const: 0 > > + '#sound-dai-cells': > > + const: 1 > > + > > +patternProperties: > > + "^dai@([0-9]|[1-5][0-9]|6[0-3])$": > > + description: > > + A DAI managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The DAI number > > + > > + qmc-chan: =20 >=20 > Missing vendor prefix. Will be changed to 'fsl,qmc-chan' >=20 > > + $ref: /schemas/types.yaml#/definitions/phandle-array =20 >=20 > Why this is not a phandle? I have try '$ref: /schemas/types.yaml#/definitions/phandle' I have an error from make dt_binding_check:=20 dai@16:fsl,qmc-chan:0: [4294967295, 16] is too long I need a phandle with an argument ie <&qmc 16>. Is there an alternative to phandle-array to handle this case ? >=20 > > + description: phandle to the QMC channel> + maxItems: 1 > > + > > + required: > > + - reg > > + - qmc-chan > > + > > +required: > > + - compatible > > + - '#address-cells' > > + - '#size-cells' > > + - '#sound-dai-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + qmc_audio: qmc_audio { =20 >=20 > Same problem as in previous patch. Changed to 'audio-controller'. >=20 > > + compatible =3D "fsl,qmc-audio"; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + #sound-dai-cells =3D <1>; > > + dai@16 { > > + reg =3D <16>; > > + qmc-chan =3D <&scc_qmc 16>; > > + }; > > + dai@17 { > > + reg =3D <17>; > > + qmc-chan =3D <&scc_qmc 17>; > > + }; > > + }; =20 >=20 > Best regards, > Krzysztof >=20 Thanks for the review. Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C348C46467 for ; Tue, 10 Jan 2023 08:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wsn11d4wAsgr4sSAdta6fWVlm1bjlFOwPLf7w2eXIIk=; b=jD6U3YQ4d49We6 RUTrYOnUUPZ5UUrQqkM8VSXqKcsmzygsNcw4ewrFtt6dpaALggReqgap+d3PnRqCG/9tL6mXm/K40 perlWluO1PmszMGmNm3MXOjycDMBebQ0VrjUae9KSmVMz0VCoAnUPhrobVy8yuamC520Aqw4CAxNx g9pjt+LEe/w8Gv1h0DSq8+AsaE5GMYS6B+ej20nTdWukqPnFszR+UZJUccNGXx8n4Nc0MkewZ5iR3 pKogIJ6yrVawZPnByMrCJDtWpVJw/4ShbKqYLzv0dHQnCOFUKVfLIT8HDkNmn6oCbdvsvhRLiHKu6 ljd4wrqwZNOhZigSW4Ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF9fd-005iIa-R2; Tue, 10 Jan 2023 08:07:45 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF9fZ-005iEr-5g for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 08:07:43 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E6D8C100002; Tue, 10 Jan 2023 08:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZgsA3blZRkDhqGMnNA0R6u5EyqOGZtYvAT+Wv5NomZg=; b=Ys6OT1+2bp2JYHo9mPYmhymzvJZTYOD3fMVHRIhU3ImPlylTaTP7MZa3uFgOrz/CvgzjQ/ 1770lhQoUVCHCn6xm1iLySNLgGab8ZMbMBPrT0Tf7XEAWvlCyjIs7qirDks6ATZh0a9YW+ SnMEN1s7lQrmNRTdKOhgPXLHBVDJRmy/u5Ckqs0h+snkD02n7c/E/4kW86C7QvebMmpVRJ flMpdVvpFa9DDU074ocMpMNQ8oL1KzCJCLr9FgSCoSe0oflZ0zwZ7U+NvwaPZnxhccaYnd my4L007gwd/5XXRVFJlvE483mkgyDZofuuUDwZGPggBYVPuPUXQ7PzpEhXpK8w== Date: Tue, 10 Jan 2023 09:07:28 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 08/10] dt-bindings: sound: Add support for QMC audio Message-ID: <20230110090728.2024b5eb@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-9-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_000741_555415_1C0AD797 X-CRM114-Status: GOOD ( 25.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKT24gU3VuLCA4IEphbiAyMDIzIDE2OjE2OjI0ICswMTAwCktyenlzenRv ZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4gd3JvdGU6Cgo+IE9u IDA2LzAxLzIwMjMgMTc6MzcsIEhlcnZlIENvZGluYSB3cm90ZToKPiA+IFRoZSBRTUMgKFFVSUND IG11dGljaGFubmVsIGNvbnRyb2xsZXIpIGlzIGEgY29udHJvbGxlcgo+ID4gcHJlc2VudCBpbiBz b21lIFBvd2VyUVVJQ0MgU29DIHN1Y2ggYXMgTVBDODg1Lgo+ID4gVGhlIFFNQyBhdWRpbyBpcyBh biBBU29DIGNvbXBvbmVudCB0aGF0IHVzZXMgdGhlIFFNQwo+ID4gY29udHJvbGxlciB0byB0cmFu c2ZlciB0aGUgYXVkaW8gZGF0YS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogSGVydmUgQ29kaW5h IDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+Cj4gPiAtLS0KPiA+ICAuLi4vYmluZGluZ3Mvc291 bmQvZnNsLHFtYy1hdWRpby55YW1sICAgICAgICAgfCAxMTAgKysrKysrKysrKysrKysrKysrCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDExMCBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRlIG1vZGUgMTAw NjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC9mc2wscW1jLWF1ZGlv LnlhbWwKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9zb3VuZC9mc2wscW1jLWF1ZGlvLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3Mvc291bmQvZnNsLHFtYy1hdWRpby55YW1sCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi5iMzc3NGJlMzZjMTkKPiA+IC0tLSAvZGV2L251bGwK PiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC9mc2wscW1j LWF1ZGlvLnlhbWwKPiA+IEBAIC0wLDAgKzEsMTEwIEBACj4gPiArIyBTUERYLUxpY2Vuc2UtSWRl bnRpZmllcjogKEdQTC0yLjAtb25seSBPUiBCU0QtMi1DbGF1c2UpCj4gPiArJVlBTUwgMS4yCj4g PiArLS0tCj4gPiArJGlkOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9zb3VuZC9mc2ws cW1jLWF1ZGlvLnlhbWwjCj4gPiArJHNjaGVtYTogaHR0cDovL2RldmljZXRyZWUub3JnL21ldGEt c2NoZW1hcy9jb3JlLnlhbWwjCj4gPiArCj4gPiArdGl0bGU6IFFNQyBhdWRpbwo+ID4gKwo+ID4g K21haW50YWluZXJzOgo+ID4gKyAgLSBIZXJ2ZSBDb2RpbmEgPGhlcnZlLmNvZGluYUBib290bGlu LmNvbT4KPiA+ICsKPiA+ICtkZXNjcmlwdGlvbjogfAo+ID4gKyAgVGhlIFFNQyBhdWRpbyBpcyBh biBBU29DIGNvbXBvbmVudCB3aGljaCB1c2VzIFFNQyAoUVVJQ0MgTXVsdGljaGFubmVsCj4gPiAr ICBDb250cm9sbGVyKSBjaGFubmVscyB0byB0cmFuc2ZlciB0aGUgYXVkaW8gZGF0YS4KPiA+ICsg IEl0IHByb3ZpZGVzIGFzIG1hbnkgREFJIGFzIHRoZSBudW1iZXIgb2YgUU1DIGNoYW5uZWwgdXNl ZC4KPiA+ICsKPiA+ICtwcm9wZXJ0aWVzOgo+ID4gKyAgY29tcGF0aWJsZToKPiA+ICsgICAgaXRl bXM6ICAKPiAKPiBEcm9wIGl0ZW1zLgoKV2lsbCBiZSBkcm9wcGVkLgoKPiAKPiA+ICsgICAgICAt IGNvbnN0OiBmc2wscW1jLWF1ZGlvCj4gPiArCj4gPiArICAnI2FkZHJlc3MtY2VsbHMnOgo+ID4g KyAgICBjb25zdDogMQo+ID4gKyAgJyNzaXplLWNlbGxzJzoKPiA+ICsgICAgY29uc3Q6IDAKPiA+ ICsgICcjc291bmQtZGFpLWNlbGxzJzoKPiA+ICsgICAgY29uc3Q6IDEKPiA+ICsKPiA+ICtwYXR0 ZXJuUHJvcGVydGllczoKPiA+ICsgICJeZGFpQChbMC05XXxbMS01XVswLTldfDZbMC0zXSkkIjoK PiA+ICsgICAgZGVzY3JpcHRpb246Cj4gPiArICAgICAgQSBEQUkgbWFuYWdlZCBieSB0aGlzIGNv bnRyb2xsZXIKPiA+ICsgICAgdHlwZTogb2JqZWN0Cj4gPiArCj4gPiArICAgIHByb3BlcnRpZXM6 Cj4gPiArICAgICAgcmVnOgo+ID4gKyAgICAgICAgbWluaW11bTogMAo+ID4gKyAgICAgICAgbWF4 aW11bTogNjMKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOgo+ID4gKyAgICAgICAgICBUaGUgREFJ IG51bWJlcgo+ID4gKwo+ID4gKyAgICAgIHFtYy1jaGFuOiAgCj4gCj4gTWlzc2luZyB2ZW5kb3Ig cHJlZml4LgoKV2lsbCBiZSBjaGFuZ2VkIHRvICdmc2wscW1jLWNoYW4nCgo+IAo+ID4gKyAgICAg ICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvcGhhbmRsZS1hcnJheSAg Cj4gCj4gV2h5IHRoaXMgaXMgbm90IGEgcGhhbmRsZT8KCkkgaGF2ZSB0cnkgJyRyZWY6IC9zY2hl bWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUnCgpJIGhhdmUgYW4gZXJyb3IgZnJv bSBtYWtlIGR0X2JpbmRpbmdfY2hlY2s6IAogIGRhaUAxNjpmc2wscW1jLWNoYW46MDogWzQyOTQ5 NjcyOTUsIDE2XSBpcyB0b28gbG9uZwoKSSBuZWVkIGEgcGhhbmRsZSB3aXRoIGFuIGFyZ3VtZW50 IGllIDwmcW1jIDE2Pi4KSXMgdGhlcmUgYW4gYWx0ZXJuYXRpdmUgdG8gcGhhbmRsZS1hcnJheSB0 byBoYW5kbGUgdGhpcyBjYXNlID8KCj4gCj4gPiArICAgICAgICBkZXNjcmlwdGlvbjogcGhhbmRs ZSB0byB0aGUgUU1DIGNoYW5uZWw+ICsgICAgICAgIG1heEl0ZW1zOiAxCj4gPiArCj4gPiArICAg IHJlcXVpcmVkOgo+ID4gKyAgICAgIC0gcmVnCj4gPiArICAgICAgLSBxbWMtY2hhbgo+ID4gKwo+ ID4gK3JlcXVpcmVkOgo+ID4gKyAgLSBjb21wYXRpYmxlCj4gPiArICAtICcjYWRkcmVzcy1jZWxs cycKPiA+ICsgIC0gJyNzaXplLWNlbGxzJwo+ID4gKyAgLSAnI3NvdW5kLWRhaS1jZWxscycKPiA+ ICsKPiA+ICthZGRpdGlvbmFsUHJvcGVydGllczogZmFsc2UKPiA+ICsKPiA+ICtleGFtcGxlczoK PiA+ICsgIC0gfAo+ID4gKyAgICBxbWNfYXVkaW86IHFtY19hdWRpbyB7ICAKPiAKPiBTYW1lIHBy b2JsZW0gYXMgaW4gcHJldmlvdXMgcGF0Y2guCgpDaGFuZ2VkIHRvICdhdWRpby1jb250cm9sbGVy Jy4KCj4gCj4gPiArICAgICAgICBjb21wYXRpYmxlID0gImZzbCxxbWMtYXVkaW8iOwo+ID4gKyAg ICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPiArICAgICAgICAjc2l6ZS1jZWxscyA9IDww PjsKPiA+ICsgICAgICAgICNzb3VuZC1kYWktY2VsbHMgPSA8MT47Cj4gPiArICAgICAgICBkYWlA MTYgewo+ID4gKyAgICAgICAgICAgIHJlZyA9IDwxNj47Cj4gPiArICAgICAgICAgICAgcW1jLWNo YW4gPSA8JnNjY19xbWMgMTY+Owo+ID4gKyAgICAgICAgfTsKPiA+ICsgICAgICAgIGRhaUAxNyB7 Cj4gPiArICAgICAgICAgICAgcmVnID0gPDE3PjsKPiA+ICsgICAgICAgICAgICBxbWMtY2hhbiA9 IDwmc2NjX3FtYyAxNz47Cj4gPiArICAgICAgICB9Owo+ID4gKyAgICB9OyAgCj4gCj4gQmVzdCBy ZWdhcmRzLAo+IEtyenlzenRvZgo+IAoKVGhhbmtzIGZvciB0aGUgcmV2aWV3LgoKQmVzdCByZWdh cmRzLApIZXJ2w6kKCi0tIApIZXJ2w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFu ZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E805C678D5 for ; Tue, 10 Jan 2023 08:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbjAJIIK (ORCPT ); Tue, 10 Jan 2023 03:08:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbjAJIHj (ORCPT ); Tue, 10 Jan 2023 03:07:39 -0500 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 017E3140B6; Tue, 10 Jan 2023 00:07:37 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E6D8C100002; Tue, 10 Jan 2023 08:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673338056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZgsA3blZRkDhqGMnNA0R6u5EyqOGZtYvAT+Wv5NomZg=; b=Ys6OT1+2bp2JYHo9mPYmhymzvJZTYOD3fMVHRIhU3ImPlylTaTP7MZa3uFgOrz/CvgzjQ/ 1770lhQoUVCHCn6xm1iLySNLgGab8ZMbMBPrT0Tf7XEAWvlCyjIs7qirDks6ATZh0a9YW+ SnMEN1s7lQrmNRTdKOhgPXLHBVDJRmy/u5Ckqs0h+snkD02n7c/E/4kW86C7QvebMmpVRJ flMpdVvpFa9DDU074ocMpMNQ8oL1KzCJCLr9FgSCoSe0oflZ0zwZ7U+NvwaPZnxhccaYnd my4L007gwd/5XXRVFJlvE483mkgyDZofuuUDwZGPggBYVPuPUXQ7PzpEhXpK8w== Date: Tue, 10 Jan 2023 09:07:28 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 08/10] dt-bindings: sound: Add support for QMC audio Message-ID: <20230110090728.2024b5eb@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-9-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Sun, 8 Jan 2023 16:16:24 +0100 Krzysztof Kozlowski wrote: > On 06/01/2023 17:37, Herve Codina wrote: > > The QMC (QUICC mutichannel controller) is a controller > > present in some PowerQUICC SoC such as MPC885. > > The QMC audio is an ASoC component that uses the QMC > > controller to transfer the audio data. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/sound/fsl,qmc-audio.yaml | 110 ++++++++++++++++++ > > 1 file changed, 110 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,qmc-aud= io.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml= b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > > new file mode 100644 > > index 000000000000..b3774be36c19 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > > @@ -0,0 +1,110 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/fsl,qmc-audio.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: QMC audio > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > + The QMC audio is an ASoC component which uses QMC (QUICC Multichannel > > + Controller) channels to transfer the audio data. > > + It provides as many DAI as the number of QMC channel used. > > + > > +properties: > > + compatible: > > + items: =20 >=20 > Drop items. Will be dropped. >=20 > > + - const: fsl,qmc-audio > > + > > + '#address-cells': > > + const: 1 > > + '#size-cells': > > + const: 0 > > + '#sound-dai-cells': > > + const: 1 > > + > > +patternProperties: > > + "^dai@([0-9]|[1-5][0-9]|6[0-3])$": > > + description: > > + A DAI managed by this controller > > + type: object > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 63 > > + description: > > + The DAI number > > + > > + qmc-chan: =20 >=20 > Missing vendor prefix. Will be changed to 'fsl,qmc-chan' >=20 > > + $ref: /schemas/types.yaml#/definitions/phandle-array =20 >=20 > Why this is not a phandle? I have try '$ref: /schemas/types.yaml#/definitions/phandle' I have an error from make dt_binding_check:=20 dai@16:fsl,qmc-chan:0: [4294967295, 16] is too long I need a phandle with an argument ie <&qmc 16>. Is there an alternative to phandle-array to handle this case ? >=20 > > + description: phandle to the QMC channel> + maxItems: 1 > > + > > + required: > > + - reg > > + - qmc-chan > > + > > +required: > > + - compatible > > + - '#address-cells' > > + - '#size-cells' > > + - '#sound-dai-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + qmc_audio: qmc_audio { =20 >=20 > Same problem as in previous patch. Changed to 'audio-controller'. >=20 > > + compatible =3D "fsl,qmc-audio"; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + #sound-dai-cells =3D <1>; > > + dai@16 { > > + reg =3D <16>; > > + qmc-chan =3D <&scc_qmc 16>; > > + }; > > + dai@17 { > > + reg =3D <17>; > > + qmc-chan =3D <&scc_qmc 17>; > > + }; > > + }; =20 >=20 > Best regards, > Krzysztof >=20 Thanks for the review. Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com