From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Robbie Harwood <rharwood@redhat.com>,
Peter Jones <pjones@redhat.com>,
Glenn Washburn <development@efficientek.com>
Subject: [PATCH v6 06/14] gdb: Only connect to remote target once when first sourced
Date: Tue, 10 Jan 2023 15:50:33 -0600 [thread overview]
Message-ID: <20230110215041.1247699-7-development@efficientek.com> (raw)
In-Reply-To: <20230110215041.1247699-1-development@efficientek.com>
The gdb_grub script was originally meant to be run once when GDB first
starts up via the -x argument. So it runs commands unconditionally
assuming that the script has not been run before. Its nice to be able
to source the script again when developing the script to modify/add
commands. So only run the commands not defined in user-defined commands,
if a variable $runonce has already been set and when those commands have
been run to set $runonce.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
grub-core/gdb_grub.in | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
index 620d1def72..4ca939f69a 100644
--- a/grub-core/gdb_grub.in
+++ b/grub-core/gdb_grub.in
@@ -94,12 +94,15 @@ set confirm off
set $platform_efi = $_streq("@platform@", "efi")
-if $platform_efi
- # Only load the executable file, not the symbols
- exec-file kernel.exec
-else
- file kernel.exec
- runtime_load_module
-end
+if ! $runonce
+ if $platform_efi
+ # Only load the executable file, not the symbols
+ exec-file kernel.exec
+ else
+ file kernel.exec
+ runtime_load_module
+ end
-target remote :1234
+ target remote :1234
+ set $runonce = 1
+end
--
2.34.1
next prev parent reply other threads:[~2023-01-10 21:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 21:50 [PATCH v6 00/14] GDB script fixes and improvements Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 01/14] gdb: Fix redirection issue in dump_module_sections Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 02/14] gdb: Prevent wrapping when writing to .segments.tmp Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 03/14] gdb: If no modules have been loaded, do not try to load module symbols Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 04/14] gdb: Move runtime module loading into runtime_load_module Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 05/14] gdb: Conditionally run GDB script logic for dynamically or statically positioned GRUB Glenn Washburn
2023-01-10 21:50 ` Glenn Washburn [this message]
2023-01-10 21:50 ` [PATCH v6 07/14] gdb: Replace module symbol loading implementation with Python one Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 08/14] gdb: Add functions to make loading from dynamically positioned targets easier Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 09/14] gdb: Add more support for debugging on EFI platforms Glenn Washburn
2023-02-20 20:06 ` Robbie Harwood
2023-02-21 3:07 ` Glenn Washburn
2023-03-02 18:44 ` Daniel Kiper
2023-01-10 21:50 ` [PATCH v6 10/14] gdb: Allow running user-defined commands at GRUB start Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 11/14] gdb: Fix issue with breakpoints defined before the GRUB image is loaded Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 12/14] gdb: Add extra early initialization symbols for i386-pc Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 13/14] gdb: Modify gdb prompt when running gdb_grub script Glenn Washburn
2023-01-10 21:50 ` [PATCH v6 14/14] docs: Add debugging chapter to development documentation Glenn Washburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110215041.1247699-7-development@efficientek.com \
--to=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=pjones@redhat.com \
--cc=rharwood@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.