All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Patrick Steinhardt <ps@pks.im>,
	Glenn Washburn <development@efficientek.com>
Subject: [PATCH 2/6] grub-shell: Only cleanup working directory file if QEMU does not fail or timeout
Date: Tue, 10 Jan 2023 16:08:56 -0600	[thread overview]
Message-ID: <20230110220900.1248367-3-development@efficientek.com> (raw)
In-Reply-To: <20230110220900.1248367-1-development@efficientek.com>

This keeps the generated files to aid in diagnosing the source of the
failure.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 tests/util/grub-shell.in | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
index 2c0e654c1f..e5d34d1d35 100644
--- a/tests/util/grub-shell.in
+++ b/tests/util/grub-shell.in
@@ -537,8 +537,6 @@ elif [ x$boot = xemu ]; then
     (cd "$rootdir"; tar cf "$roottar" .)
     setup_qemu_logger
     "${builddir}/grub-core/grub-emu" -m "$device_map" --memdisk "$roottar" -r memdisk -d "/boot/grub" > "$work_directory/qemu-pipe" || ret=$?
-    test -n "$debug" || rm -rf "$rootdir"
-    test -n "$debug" || rm -f "$roottar"
 else
     setup_qemu_logger
     timeout -s KILL $timeout "${qemu}" ${qemuopts} ${serial_null} -serial file:/dev/stdout -${device}"${isofile}" ${bootdev} > "$work_directory/qemu-pipe" || ret=$?
@@ -547,8 +545,16 @@ fi
 wait
 rm -f "$work_directory/qemu-pipe"
 
+if [ "$ret" -ne 0 ]; then
+    # If QEMU failure, keep generated files to reproduce
+    exit $ret
+fi
+
 if [ x$boot = xcoreboot ]; then
     test -n "$debug" || rm -f "${imgfile}"
+elif [ x$boot = xemu ]; then
+    test -n "$debug" || rm -rf "$rootdir"
+    test -n "$debug" || rm -f "$roottar"
 fi
 test -n "$debug" || rm -f "${isofile}"
 test -n "$debug" || rm -rf "${rom_directory}"
-- 
2.34.1



  parent reply	other threads:[~2023-01-10 22:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 22:08 [PATCH 0/6] Cryptomount testing Glenn Washburn
2023-01-10 22:08 ` [PATCH 1/6] grub-shell: Set exit status to qemu exit status Glenn Washburn
2023-01-10 22:08 ` Glenn Washburn [this message]
2023-01-10 22:08 ` [PATCH 3/6] grub-shell: Allow specifying non-default trim line contents Glenn Washburn
2023-01-10 22:08 ` [PATCH 4/6] grub-shell: Trim line should always be matched from the beginning of the line Glenn Washburn
2023-01-10 22:08 ` [PATCH 5/6] grub-shell: Add halt_cmd variable to testcase namespace Glenn Washburn
2023-01-10 22:09 ` [PATCH 6/6] tests: Add cryptomount functional test Glenn Washburn
2023-01-12 16:23 ` [PATCH 0/6] Cryptomount testing Daniel Kiper
2023-01-13  8:13   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230110220900.1248367-3-development@efficientek.com \
    --to=development@efficientek.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.