From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1D2BC5479D for ; Wed, 11 Jan 2023 15:07:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DDAE77938; Wed, 11 Jan 2023 16:07:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DDAE77938 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673449671; bh=96p48KGQVOszGpiIUB1uMQHTSrU1mw+PEt8uGhIXaOc=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=JuRJUP0dJcHLNekNa3v/uvuypcy0MOw9czHAO8hblHqhbMnby0NO9V5Dty/U+GROk B2/iZviKW4imsZ6ES6tDWC4+J/l4a7lr3hCF5BuWonnKrOLf785IFkE5OUMqg5MVnl qsZiDJIQjgbaADprCEkOL7JSjThn4MCNwRliNIwE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 882ACF8030F; Wed, 11 Jan 2023 16:07:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EAB7BF803DC; Wed, 11 Jan 2023 16:06:59 +0100 (CET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CF31DF8019B for ; Wed, 11 Jan 2023 16:06:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CF31DF8019B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=J2zebCAM Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7925C1C000B; Wed, 11 Jan 2023 15:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673449616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=96p48KGQVOszGpiIUB1uMQHTSrU1mw+PEt8uGhIXaOc=; b=J2zebCAM0gphMWejuOqgoceHr5MqD34OCvw5uIQ+F8xbwSyORqkjh5JN2WScz1Txu5rTA2 oWG0oqjsC4TfW2W6iI9azZabaMlxD4UwGsCtIMgaxUsBAVf+S4BhZxNsfF++6qyd88P51j jTN0lxAM9hMeQ2T1yXZ3dCMevMQX/c69W2vPSEc81hUm2hBKXfojWt/aKd1iw4OGl0mv14 6jyJY34VcHSqHG5PWqLJhCiaVS7KwdXzjRRNsRc7oZvowk1q7ZqmkvjRCtumbZwDyt60IY gVVVVQjYQyaYgKeiyyyZhzYFLYpjrQTPE5pNH2V3X3c+rY/pgSOvtO7fye2REA== Date: Wed, 11 Jan 2023 16:06:51 +0100 From: Herve Codina To: Christophe Leroy Subject: Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA Message-ID: <20230111160651.24538b35@bootlin.com> In-Reply-To: <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-3-herve.codina@bootlin.com> <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Fabio Estevam , "linux-kernel@vger.kernel.org" , Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , Mark Brown , Nicholas Piggin , Krzysztof Kozlowski , Shengjiu Wang , "linux-arm-kernel@lists.infradead.org" , Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Christophe, On Wed, 11 Jan 2023 13:47:23 +0000 Christophe Leroy wrote: > Le 06/01/2023 =C3=A0 17:37, Herve Codina a =C3=A9crit=C2=A0: > > The TSA (Time Slot Assigner) is available in some > > PowerQUICC SoC such as the MPC885 or MPC866. > >=20 > > Its purpose is to route some TDM time-slots to other > > internal serial controllers. =20 >=20 > Is the subject correct ? As far as I understand this patch adds support=20 > for the TSA on the CPM (exactly on CPM1), not on the QE. Yes exactly, it is a CPM1 support (kind of previous version of QE). Do you think that fixing the subject is enough or do I need also to create a new directory drivers/soc/fsl/cpm/ and move these drivers (TSA and QMC) in this new directory. The alternative could be to leave this driver in drivers/soc/qe/ and rename it to cpm-tsa.c. For information, we have some plan to have this driver working with QE (not done yet). >=20 > By the way, there are already some embryo for handling TSA on QE in=20 > drivers/soc/fsl/qe/qe-tdm.c Yes but this can be seen as an extension only used by=20 drivers/net/wan/fsl_ucc_hdlc.c and it supports QE only. Not sure that qe-tdm.c will fit well if several other drivers instances use it. >=20 > >=20 > > Signed-off-by: Herve Codina =20 >=20 > Christophe Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BDBBC5479D for ; Wed, 11 Jan 2023 15:07:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NsWJZ2QR3z3fB9 for ; Thu, 12 Jan 2023 02:07:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=J2zebCAM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.197; helo=relay5-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=J2zebCAM; dkim-atps=neutral X-Greylist: delayed 111605 seconds by postgrey-1.36 at boromir; Thu, 12 Jan 2023 02:07:04 AEDT Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NsWHX6lbZz2xGq for ; Thu, 12 Jan 2023 02:07:02 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7925C1C000B; Wed, 11 Jan 2023 15:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673449616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=96p48KGQVOszGpiIUB1uMQHTSrU1mw+PEt8uGhIXaOc=; b=J2zebCAM0gphMWejuOqgoceHr5MqD34OCvw5uIQ+F8xbwSyORqkjh5JN2WScz1Txu5rTA2 oWG0oqjsC4TfW2W6iI9azZabaMlxD4UwGsCtIMgaxUsBAVf+S4BhZxNsfF++6qyd88P51j jTN0lxAM9hMeQ2T1yXZ3dCMevMQX/c69W2vPSEc81hUm2hBKXfojWt/aKd1iw4OGl0mv14 6jyJY34VcHSqHG5PWqLJhCiaVS7KwdXzjRRNsRc7oZvowk1q7ZqmkvjRCtumbZwDyt60IY gVVVVQjYQyaYgKeiyyyZhzYFLYpjrQTPE5pNH2V3X3c+rY/pgSOvtO7fye2REA== Date: Wed, 11 Jan 2023 16:06:51 +0100 From: Herve Codina To: Christophe Leroy Subject: Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA Message-ID: <20230111160651.24538b35@bootlin.com> In-Reply-To: <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-3-herve.codina@bootlin.com> <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Fabio Estevam , "linux-kernel@vger.kernel.org" , Thomas Petazzoni , Xiubo Li , Takashi Iwai , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , Mark Brown , Nicholas Piggin , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , "linux-arm-kernel@lists.infradead.org" , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christophe, On Wed, 11 Jan 2023 13:47:23 +0000 Christophe Leroy wrote: > Le 06/01/2023 =C3=A0 17:37, Herve Codina a =C3=A9crit=C2=A0: > > The TSA (Time Slot Assigner) is available in some > > PowerQUICC SoC such as the MPC885 or MPC866. > >=20 > > Its purpose is to route some TDM time-slots to other > > internal serial controllers. =20 >=20 > Is the subject correct ? As far as I understand this patch adds support=20 > for the TSA on the CPM (exactly on CPM1), not on the QE. Yes exactly, it is a CPM1 support (kind of previous version of QE). Do you think that fixing the subject is enough or do I need also to create a new directory drivers/soc/fsl/cpm/ and move these drivers (TSA and QMC) in this new directory. The alternative could be to leave this driver in drivers/soc/qe/ and rename it to cpm-tsa.c. For information, we have some plan to have this driver working with QE (not done yet). >=20 > By the way, there are already some embryo for handling TSA on QE in=20 > drivers/soc/fsl/qe/qe-tdm.c Yes but this can be seen as an extension only used by=20 drivers/net/wan/fsl_ucc_hdlc.c and it supports QE only. Not sure that qe-tdm.c will fit well if several other drivers instances use it. >=20 > >=20 > > Signed-off-by: Herve Codina =20 >=20 > Christophe Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BA14C5479D for ; Wed, 11 Jan 2023 15:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HvqZkmDmzorJpjw0qog2LADvmEQWDi//pfOv2Ulgnic=; b=WK1pHyHkdbzmDA EZnk4o0c/tCRVAsII1PVWyX4DE+AW0xBVammV0uV9CaWx4KpvZ4EN/HUj/D4KzwgPvx7gXN0gc7NZ sM6ZoQi3xOkBnDXDwo7rEjG0mHLwOblU5OrVtHnFEwxyDHDuIeCSYo9sLIQfGZXVTLhrOvheyeyFP AZIqLe/R44QtIWoGN/cpuYR/EVrG2c3Imyzpa5A8/mVql5q5RghOsGEvMXdN2FnF/xu5Y7vjJxp19 l3Br2rRjSHDT7k6okJSPpvH4xT07dxkhpr/imW142cPl6u2byv9WaWSODlvFqEnMpycZZP3YnTjO5 SNC124w7WL6XjsoZiORQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFch7-00Bvh2-CF; Wed, 11 Jan 2023 15:07:13 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFch3-00BvdP-EZ for linux-arm-kernel@lists.infradead.org; Wed, 11 Jan 2023 15:07:11 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7925C1C000B; Wed, 11 Jan 2023 15:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673449616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=96p48KGQVOszGpiIUB1uMQHTSrU1mw+PEt8uGhIXaOc=; b=J2zebCAM0gphMWejuOqgoceHr5MqD34OCvw5uIQ+F8xbwSyORqkjh5JN2WScz1Txu5rTA2 oWG0oqjsC4TfW2W6iI9azZabaMlxD4UwGsCtIMgaxUsBAVf+S4BhZxNsfF++6qyd88P51j jTN0lxAM9hMeQ2T1yXZ3dCMevMQX/c69W2vPSEc81hUm2hBKXfojWt/aKd1iw4OGl0mv14 6jyJY34VcHSqHG5PWqLJhCiaVS7KwdXzjRRNsRc7oZvowk1q7ZqmkvjRCtumbZwDyt60IY gVVVVQjYQyaYgKeiyyyZhzYFLYpjrQTPE5pNH2V3X3c+rY/pgSOvtO7fye2REA== Date: Wed, 11 Jan 2023 16:06:51 +0100 From: Herve Codina To: Christophe Leroy Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , Thomas Petazzoni Subject: Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA Message-ID: <20230111160651.24538b35@bootlin.com> In-Reply-To: <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-3-herve.codina@bootlin.com> <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_070709_710053_15644ECF X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2hyaXN0b3BoZSwKCk9uIFdlZCwgMTEgSmFuIDIwMjMgMTM6NDc6MjMgKzAwMDAKQ2hyaXN0 b3BoZSBMZXJveSA8Y2hyaXN0b3BoZS5sZXJveUBjc2dyb3VwLmV1PiB3cm90ZToKCj4gTGUgMDYv MDEvMjAyMyDDoCAxNzozNywgSGVydmUgQ29kaW5hIGEgw6ljcml0wqA6Cj4gPiBUaGUgVFNBIChU aW1lIFNsb3QgQXNzaWduZXIpIGlzIGF2YWlsYWJsZSBpbiBzb21lCj4gPiBQb3dlclFVSUNDIFNv QyBzdWNoIGFzIHRoZSBNUEM4ODUgb3IgTVBDODY2Lgo+ID4gCj4gPiBJdHMgcHVycG9zZSBpcyB0 byByb3V0ZSBzb21lIFRETSB0aW1lLXNsb3RzIHRvIG90aGVyCj4gPiBpbnRlcm5hbCBzZXJpYWwg Y29udHJvbGxlcnMuICAKPiAKPiBJcyB0aGUgc3ViamVjdCBjb3JyZWN0ID8gQXMgZmFyIGFzIEkg dW5kZXJzdGFuZCB0aGlzIHBhdGNoIGFkZHMgc3VwcG9ydCAKPiBmb3IgdGhlIFRTQSBvbiB0aGUg Q1BNIChleGFjdGx5IG9uIENQTTEpLCBub3Qgb24gdGhlIFFFLgoKWWVzIGV4YWN0bHksIGl0IGlz IGEgQ1BNMSBzdXBwb3J0IChraW5kIG9mIHByZXZpb3VzIHZlcnNpb24gb2YgUUUpLgoKRG8geW91 IHRoaW5rIHRoYXQgZml4aW5nIHRoZSBzdWJqZWN0IGlzIGVub3VnaCBvciBkbyBJIG5lZWQgYWxz bwp0byBjcmVhdGUgYSBuZXcgZGlyZWN0b3J5IGRyaXZlcnMvc29jL2ZzbC9jcG0vIGFuZCBtb3Zl IHRoZXNlIGRyaXZlcnMKKFRTQSBhbmQgUU1DKSBpbiB0aGlzIG5ldyBkaXJlY3RvcnkuCgpUaGUg YWx0ZXJuYXRpdmUgY291bGQgYmUgdG8gbGVhdmUgdGhpcyBkcml2ZXIgaW4gZHJpdmVycy9zb2Mv cWUvIGFuZApyZW5hbWUgaXQgdG8gY3BtLXRzYS5jLgoKRm9yIGluZm9ybWF0aW9uLCB3ZSBoYXZl IHNvbWUgcGxhbiB0byBoYXZlIHRoaXMgZHJpdmVyIHdvcmtpbmcKd2l0aCBRRSAobm90IGRvbmUg eWV0KS4KCj4gCj4gQnkgdGhlIHdheSwgdGhlcmUgYXJlIGFscmVhZHkgc29tZSBlbWJyeW8gZm9y IGhhbmRsaW5nIFRTQSBvbiBRRSBpbiAKPiBkcml2ZXJzL3NvYy9mc2wvcWUvcWUtdGRtLmMKClll cyBidXQgdGhpcyBjYW4gYmUgc2VlbiBhcyBhbiBleHRlbnNpb24gb25seSB1c2VkIGJ5IApkcml2 ZXJzL25ldC93YW4vZnNsX3VjY19oZGxjLmMgYW5kIGl0IHN1cHBvcnRzIFFFIG9ubHkuCgpOb3Qg c3VyZSB0aGF0IHFlLXRkbS5jIHdpbGwgZml0IHdlbGwgaWYgc2V2ZXJhbCBvdGhlcgpkcml2ZXJz IGluc3RhbmNlcyB1c2UgaXQuCgo+IAo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBIZXJ2ZSBDb2Rp bmEgPGhlcnZlLmNvZGluYUBib290bGluLmNvbT4gIAo+IAo+IENocmlzdG9waGUKClRoYW5rcyBm b3IgdGhlIHJldmlldywKSGVydsOpCgotLSAKSGVydsOpIENvZGluYSwgQm9vdGxpbgpFbWJlZGRl ZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA558C46467 for ; Wed, 11 Jan 2023 15:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238416AbjAKPHO (ORCPT ); Wed, 11 Jan 2023 10:07:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239411AbjAKPG7 (ORCPT ); Wed, 11 Jan 2023 10:06:59 -0500 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5763BC64; Wed, 11 Jan 2023 07:06:58 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7925C1C000B; Wed, 11 Jan 2023 15:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673449616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=96p48KGQVOszGpiIUB1uMQHTSrU1mw+PEt8uGhIXaOc=; b=J2zebCAM0gphMWejuOqgoceHr5MqD34OCvw5uIQ+F8xbwSyORqkjh5JN2WScz1Txu5rTA2 oWG0oqjsC4TfW2W6iI9azZabaMlxD4UwGsCtIMgaxUsBAVf+S4BhZxNsfF++6qyd88P51j jTN0lxAM9hMeQ2T1yXZ3dCMevMQX/c69W2vPSEc81hUm2hBKXfojWt/aKd1iw4OGl0mv14 6jyJY34VcHSqHG5PWqLJhCiaVS7KwdXzjRRNsRc7oZvowk1q7ZqmkvjRCtumbZwDyt60IY gVVVVQjYQyaYgKeiyyyZhzYFLYpjrQTPE5pNH2V3X3c+rY/pgSOvtO7fye2REA== Date: Wed, 11 Jan 2023 16:06:51 +0100 From: Herve Codina To: Christophe Leroy Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , Thomas Petazzoni Subject: Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA Message-ID: <20230111160651.24538b35@bootlin.com> In-Reply-To: <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-3-herve.codina@bootlin.com> <7a36f02b-1ba1-b509-4aa0-c5c37a3cb3ef@csgroup.eu> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Christophe, On Wed, 11 Jan 2023 13:47:23 +0000 Christophe Leroy wrote: > Le 06/01/2023 =C3=A0 17:37, Herve Codina a =C3=A9crit=C2=A0: > > The TSA (Time Slot Assigner) is available in some > > PowerQUICC SoC such as the MPC885 or MPC866. > >=20 > > Its purpose is to route some TDM time-slots to other > > internal serial controllers. =20 >=20 > Is the subject correct ? As far as I understand this patch adds support=20 > for the TSA on the CPM (exactly on CPM1), not on the QE. Yes exactly, it is a CPM1 support (kind of previous version of QE). Do you think that fixing the subject is enough or do I need also to create a new directory drivers/soc/fsl/cpm/ and move these drivers (TSA and QMC) in this new directory. The alternative could be to leave this driver in drivers/soc/qe/ and rename it to cpm-tsa.c. For information, we have some plan to have this driver working with QE (not done yet). >=20 > By the way, there are already some embryo for handling TSA on QE in=20 > drivers/soc/fsl/qe/qe-tdm.c Yes but this can be seen as an extension only used by=20 drivers/net/wan/fsl_ucc_hdlc.c and it supports QE only. Not sure that qe-tdm.c will fit well if several other drivers instances use it. >=20 > >=20 > > Signed-off-by: Herve Codina =20 >=20 > Christophe Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com