From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 118E0C46467 for ; Wed, 11 Jan 2023 15:41:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 669522ACB; Wed, 11 Jan 2023 16:40:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 669522ACB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673451679; bh=RR+rWxCapXWCf5VAhLRMluPGOt+VpkuB5+flyMpJTZY=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=noBEdun52hYUcQK86xdhA0zVm+ooOrWZ4YwUm3JjzgGWoKBZ06GitEUV0XEw2L7sG 1TYK3DK1GHoxRgMOYiixvv/X6iObKamQlW+qEIoSrVvK5OF3cdITA48u+2UbLqh3ta dYq9Cg73bIi+k1CcK7QiaRqIRCTHhpSPk+ySHtvc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1AB47F80425; Wed, 11 Jan 2023 16:40:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A7766F80424; Wed, 11 Jan 2023 16:40:27 +0100 (CET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 39130F8016E for ; Wed, 11 Jan 2023 16:40:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 39130F8016E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Q+o9216w Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B16AFE0004; Wed, 11 Jan 2023 15:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673451624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TJ80tI+n7E12DAvDikBDbLVrg9IXgTxZ252Cq+neEbQ=; b=Q+o9216wXpyzH4Fmo4XE+A/19Rhli449oB8gxh74cMuVSBe7TmgTWv0NVMgETjHj7ICimI 2lEldE8luCvEuRzv4wncGEOGkp8+YWnj/gHNVwVIcANGc/i9KFCarw2xI7Zy7ii4mw01BP 3yh4Y2Qf6FLQR/pCfsBovsMC1nhClDVRgsfz9BsqGrMm8sPNTEXSy366YeN1nX8+aedw2l 5dU2xzoQw9jeYIRqNq8AjlA436V/DgDKdEL+uikobI8yvJhFeEtymQvw2NPhOwbDD2+MwT mU28pFltJe6k53uG/R2oCKCPp6dR2f20BtbgaXKCRweyOUiSP64AKbrgZhfqEA== Date: Wed, 11 Jan 2023 16:40:18 +0100 From: Herve Codina To: Christophe Leroy Subject: Re: [PATCH v2 06/10] soc: fsl: qe: Add support for QMC Message-ID: <20230111164018.676a8ca1@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-7-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Fabio Estevam , "linux-kernel@vger.kernel.org" , Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , Mark Brown , Nicholas Piggin , Krzysztof Kozlowski , Shengjiu Wang , "linux-arm-kernel@lists.infradead.org" , Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Christophe, On Wed, 11 Jan 2023 13:58:03 +0000 Christophe Leroy wrote: > Le 06/01/2023 =C3=A0 17:37, Herve Codina a =C3=A9crit=C2=A0: > > The QMC (QUICC Multichannel Controller) is available on some > > PowerQUICC SoC such as the MPC885 or MPC866. =20 >=20 > Same, that's QMC for CPM for the time being, should that be made clear=20 > in the subject ? Also same answer: Will changing the subject be enough or do I need to move it to new created drivers/soc/fsl/cpm/ directory ? >=20 > QE also has QMC and this driver might be used for QE QMC as well with=20 > some enhancement, maybe that could be explained here ? Yes and we plan to have it working on QE too. What do you think if I add the following: The QMC is also available on some Quicc Engine SoC. This current version support CPM1 SoC only. Some enhancement are needed to support Quicc Engine SoC. >=20 > I see you are using in_be16(), out_be16() etc .... > That's specific to powerpc arch, maybe it is better to use ioread16be,=20 > iowrite16be() etc .... > See commit 3f39f38ea91d ("soc: fsl: qe: replace qe_io{read,write}*=20 > wrappers by generic io{read,write}*") and commit 6ac9b61786cc ("soc:=20 > fsl: qe: introduce qe_io{read,write}* wrappers") for information. You're right. I will switch to io{read,write}{16,32}be. I prefer avoid the use of qe_* wrappers as the driver is not (yet) compatible with QE. >=20 > >=20 > > It emulates up to 64 channels within one serial controller > > using the same TDM physical interface routed from the TSA. > >=20 > > Signed-off-by: Herve Codina =20 >=20 > In some places, you comments use the network style, not the generic style. I will fix them. >=20 > Christophe Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C4B5C677F1 for ; Wed, 11 Jan 2023 15:41:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NsX396ZDYz3cf1 for ; Thu, 12 Jan 2023 02:41:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Q+o9216w; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::224; helo=relay4-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Q+o9216w; dkim-atps=neutral Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NsX292PNDz2yJv for ; Thu, 12 Jan 2023 02:40:32 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B16AFE0004; Wed, 11 Jan 2023 15:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673451624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TJ80tI+n7E12DAvDikBDbLVrg9IXgTxZ252Cq+neEbQ=; b=Q+o9216wXpyzH4Fmo4XE+A/19Rhli449oB8gxh74cMuVSBe7TmgTWv0NVMgETjHj7ICimI 2lEldE8luCvEuRzv4wncGEOGkp8+YWnj/gHNVwVIcANGc/i9KFCarw2xI7Zy7ii4mw01BP 3yh4Y2Qf6FLQR/pCfsBovsMC1nhClDVRgsfz9BsqGrMm8sPNTEXSy366YeN1nX8+aedw2l 5dU2xzoQw9jeYIRqNq8AjlA436V/DgDKdEL+uikobI8yvJhFeEtymQvw2NPhOwbDD2+MwT mU28pFltJe6k53uG/R2oCKCPp6dR2f20BtbgaXKCRweyOUiSP64AKbrgZhfqEA== Date: Wed, 11 Jan 2023 16:40:18 +0100 From: Herve Codina To: Christophe Leroy Subject: Re: [PATCH v2 06/10] soc: fsl: qe: Add support for QMC Message-ID: <20230111164018.676a8ca1@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-7-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Fabio Estevam , "linux-kernel@vger.kernel.org" , Thomas Petazzoni , Xiubo Li , Takashi Iwai , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , Mark Brown , Nicholas Piggin , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , "linux-arm-kernel@lists.infradead.org" , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christophe, On Wed, 11 Jan 2023 13:58:03 +0000 Christophe Leroy wrote: > Le 06/01/2023 =C3=A0 17:37, Herve Codina a =C3=A9crit=C2=A0: > > The QMC (QUICC Multichannel Controller) is available on some > > PowerQUICC SoC such as the MPC885 or MPC866. =20 >=20 > Same, that's QMC for CPM for the time being, should that be made clear=20 > in the subject ? Also same answer: Will changing the subject be enough or do I need to move it to new created drivers/soc/fsl/cpm/ directory ? >=20 > QE also has QMC and this driver might be used for QE QMC as well with=20 > some enhancement, maybe that could be explained here ? Yes and we plan to have it working on QE too. What do you think if I add the following: The QMC is also available on some Quicc Engine SoC. This current version support CPM1 SoC only. Some enhancement are needed to support Quicc Engine SoC. >=20 > I see you are using in_be16(), out_be16() etc .... > That's specific to powerpc arch, maybe it is better to use ioread16be,=20 > iowrite16be() etc .... > See commit 3f39f38ea91d ("soc: fsl: qe: replace qe_io{read,write}*=20 > wrappers by generic io{read,write}*") and commit 6ac9b61786cc ("soc:=20 > fsl: qe: introduce qe_io{read,write}* wrappers") for information. You're right. I will switch to io{read,write}{16,32}be. I prefer avoid the use of qe_* wrappers as the driver is not (yet) compatible with QE. >=20 > >=20 > > It emulates up to 64 channels within one serial controller > > using the same TDM physical interface routed from the TSA. > >=20 > > Signed-off-by: Herve Codina =20 >=20 > In some places, you comments use the network style, not the generic style. I will fix them. >=20 > Christophe Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 883D7C5479D for ; Wed, 11 Jan 2023 15:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uJEeMVMWGKzc9FDvCEsb3fvbrmnVtvh4MpxOBCWZtaU=; b=BfwGbt37/y6N5P DLZX64E/i+b9VJAIcZdaGEceHnjL74hKLiXpBSpjPUzWF0tC454sz0KkkzOfNeMhEK0tp6MAdraU4 sl4c+55/K7y3uQJkwHxAq+CrBEeqNjKoBEX6o+MUmFXhwj+19vcWJEYqBmmrjG02gXpr7HkN4Bbcr I4NG/g9Dyg4DAYz5oGMdsHfFf7dCo5q+hRhymRo9OqGGswfyarPO4vnVF1CjeQi9i5O0TiJJR5EFx 9gae9FvEuMyywpeoa4X9wr+y1Q67mZb5YAWRTfa2+pJyUMSAb84+KhQiGY9WpoS1gdoayZ8y755iq EcLChsIUTfPANX6WsOKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFdDN-00C1yG-3W; Wed, 11 Jan 2023 15:40:33 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFdDJ-00C1wm-Lg for linux-arm-kernel@lists.infradead.org; Wed, 11 Jan 2023 15:40:31 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B16AFE0004; Wed, 11 Jan 2023 15:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673451624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TJ80tI+n7E12DAvDikBDbLVrg9IXgTxZ252Cq+neEbQ=; b=Q+o9216wXpyzH4Fmo4XE+A/19Rhli449oB8gxh74cMuVSBe7TmgTWv0NVMgETjHj7ICimI 2lEldE8luCvEuRzv4wncGEOGkp8+YWnj/gHNVwVIcANGc/i9KFCarw2xI7Zy7ii4mw01BP 3yh4Y2Qf6FLQR/pCfsBovsMC1nhClDVRgsfz9BsqGrMm8sPNTEXSy366YeN1nX8+aedw2l 5dU2xzoQw9jeYIRqNq8AjlA436V/DgDKdEL+uikobI8yvJhFeEtymQvw2NPhOwbDD2+MwT mU28pFltJe6k53uG/R2oCKCPp6dR2f20BtbgaXKCRweyOUiSP64AKbrgZhfqEA== Date: Wed, 11 Jan 2023 16:40:18 +0100 From: Herve Codina To: Christophe Leroy Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , Thomas Petazzoni Subject: Re: [PATCH v2 06/10] soc: fsl: qe: Add support for QMC Message-ID: <20230111164018.676a8ca1@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-7-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_074030_182369_69FBD466 X-CRM114-Status: GOOD ( 21.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2hyaXN0b3BoZSwKT24gV2VkLCAxMSBKYW4gMjAyMyAxMzo1ODowMyArMDAwMApDaHJpc3Rv cGhlIExlcm95IDxjaHJpc3RvcGhlLmxlcm95QGNzZ3JvdXAuZXU+IHdyb3RlOgoKPiBMZSAwNi8w MS8yMDIzIMOgIDE3OjM3LCBIZXJ2ZSBDb2RpbmEgYSDDqWNyaXTCoDoKPiA+IFRoZSBRTUMgKFFV SUNDIE11bHRpY2hhbm5lbCBDb250cm9sbGVyKSBpcyBhdmFpbGFibGUgb24gc29tZQo+ID4gUG93 ZXJRVUlDQyBTb0Mgc3VjaCBhcyB0aGUgTVBDODg1IG9yIE1QQzg2Ni4gIAo+IAo+IFNhbWUsIHRo YXQncyBRTUMgZm9yIENQTSBmb3IgdGhlIHRpbWUgYmVpbmcsIHNob3VsZCB0aGF0IGJlIG1hZGUg Y2xlYXIgCj4gaW4gdGhlIHN1YmplY3QgPwoKQWxzbyBzYW1lIGFuc3dlcjoKV2lsbCBjaGFuZ2lu ZyB0aGUgc3ViamVjdCBiZSBlbm91Z2ggb3IgZG8gSSBuZWVkIHRvIG1vdmUgaXQgdG8gbmV3CmNy ZWF0ZWQgZHJpdmVycy9zb2MvZnNsL2NwbS8gZGlyZWN0b3J5ID8KCj4gCj4gUUUgYWxzbyBoYXMg UU1DIGFuZCB0aGlzIGRyaXZlciBtaWdodCBiZSB1c2VkIGZvciBRRSBRTUMgYXMgd2VsbCB3aXRo IAo+IHNvbWUgZW5oYW5jZW1lbnQsIG1heWJlIHRoYXQgY291bGQgYmUgZXhwbGFpbmVkIGhlcmUg PwoKWWVzIGFuZCB3ZSBwbGFuIHRvIGhhdmUgaXQgd29ya2luZyBvbiBRRSB0b28uCgpXaGF0IGRv IHlvdSB0aGluayBpZiBJIGFkZCB0aGUgZm9sbG93aW5nOgogIFRoZSBRTUMgaXMgYWxzbyBhdmFp bGFibGUgb24gc29tZSBRdWljYyBFbmdpbmUgU29DLgogIFRoaXMgY3VycmVudCB2ZXJzaW9uIHN1 cHBvcnQgQ1BNMSBTb0Mgb25seS4gU29tZQogIGVuaGFuY2VtZW50IGFyZSBuZWVkZWQgdG8gc3Vw cG9ydCBRdWljYyBFbmdpbmUgU29DLgoKPiAKPiBJIHNlZSB5b3UgYXJlIHVzaW5nIGluX2JlMTYo KSwgb3V0X2JlMTYoKSBldGMgLi4uLgo+IFRoYXQncyBzcGVjaWZpYyB0byBwb3dlcnBjIGFyY2gs IG1heWJlIGl0IGlzIGJldHRlciB0byB1c2UgaW9yZWFkMTZiZSwgCj4gaW93cml0ZTE2YmUoKSBl dGMgLi4uLgo+IFNlZSBjb21taXQgM2YzOWYzOGVhOTFkICgic29jOiBmc2w6IHFlOiByZXBsYWNl IHFlX2lve3JlYWQsd3JpdGV9KiAKPiB3cmFwcGVycyBieSBnZW5lcmljIGlve3JlYWQsd3JpdGV9 KiIpIGFuZCBjb21taXQgNmFjOWI2MTc4NmNjICgic29jOiAKPiBmc2w6IHFlOiBpbnRyb2R1Y2Ug cWVfaW97cmVhZCx3cml0ZX0qIHdyYXBwZXJzIikgZm9yIGluZm9ybWF0aW9uLgoKWW91J3JlIHJp Z2h0LgpJIHdpbGwgc3dpdGNoIHRvIGlve3JlYWQsd3JpdGV9ezE2LDMyfWJlLgoKSSBwcmVmZXIg YXZvaWQgdGhlIHVzZSBvZiBxZV8qIHdyYXBwZXJzIGFzIHRoZSBkcml2ZXIgaXMgbm90Cih5ZXQp IGNvbXBhdGlibGUgd2l0aCBRRS4KCj4gCj4gPiAKPiA+IEl0IGVtdWxhdGVzIHVwIHRvIDY0IGNo YW5uZWxzIHdpdGhpbiBvbmUgc2VyaWFsIGNvbnRyb2xsZXIKPiA+IHVzaW5nIHRoZSBzYW1lIFRE TSBwaHlzaWNhbCBpbnRlcmZhY2Ugcm91dGVkIGZyb20gdGhlIFRTQS4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogSGVydmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+ICAKPiAKPiBJ biBzb21lIHBsYWNlcywgeW91IGNvbW1lbnRzIHVzZSB0aGUgbmV0d29yayBzdHlsZSwgbm90IHRo ZSBnZW5lcmljIHN0eWxlLgoKSSB3aWxsIGZpeCB0aGVtLgoKPiAKPiBDaHJpc3RvcGhlCgpUaGFu a3MgZm9yIHRoZSByZXZpZXcsCkhlcnbDqQoKLS0gCkhlcnbDqSBDb2RpbmEsIEJvb3RsaW4KRW1i ZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797A2C54EBC for ; Wed, 11 Jan 2023 15:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231453AbjAKPkk (ORCPT ); Wed, 11 Jan 2023 10:40:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235618AbjAKPk1 (ORCPT ); Wed, 11 Jan 2023 10:40:27 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614CF19C3F; Wed, 11 Jan 2023 07:40:25 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B16AFE0004; Wed, 11 Jan 2023 15:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673451624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TJ80tI+n7E12DAvDikBDbLVrg9IXgTxZ252Cq+neEbQ=; b=Q+o9216wXpyzH4Fmo4XE+A/19Rhli449oB8gxh74cMuVSBe7TmgTWv0NVMgETjHj7ICimI 2lEldE8luCvEuRzv4wncGEOGkp8+YWnj/gHNVwVIcANGc/i9KFCarw2xI7Zy7ii4mw01BP 3yh4Y2Qf6FLQR/pCfsBovsMC1nhClDVRgsfz9BsqGrMm8sPNTEXSy366YeN1nX8+aedw2l 5dU2xzoQw9jeYIRqNq8AjlA436V/DgDKdEL+uikobI8yvJhFeEtymQvw2NPhOwbDD2+MwT mU28pFltJe6k53uG/R2oCKCPp6dR2f20BtbgaXKCRweyOUiSP64AKbrgZhfqEA== Date: Wed, 11 Jan 2023 16:40:18 +0100 From: Herve Codina To: Christophe Leroy Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , Thomas Petazzoni Subject: Re: [PATCH v2 06/10] soc: fsl: qe: Add support for QMC Message-ID: <20230111164018.676a8ca1@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-7-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Christophe, On Wed, 11 Jan 2023 13:58:03 +0000 Christophe Leroy wrote: > Le 06/01/2023 =C3=A0 17:37, Herve Codina a =C3=A9crit=C2=A0: > > The QMC (QUICC Multichannel Controller) is available on some > > PowerQUICC SoC such as the MPC885 or MPC866. =20 >=20 > Same, that's QMC for CPM for the time being, should that be made clear=20 > in the subject ? Also same answer: Will changing the subject be enough or do I need to move it to new created drivers/soc/fsl/cpm/ directory ? >=20 > QE also has QMC and this driver might be used for QE QMC as well with=20 > some enhancement, maybe that could be explained here ? Yes and we plan to have it working on QE too. What do you think if I add the following: The QMC is also available on some Quicc Engine SoC. This current version support CPM1 SoC only. Some enhancement are needed to support Quicc Engine SoC. >=20 > I see you are using in_be16(), out_be16() etc .... > That's specific to powerpc arch, maybe it is better to use ioread16be,=20 > iowrite16be() etc .... > See commit 3f39f38ea91d ("soc: fsl: qe: replace qe_io{read,write}*=20 > wrappers by generic io{read,write}*") and commit 6ac9b61786cc ("soc:=20 > fsl: qe: introduce qe_io{read,write}* wrappers") for information. You're right. I will switch to io{read,write}{16,32}be. I prefer avoid the use of qe_* wrappers as the driver is not (yet) compatible with QE. >=20 > >=20 > > It emulates up to 64 channels within one serial controller > > using the same TDM physical interface routed from the TSA. > >=20 > > Signed-off-by: Herve Codina =20 >=20 > In some places, you comments use the network style, not the generic style. I will fix them. >=20 > Christophe Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com