From: Jakub Kicinski <kuba@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: renesas: rswitch: Fix ethernet-ports handling
Date: Wed, 11 Jan 2023 20:18:57 -0800 [thread overview]
Message-ID: <20230111201857.6610f412@kernel.org> (raw)
In-Reply-To: <20230110095559.314429-1-yoshihiro.shimoda.uh@renesas.com>
On Tue, 10 Jan 2023 18:55:59 +0900 Yoshihiro Shimoda wrote:
> +#define rswitch_for_each_enabled_port_reverse(priv, i) \
> + for (i--; i >= 0; i--) \
nit: the typical name suffix for this sort of macro in Linux would
be _continue_reverse - because it doesn't initialize the iterator.
It's specifically targeting error paths.
That's what list.h uses, on a quick grep I can see the same convention
is used for netdevice.h and dsa.h. Do you have counter examples?
I reckon we should throw "_continue" into the name.
next prev parent reply other threads:[~2023-01-12 4:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 9:55 [PATCH net] net: ethernet: renesas: rswitch: Fix ethernet-ports handling Yoshihiro Shimoda
2023-01-10 14:14 ` Jiri Pirko
2023-01-12 4:18 ` Jakub Kicinski [this message]
2023-01-12 7:35 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111201857.6610f412@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.