All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <broonie@kernel.org>, <vkoul@kernel.org>
Cc: <yung-chuan.liao@linux.intel.com>,
	<pierre-louis.bossart@linux.intel.com>, <sanyog.r.kale@intel.com>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: [PATCH 1/2] regmap: sdw: Update misleading comment
Date: Thu, 12 Jan 2023 17:18:39 +0000	[thread overview]
Message-ID: <20230112171840.2098463-2-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20230112171840.2098463-1-ckeepax@opensource.cirrus.com>

In the regmap config reg_bits represents the number of address bits not
the number of value bits. Correct the misleading comment which looks a
lot like it suggests the register value itself is 32-bits wide.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 drivers/base/regmap/regmap-sdw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/regmap-sdw.c b/drivers/base/regmap/regmap-sdw.c
index 81b0327f719d8..95801fd411b26 100644
--- a/drivers/base/regmap/regmap-sdw.c
+++ b/drivers/base/regmap/regmap-sdw.c
@@ -43,7 +43,7 @@ static int regmap_sdw_config_check(const struct regmap_config *config)
 	if (config->val_bits != 8)
 		return -ENOTSUPP;
 
-	/* Registers are 32 bits wide */
+	/* Register addresses are 32 bits wide */
 	if (config->reg_bits != 32)
 		return -ENOTSUPP;
 
-- 
2.30.2


  reply	other threads:[~2023-01-12 18:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 17:18 [PATCH 0/2] Minor SoundWire Regmap Tweaks Charles Keepax
2023-01-12 17:18 ` Charles Keepax [this message]
2023-01-12 17:18 ` [PATCH 2/2] regmap: sdw: Remove 8-bit value size restriction Charles Keepax
2023-01-12 17:38   ` Pierre-Louis Bossart
2023-01-12 18:14     ` Mark Brown
2023-01-12 18:43       ` Pierre-Louis Bossart
2023-01-12 19:50         ` Mark Brown
2023-01-12 20:19           ` Pierre-Louis Bossart
2023-01-13 11:02             ` Charles Keepax
2023-01-13 16:57               ` Pierre-Louis Bossart
2023-01-13 17:11                 ` Mark Brown
2023-01-13 18:03                   ` Pierre-Louis Bossart
2023-03-10 15:02 ` [PATCH 0/2] Minor SoundWire Regmap Tweaks Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230112171840.2098463-2-ckeepax@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.