From: Jakub Kicinski <kuba@kernel.org>
To: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Cc: netdev@vger.kernel.org, mkubecek@suse.cz,
sridhar.samudrala@intel.com, anthony.l.nguyen@intel.com
Subject: Re: [PATCH net] ethtool:add netlink attr in rss get reply only if value is not null
Date: Fri, 13 Jan 2023 11:40:29 -0800 [thread overview]
Message-ID: <20230113114029.0ed9f618@kernel.org> (raw)
In-Reply-To: <20230111235607.85509-1-sudheer.mogilappagari@intel.com>
On Wed, 11 Jan 2023 15:56:07 -0800 Sudheer Mogilappagari wrote:
> Current code for RSS_GET ethtool command includes netlink attributes
> in reply message to user space even if they are null. Added checks
> to include netlink attribute in reply message only if a value is
> received from driver. Drivers might return null for RSS indirection
> table or hash key. Instead of including attributes with empty value
> in the reply message, add netlink attribute only if there is content.
>
> Fixes: 7112a04664bf ("ethtool: add netlink based get rss support")
> Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Applied, thanks!
prev parent reply other threads:[~2023-01-13 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 23:56 [PATCH net] ethtool:add netlink attr in rss get reply only if value is not null Sudheer Mogilappagari
2023-01-12 8:06 ` Michal Kubecek
2023-01-13 19:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113114029.0ed9f618@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.