From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: "Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar: avoid defines prefixed with CONFIG
Date: Fri, 13 Jan 2023 07:58:30 -0600 [thread overview]
Message-ID: <20230113135830.GA1835786@bhelgaas> (raw)
In-Reply-To: <20230113084516.31888-1-lukas.bulwahn@gmail.com>
Hi Lukas,
On Fri, Jan 13, 2023 at 09:45:16AM +0100, Lukas Bulwahn wrote:
> Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
> that are introduced in a Kconfig file.
>
> Here, a definition for a bitmask to configure the SEND_ENABLE mode is named
> CONFIG_SEND_ENABLE.
>
> Rename this local definition to CONFIGURE_SEND_ENABLE to avoid defines
> prefixed with "CONFIG".
>
> No functional change.
If you update this patch, please capitalize the subject to match:
$ git log --oneline drivers/pci/controller/pcie-rcar-host.c
6e36203bc14c ("PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception")
84b576146294 ("PCI: rcar: Finish transition to L1 state in rcar_pcie_config_access()")
d2a14b54989e ("PCI: rcar: Check if device is runtime suspended instead of __clk_is_enabled()")
a115b1bd3af0 ("PCI: rcar: Add L1 link state fix into data abort hook")
83ed8d4fa656 ("PCI: rcar: Convert to MSI domains")
Bjorn
next prev parent reply other threads:[~2023-01-13 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 8:45 [PATCH] PCI: rcar: avoid defines prefixed with CONFIG Lukas Bulwahn
2023-01-13 9:05 ` Geert Uytterhoeven
2023-01-13 9:06 ` Geert Uytterhoeven
2023-01-13 16:30 ` Lorenzo Pieralisi
2023-02-02 15:40 ` Lorenzo Pieralisi
2023-01-13 13:58 ` Bjorn Helgaas [this message]
2023-03-10 12:36 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113135830.GA1835786@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.