From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Bandan Das" <bsd@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
libvir-list@redhat.com, "Qiuhao Li" <Qiuhao.Li@outlook.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Thomas Huth" <thuth@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 1/9] audio: don't check qemu_add_vm_change_state_handler failure
Date: Fri, 13 Jan 2023 11:21:52 -0500 [thread overview]
Message-ID: <20230113162200.3010804-2-berrange@redhat.com> (raw)
In-Reply-To: <20230113162200.3010804-1-berrange@redhat.com>
This function cannot fail since g_malloc0 aborts on OOM.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
audio/audio.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index d849a94a81..7b4b957945 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1712,7 +1712,6 @@ static AudioState *audio_init(Audiodev *dev, const char *name)
size_t i;
int done = 0;
const char *drvname = NULL;
- VMChangeStateEntry *e;
AudioState *s;
struct audio_driver *driver;
/* silence gcc warning about uninitialized variable */
@@ -1830,11 +1829,7 @@ static AudioState *audio_init(Audiodev *dev, const char *name)
s->period_ticks = dev->timer_period * (int64_t)SCALE_US;
}
- e = qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s);
- if (!e) {
- dolog ("warning: Could not register change state handler\n"
- "(Audio can continue looping even after stopping the VM)\n");
- }
+ qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s);
QTAILQ_INSERT_TAIL(&audio_states, s, list);
QLIST_INIT (&s->card_head);
--
2.38.1
next prev parent reply other threads:[~2023-01-13 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 16:21 [PATCH 0/9] audio: remove deprecated QEMU_AUDIO env support Daniel P. Berrangé
2023-01-13 16:21 ` Daniel P. Berrangé [this message]
2023-01-15 15:44 ` [PATCH 1/9] audio: don't check qemu_add_vm_change_state_handler failure Volker Rümelin
2023-01-13 16:21 ` [PATCH 2/9] audio: remove special audio_calloc function Daniel P. Berrangé
2023-01-15 14:03 ` Volker Rümelin
2023-01-16 9:23 ` Daniel P. Berrangé
2023-01-13 16:21 ` [PATCH 3/9] audio: remove unused 'name' in QEMUSoundCard struct Daniel P. Berrangé
2023-01-13 16:21 ` [PATCH 4/9] audio: remove QEMUSoundCard linked list Daniel P. Berrangé
2023-01-13 16:21 ` [PATCH 5/9] audio: remove empty AUD_remove_card method Daniel P. Berrangé
2023-01-13 16:21 ` [PATCH 6/9] docs: split the deprecation warning for soundcards vs VNC Daniel P. Berrangé
2023-01-13 16:21 ` [PATCH 7/9] ui/vnc: don't accept VNC_ENCODING_AUDIO without audiodev Daniel P. Berrangé
2023-01-13 16:21 ` [PATCH 8/9] audio: audio state is now mandatory for capture Daniel P. Berrangé
2023-01-13 16:22 ` [PATCH 9/9] audio: remove support for QEMU_AUDIO_ env variables Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113162200.3010804-2-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.