From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49538C54EBD for ; Fri, 13 Jan 2023 17:11:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGMol-0006fn-2H; Fri, 13 Jan 2023 11:22:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGMoi-0006e1-0Y for qemu-devel@nongnu.org; Fri, 13 Jan 2023 11:22:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGMog-0005lu-HJ for qemu-devel@nongnu.org; Fri, 13 Jan 2023 11:22:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673626925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qj/HapzcHsz+lqoeq6mPy+OvCjqNa7TRsHescVWlvFg=; b=QRIwQa8366a+Ob0l7h0yeA0i2U17KDR7lUT2lnA2L6MNzZpv4kIrfOVqo88vIliGpoHSwf ykXm8D34vXwMRxQxHnfJ7bbRi2aG5h4oIs9WxXOwQ3Dl2j2iWcQ6Wbjg+rVAmb5TJSQQm/ NMAMLqb/mQmyhULNM9yXHOotC4CJUvk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-unUBocPKOxG0JG3N_nxEgg-1; Fri, 13 Jan 2023 11:22:03 -0500 X-MC-Unique: unUBocPKOxG0JG3N_nxEgg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A5BA380391F; Fri, 13 Jan 2023 16:22:03 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0898940C2007; Fri, 13 Jan 2023 16:22:03 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Bandan Das , Laurent Vivier , Darren Kenny , Stefan Hajnoczi , libvir-list@redhat.com, Qiuhao Li , Paolo Bonzini , Christian Schoenebeck , Thomas Huth , Gerd Hoffmann , Alexander Bulekov , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 4/9] audio: remove QEMUSoundCard linked list Date: Fri, 13 Jan 2023 11:21:55 -0500 Message-Id: <20230113162200.3010804-5-berrange@redhat.com> In-Reply-To: <20230113162200.3010804-1-berrange@redhat.com> References: <20230113162200.3010804-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org No code ever iterates over the list Signed-off-by: Daniel P. Berrangé --- audio/audio.c | 5 ----- audio/audio.h | 1 - audio/audio_int.h | 1 - 3 files changed, 7 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 94a16c2dda..217095306f 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1812,7 +1812,6 @@ static AudioState *audio_init(Audiodev *dev, const char *name) qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s); QTAILQ_INSERT_TAIL(&audio_states, s, list); - QLIST_INIT (&s->card_head); vmstate_register (NULL, 0, &vmstate_audio, s); return s; } @@ -1832,14 +1831,10 @@ void AUD_register_card (const char *name, QEMUSoundCard *card) if (!card->state) { card->state = audio_init(NULL, name); } - - memset (&card->entries, 0, sizeof (card->entries)); - QLIST_INSERT_HEAD(&card->state->card_head, card, entries); } void AUD_remove_card (QEMUSoundCard *card) { - QLIST_REMOVE (card, entries); } static struct audio_pcm_ops capture_pcm_ops; diff --git a/audio/audio.h b/audio/audio.h index eefb809a54..ebcc540431 100644 --- a/audio/audio.h +++ b/audio/audio.h @@ -83,7 +83,6 @@ typedef struct SWVoiceIn SWVoiceIn; typedef struct AudioState AudioState; typedef struct QEMUSoundCard { AudioState *state; - QLIST_ENTRY (QEMUSoundCard) entries; } QEMUSoundCard; typedef struct QEMUAudioTimeStamp { diff --git a/audio/audio_int.h b/audio/audio_int.h index b0cc2cd390..ca62e49ee5 100644 --- a/audio/audio_int.h +++ b/audio/audio_int.h @@ -225,7 +225,6 @@ typedef struct AudioState { void *drv_opaque; QEMUTimer *ts; - QLIST_HEAD (card_listhead, QEMUSoundCard) card_head; QLIST_HEAD (hw_in_listhead, HWVoiceIn) hw_head_in; QLIST_HEAD (hw_out_listhead, HWVoiceOut) hw_head_out; QLIST_HEAD (cap_listhead, CaptureVoiceOut) cap_head; -- 2.38.1