From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E2D7C6379F for ; Fri, 13 Jan 2023 23:16:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2468485582; Sat, 14 Jan 2023 00:16:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Hl+xr9Vr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3C2085376; Sat, 14 Jan 2023 00:16:10 +0100 (CET) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B508C85582 for ; Sat, 14 Jan 2023 00:16:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id d16so7416958qtw.8 for ; Fri, 13 Jan 2023 15:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B3GJIJDnJXQlH64XgXwkPrOmZMenzMQN1cEe5XTyZ3c=; b=Hl+xr9VrePqF60gyh3elQ6mUUAKzeShWZrrS+Wel5TkY2KJAaRsSNspAcdSYk42x+w FQ2EYUkrgd5vyAnUwoCAEDDboF2Qo4b43YP3Bgy200BWi/+3zBS7mKeGb/CSHTJJa84G qaoYiPi4N1dzHhYx1GQDpiUiy6YwZfWqI21T4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B3GJIJDnJXQlH64XgXwkPrOmZMenzMQN1cEe5XTyZ3c=; b=FHfPHfqPj4jp+Q7vPLtWzc/d9QHttjwURpSUPVI90pV5H5MxHtQ0xQ/NFM4Ve/HTjh GKSiSV7UFveg8yuofrE7qtwGahwqIYTjhZxZl2kyDFze3wWZBNshejb1BjQLpvuEgnCu uQRPf7ejgjx7lRCa5+oYRqnVwc7qm7vrTTx1ZUZ/rN23z5joLksNekUTDPmFRM6lb83o smw33uekHUgtzzQUHJl1N82jmwNy40bEcg05POkTHpBwamWtuMyWFVvZecrY8tbswSFy kC5awq5AgYdl45+S/x5rz3IbsMclRA772DlwnXULfd+xgXDInkdo2ijG4Sj8q6fBQ0Fx ezLA== X-Gm-Message-State: AFqh2kps1ESomTCHVYUUJ0jV/DOf/dg3ej6iRIDaC9SAnh4hZ9WYMtKc x95+stY3mmCbMGKOoGhMazp3EQ== X-Google-Smtp-Source: AMrXdXvkd2Fdr/c14HxSeKIqzia2yZyWOwRXgt+q+nT3CCJ/sJISaKoZmCAndrErxRl3lZeSbn9iTg== X-Received: by 2002:ac8:7303:0:b0:3b1:ad76:eefe with SMTP id x3-20020ac87303000000b003b1ad76eefemr12510867qto.10.1673651766484; Fri, 13 Jan 2023 15:16:06 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a538-813d-bada-d144.res6.spectrum.com. [2603:6081:7b00:6400:a538:813d:bada:d144]) by smtp.gmail.com with ESMTPSA id l22-20020a05620a28d600b0070531c5d655sm13863292qkp.90.2023.01.13.15.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 15:16:05 -0800 (PST) Date: Fri, 13 Jan 2023 18:16:03 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Heiko Schocher , u-boot@lists.denx.de Subject: Re: [PATCH v2 u-boot 2/3] powerpc/mpc85xx: socrates: Rename u-boot-socrates.bin to u-boot.bin Message-ID: <20230113231603.GA3787616@bill-the-cat> References: <20221228200437.30971-1-pali@kernel.org> <20230113231123.27427-1-pali@kernel.org> <20230113231123.27427-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gQK++5HH+aeYxy4n" Content-Disposition: inline In-Reply-To: <20230113231123.27427-2-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --gQK++5HH+aeYxy4n Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 14, 2023 at 12:11:22AM +0100, Pali Roh=E1r wrote: > U-Boot build process for socrates board produces final U-Boot binary in > file u-boot-socrates.bin (by binman) And as a bonus it produces two > unusable broken binaries u-boot-dtb.bin and u-boot.bin (by Makefile). >=20 > So do not build broken u-boot-dtb.bin and u-boot.bin binaries and rename > board specific u-boot-socrates.bin binary to u-boot.bin. >=20 > Renaming requires to define a new socrates specific Makefile target for > u-boot.bin (via binman) and also changing output name in socrates binman > config file. >=20 > With this change U-Boot build process for socrates board also produces > final U-Boot binary in file u-boot.bin. >=20 > Signed-off-by: Pali Roh=E1r > --- > Added make dependency on u-boot.dtb > --- > Makefile | 11 +++++++++++ > arch/powerpc/dts/socrates-u-boot.dtsi | 2 +- > 2 files changed, 12 insertions(+), 1 deletion(-) >=20 > diff --git a/Makefile b/Makefile > index a4a14d5d35a8..5473bea25332 100644 > --- a/Makefile > +++ b/Makefile > @@ -1195,22 +1195,30 @@ endif > u-boot.bin: u-boot-fit-dtb.bin FORCE > $(call if_changed,copy) > =20 > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > u-boot-dtb.bin: u-boot-nodtb.bin dts/dt.dtb FORCE > $(call if_changed,cat) > +endif > =20 > else ifeq ($(CONFIG_OF_SEPARATE).$(CONFIG_OF_OMIT_DTB),y.) > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > u-boot-dtb.bin: u-boot-nodtb.bin dts/dt.dtb FORCE > $(call if_changed,cat) > +endif > =20 > ifneq ($(CONFIG_MPC85XX_HAVE_RESET_VECTOR)$(CONFIG_OF_SEPARATE),yy) > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > u-boot.bin: u-boot-dtb.bin FORCE > $(call if_changed,copy) > endif > +endif > =20 > else ifneq ($(CONFIG_MPC85XX_HAVE_RESET_VECTOR)$(CONFIG_OF_SEPARATE),yy) > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > u-boot.bin: u-boot-nodtb.bin FORCE > $(call if_changed,copy) > endif > +endif Simon's point from before still stands. This is the opposite of what we want. There must not be CONFIG_TARGET_ logic introduced to the top-level Makefile. socrate is "just" another mpc85xx platform, it doesn't have a special ROM, we need to adjust it back to acting like other platforms. --=20 Tom --gQK++5HH+aeYxy4n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPB5jAACgkQFHw5/5Y0 tyymPwwAiX+4FuWOPYwtQn+i9XDYYItJr5bYsgwCyIazpoFk6naMRDDZ924jW7NE ybOFhwd9rUYuuB/eC9zH+Pw1wf6esgBnckX88v+rF9q7p7YL65+Uuo7NXEic6eGO B+hnlwEICUXIlg0n3IKuRlg5nFisDWPEiB90cDPPfE4hoOTVspfaB0l0PSNYUxkr 6RTXNnw5tcdSyBLQXfh3SKyZhHXDCeEnUhg6K5w616hcjU6mhKO7iXZVI3fgMxhQ hzGUJV+/s8ObcxfpozRaDeIyM5yERGpjn6poWf7ScNQ5NwnL1Q6lAXW9WVUnaWn+ tPKyM6fT8RphO2IjAtmiAdLSDllkrGvdhoU8OZgYcnUohBUMbgRufcLWNG0w4sA3 93Vlz4t/HXoRg8u6lCI+79kcFMR7osxUfY9pQbY0IpeZ8VGoeVR5TmODJ521VHXh oR0AttFkrYlzRL3JUDyF8JMbOTSNRJzJjHVvFdHjeebziX4NBm9VOvmVddQ1z6WL VYMiRu9A =iztw -----END PGP SIGNATURE----- --gQK++5HH+aeYxy4n--