From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 045CCC46467 for ; Sat, 14 Jan 2023 21:24:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9E218851A4; Sat, 14 Jan 2023 22:24:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="NEPeNtuj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D259B85232; Sat, 14 Jan 2023 22:24:36 +0100 (CET) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3FE23851A4 for ; Sat, 14 Jan 2023 22:24:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf33.google.com with SMTP id j9so17244900qvt.0 for ; Sat, 14 Jan 2023 13:24:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UzZc039jm/DeiwbzYS9ZaieARuyFoz1pbnpiqPW8XJQ=; b=NEPeNtujQnvGKF03YffgfXPUv7kWysw+yacpC/92KbFiIaCQy9kOVzA0oZYVPxwDv5 5oLJojO6I7jDm9JdzfnMthz2qvrw1uFS8mFYgAFdqbG9yLM1QKISWOHzdAI3EAxg/2OG 95aqvjYmsWB8MEPzPWjvYqnqKnGTjx0ijry9U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UzZc039jm/DeiwbzYS9ZaieARuyFoz1pbnpiqPW8XJQ=; b=4Vu2JuKphTPQsvu3gDDJCsZl5VRjPiSd5Pf9QDJRA3jwzAShfdWTBmcC+Y0PFkiLsN zV3YvNO0P81lO4tk8RPCI52bN7m6SHS3qraM8p2/fqQErZpFckAJxh43X8BGu2J7ORHw MDN2lXj+iD3KEXhS+HM13pTGiOCMxS1021sh7Wye9Llplr5m3E+/mSQehHN9ONSAf0v+ m0M5e1XCDZbvzQdybBRMj4UWjr3zoR8hRI8v/5iVZpfps9jr1Mn4SvcOoHham+o9Evs9 LeFw2Ow7dbYvuR2kEGgvBFNb1ipO/aGoVB2zhLOvxoK3mDd2g7o19RmSs2611DyEA9Jb QLcQ== X-Gm-Message-State: AFqh2kqKzvVJv0+hVAIhcSPtZ5eh9ZIg4phZxULB+swktsaVQRCZhmSp t9rJkInBV8Y/iFHN73mZGw6B9Q== X-Google-Smtp-Source: AMrXdXtJ0Pz1c/X4igSkmtdGe8S6/zmbhtKKatVqasLypO/UIFkunbOo9VKbpY9F2uWRxsx7hYbMnA== X-Received: by 2002:a05:6214:5d0a:b0:534:d1dd:2934 with SMTP id me10-20020a0562145d0a00b00534d1dd2934mr3296120qvb.14.1673731472937; Sat, 14 Jan 2023 13:24:32 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b9fb-5a96-85b2-3cfc.res6.spectrum.com. [2603:6081:7b00:6400:b9fb:5a96:85b2:3cfc]) by smtp.gmail.com with ESMTPSA id y10-20020a05620a25ca00b006fa4cac54a5sm15094491qko.72.2023.01.14.13.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 13:24:32 -0800 (PST) Date: Sat, 14 Jan 2023 16:24:30 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= , Heiko Schocher Cc: u-boot@lists.denx.de Subject: Re: [PATCH v2 u-boot 2/3] powerpc/mpc85xx: socrates: Rename u-boot-socrates.bin to u-boot.bin Message-ID: <20230114212430.GI3880571@bill-the-cat> References: <20221228200437.30971-1-pali@kernel.org> <20230113231123.27427-1-pali@kernel.org> <20230113231123.27427-2-pali@kernel.org> <20230113231603.GA3787616@bill-the-cat> <20230114211206.ketwu6q3x7mugm34@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Op27XXJsWz80g3oF" Content-Disposition: inline In-Reply-To: <20230114211206.ketwu6q3x7mugm34@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Op27XXJsWz80g3oF Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 14, 2023 at 10:12:06PM +0100, Pali Roh=E1r wrote: > On Friday 13 January 2023 18:16:03 Tom Rini wrote: > > On Sat, Jan 14, 2023 at 12:11:22AM +0100, Pali Roh=E1r wrote: > > > U-Boot build process for socrates board produces final U-Boot binary = in > > > file u-boot-socrates.bin (by binman) And as a bonus it produces two > > > unusable broken binaries u-boot-dtb.bin and u-boot.bin (by Makefile). > > >=20 > > > So do not build broken u-boot-dtb.bin and u-boot.bin binaries and ren= ame > > > board specific u-boot-socrates.bin binary to u-boot.bin. > > >=20 > > > Renaming requires to define a new socrates specific Makefile target f= or > > > u-boot.bin (via binman) and also changing output name in socrates bin= man > > > config file. > > >=20 > > > With this change U-Boot build process for socrates board also produces > > > final U-Boot binary in file u-boot.bin. > > >=20 > > > Signed-off-by: Pali Roh=E1r > > > --- > > > Added make dependency on u-boot.dtb > > > --- > > > Makefile | 11 +++++++++++ > > > arch/powerpc/dts/socrates-u-boot.dtsi | 2 +- > > > 2 files changed, 12 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/Makefile b/Makefile > > > index a4a14d5d35a8..5473bea25332 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -1195,22 +1195,30 @@ endif > > > u-boot.bin: u-boot-fit-dtb.bin FORCE > > > $(call if_changed,copy) > > > =20 > > > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > > > u-boot-dtb.bin: u-boot-nodtb.bin dts/dt.dtb FORCE > > > $(call if_changed,cat) > > > +endif > > > =20 > > > else ifeq ($(CONFIG_OF_SEPARATE).$(CONFIG_OF_OMIT_DTB),y.) > > > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > > > u-boot-dtb.bin: u-boot-nodtb.bin dts/dt.dtb FORCE > > > $(call if_changed,cat) > > > +endif > > > =20 > > > ifneq ($(CONFIG_MPC85XX_HAVE_RESET_VECTOR)$(CONFIG_OF_SEPARATE),yy) > > > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > > > u-boot.bin: u-boot-dtb.bin FORCE > > > $(call if_changed,copy) > > > endif > > > +endif > > > =20 > > > else ifneq ($(CONFIG_MPC85XX_HAVE_RESET_VECTOR)$(CONFIG_OF_SEPARATE)= ,yy) > > > +ifneq ($(CONFIG_TARGET_SOCRATES),y) > > > u-boot.bin: u-boot-nodtb.bin FORCE > > > $(call if_changed,copy) > > > endif > > > +endif > >=20 > > Simon's point from before still stands. This is the opposite of what we > > want. There must not be CONFIG_TARGET_ logic introduced to the > > top-level Makefile. socrate is "just" another mpc85xx platform, it > > doesn't have a special ROM, we need to adjust it back to acting like > > other platforms. >=20 > socrates has its own flash layout, own build procedure and purpose of > this patch is just to prevent another breakage (like it was done in the > past) by throwing make errors. >=20 > Trying to adjust board code and changing its layout is really not up to > me. I do not have this board. >=20 > One there is generic binman build rules from make then it can be > switches to that generic binman rule. Until it happen there is not > better option... Yes, it should be Heiko, as the board maintainer, dealing with fixing this part. I don't understand the flash layout, and the partition table laid out in arch/powerpc/dts/socrates.dts confuses things even more to me. But, the board maintainer should be able to sort this all out. Because we do not want to add CONFIG_TARGET_ logic to the top-level Makefile. --=20 Tom --Op27XXJsWz80g3oF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPDHYsACgkQFHw5/5Y0 tyz3Vgv9EHgYCKsy9UT4CzWWOX84v1q7aEwatU5nvHxomA7AXvUzlaf12qcqG34o QYvRSjXUAXGeOmDp7EX0RIUw3Yw/n5HZBH4CVFOgFHo/NIzBquRRT7vTTt0D0xqg fjDCuQruw/JEIGRxQJdlIzwTladNK1QFlS0U7+FlPLAH3Wu6Ch1wIdDFO3xq4Jmg cFTbFN+BZDXxaWOFnJDmyVlKOpjrwDxuZ2ven2X9FKFwIFNN7SKXwEWc1KTlmb+O T5IgGu33+whcPP1r/Js8aSPcqpH9dgtz+UGPS1MNz8TJr1P7IRA3+J1ocV3DAEl2 12JuijB86je3VctDDfy1U6IGLX2OXrEmC58FiAngq/yiSjlPEEurj+jKFugyg2Fg aNwt3QyDeYiba3I1kBamrf3Q1SpF1llEZXCfaVY34GhC22elKBJJNKwVWjyerK2Z WPTsmRWpmTfIppUw+4AHHUrxxJfwNhFUBudIKjq02z++YssZfa6iztYN2aUUpIqC RGUmS/AI =fdwI -----END PGP SIGNATURE----- --Op27XXJsWz80g3oF--