From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Vincent Fazio <vfazio@gmail.com>
Cc: Floris Bos <bos@je-eigen-domein.nl>,
Heiko Thiery <heiko.thiery@gmail.com>,
Vincent Fazio <vfazio@xes-inc.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/ipmitool: backport fixes for registry issues
Date: Sat, 14 Jan 2023 22:58:21 +0100 [thread overview]
Message-ID: <20230114225821.4edc5530@windsurf> (raw)
In-Reply-To: <CAOrEah5_BQzsLnHYkMGvpSR=MxeqTeDkmbKNAQOOJ6eRXreg-g@mail.gmail.com>
On Sat, 14 Jan 2023 15:33:06 -0600
Vincent Fazio <vfazio@gmail.com> wrote:
> replies below (i hope, i haven't tried responding to ML emails in gmail)
It's almost good, except that gmail adds one extra > on the first line
of each paragraph of your replies.
> > So in the current Buildroot situation (before this patch), the registry
> > is always installed, correct?
> >
> > Correct, but with a caveat... as of the version bump to 1.8.19, the file
> being installed is broken and the tool actually won't work.
So the current ipmitool in Buildroot is broken. Could perhaps separate
a "fix" that could be backported from a large improvement that allows
to not used the registry?
> All upstream patches have been accepted into mainline. The commit hashes
> in the patches are the mainline commits
Thing is we don't which are "upstream patches". If the patches are
upstream, you can do:
Signed-off-by: John Doe <john.doe@foobar.com>
Upstream: https://github.com/some/where/commit/12456abc
This makes it very clear that it has been accepted upstream, and will
help someone who will do the next ipmitool version bump.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-01-14 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 22:54 [Buildroot] [PATCH 1/2] package/ipmitool: backport fixes for registry issues Vincent Fazio
2023-01-13 22:54 ` [Buildroot] [PATCH 2/2] package/ipmitool: use the standard github helper Vincent Fazio
2023-01-14 21:14 ` Thomas Petazzoni via buildroot
2023-01-14 21:17 ` [Buildroot] [PATCH 1/2] package/ipmitool: backport fixes for registry issues Thomas Petazzoni via buildroot
[not found] ` <CAOrEah5_BQzsLnHYkMGvpSR=MxeqTeDkmbKNAQOOJ6eRXreg-g@mail.gmail.com>
2023-01-14 21:58 ` Thomas Petazzoni via buildroot [this message]
2023-01-15 10:52 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230114225821.4edc5530@windsurf \
--to=buildroot@buildroot.org \
--cc=bos@je-eigen-domein.nl \
--cc=heiko.thiery@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vfazio@gmail.com \
--cc=vfazio@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.