From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFD033EC for ; Mon, 16 Jan 2023 15:58:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54173C43398; Mon, 16 Jan 2023 15:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673884683; bh=qYZXSOzicrWQ+yy6bcX4S5USwhjwN1EiS3k6yP6RCdk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NWvYSv4KyIjed8x+GNTFauDXS7GyvRnlKch5uAevS3He1YfQ9LVUcjO9aI+hzhA2w dpYPl8qONGZm3mTMGvgsbdwQ8zHzo9Y4MPcnHPgOKMVaPjp6emB7/qBqyg8FzY/REG 7mf6lEDAmaeHshLclyrLuegGrSXvQE9t9MLnRfuo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniil Tatianin , Michal Swiatkowski , Tony Nguyen Subject: [PATCH 6.1 072/183] iavf/iavf_main: actually log ->src mask when talking about it Date: Mon, 16 Jan 2023 16:49:55 +0100 Message-Id: <20230116154806.426690563@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230116154803.321528435@linuxfoundation.org> References: <20230116154803.321528435@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Daniil Tatianin commit 6650c8e906ce58404bfdfceceeba7bd10d397d40 upstream. This fixes a copy-paste issue where dev_err would log the dst mask even though it is clearly talking about src. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") Signed-off-by: Daniil Tatianin Reviewed-by: Michal Swiatkowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct field_flags |= IAVF_CLOUD_FIELD_IIP; } else { dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n", - be32_to_cpu(match.mask->dst)); + be32_to_cpu(match.mask->src)); return -EINVAL; } }