From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B1586FA0 for ; Mon, 16 Jan 2023 17:06:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85807C433D2; Mon, 16 Jan 2023 17:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673888762; bh=33gXBh+JjVD+kyVoxuqg68jRIovbDOs4sF6h+LARnpc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1VFGCQdk52f/X9Iv74LJxqAka2VT28u3zmdxpiEcGaFA1KSTvahmv6FoG5cWKYNkk QelW+iJfZSEjhHeD/RYfHnKvruH2KbLArYh2CrtyVdsKHdtNPefUwZnyrpLLgcLJUN DjYsDkh0K2xdFHPW5Koi+Jb9dl2iybUGSC0RDEis= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Liang He , Hans Verkuil , Sasha Levin Subject: [PATCH 4.14 112/338] media: c8sectpfe: Add of_node_put() when breaking out of loop Date: Mon, 16 Jan 2023 16:49:45 +0100 Message-Id: <20230116154825.735432053@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230116154820.689115727@linuxfoundation.org> References: <20230116154820.689115727@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Liang He [ Upstream commit 63ff05a1ad242a5a0f897921c87b70d601bda59c ] In configure_channels(), we should call of_node_put() when breaking out of for_each_child_of_node() which will automatically increase and decrease the refcount. Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support") Signed-off-by: Liang He Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c index 23d0cedf4d9d..f42289f9e8c5 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c @@ -947,6 +947,7 @@ static int configure_channels(struct c8sectpfei *fei) if (ret) { dev_err(fei->dev, "configure_memdma_and_inputblock failed\n"); + of_node_put(child); goto err_unmap; } index++; -- 2.35.1