From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D5D146B5 for ; Mon, 16 Jan 2023 16:16:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5457C433D2; Mon, 16 Jan 2023 16:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673885811; bh=tgR7OvLV+g+3+gYNLgvaTK5iiiyqtWCvY4T0Zyk6PPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x1tLk9WxgSnzaVYu5fZWq6lk55apMHBwBHolhzKKBys+9ytAmCkkvX6GtFOmsOWp6 aOUZF18Kr2Qb35Iq8/pUdl9CcF2MMXpLfsrggb7n8PIcT0RQqAp1ttyuCbk+KcC3br AKaccuZBCwm2PWt+9W0Oh8mYWzu/xedBRSNFwk8k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, ZhangPeng , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 153/658] pinctrl: pinconf-generic: add missing of_node_put() Date: Mon, 16 Jan 2023 16:44:01 +0100 Message-Id: <20230116154916.443807468@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230116154909.645460653@linuxfoundation.org> References: <20230116154909.645460653@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: ZhangPeng [ Upstream commit 5ead93289815a075d43c415e35c8beafafb801c9 ] of_node_put() needs to be called when jumping out of the loop, since for_each_available_child_of_node() will increase the refcount of node. Fixes: c7289500e29d ("pinctrl: pinconf-generic: scan also referenced phandle node") Signed-off-by: ZhangPeng Link: https://lore.kernel.org/r/20221125070156.3535855-1-zhangpeng362@huawei.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinconf-generic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index 355bc4c748e2..02c015577cf9 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -391,8 +391,10 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *pctldev, for_each_available_child_of_node(np_config, np) { ret = pinconf_generic_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps, type); - if (ret < 0) + if (ret < 0) { + of_node_put(np); goto exit; + } } return 0; -- 2.35.1