* drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]
@ 2023-01-16 11:24 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-01-16 11:24 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Haijun Liu <haijun.liu@mediatek.com>
CC: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
CC: Ricardo Martinez <ricardo.martinez@linux.intel.com>
CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5dc4c995db9eb45f6373a956eb1f69460e69e6d4
commit: 46e8f49ed7b3063f51e28f3ea2084b3da29c1503 net: wwan: t7xx: Introduce power management
date: 8 months ago
:::::: branch date: 20 hours ago
:::::: commit date: 8 months ago
compiler: csky-linux-gcc (GCC) 12.1.0
reproduce (cppcheck warning):
# apt-get install cppcheck
git checkout 46e8f49ed7b3063f51e28f3ea2084b3da29c1503
cppcheck --quiet --enable=style,performance,portability --template=gcc FILE
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]
if (entity->id == pm_entity->id) {
^
drivers/net/wwan/t7xx/t7xx_pci.c:141:15: warning: Uninitialized variable: entity->id [uninitvar]
if (entity->id == pm_entity->id) {
^
>> drivers/net/wwan/t7xx/t7xx_pci.c:382:15: warning: Uninitialized variable: entity->resume_early [uninitvar]
if (entity->resume_early)
^
drivers/net/wwan/t7xx/t7xx_pci.c:309:42: note: Assuming condition is false
if (atomic_read(&t7xx_dev->md_pm_state) <= MTK_PM_INIT) {
^
drivers/net/wwan/t7xx/t7xx_pci.c:382:15: note: Uninitialized variable: entity->resume_early
if (entity->resume_early)
^
vim +124 drivers/net/wwan/t7xx/t7xx_pci.c
46e8f49ed7b306 Haijun Liu 2022-05-06 117
46e8f49ed7b306 Haijun Liu 2022-05-06 118 int t7xx_pci_pm_entity_register(struct t7xx_pci_dev *t7xx_dev, struct md_pm_entity *pm_entity)
46e8f49ed7b306 Haijun Liu 2022-05-06 119 {
46e8f49ed7b306 Haijun Liu 2022-05-06 120 struct md_pm_entity *entity;
46e8f49ed7b306 Haijun Liu 2022-05-06 121
46e8f49ed7b306 Haijun Liu 2022-05-06 122 mutex_lock(&t7xx_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06 123 list_for_each_entry(entity, &t7xx_dev->md_pm_entities, entity) {
46e8f49ed7b306 Haijun Liu 2022-05-06 @124 if (entity->id == pm_entity->id) {
46e8f49ed7b306 Haijun Liu 2022-05-06 125 mutex_unlock(&t7xx_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06 126 return -EEXIST;
46e8f49ed7b306 Haijun Liu 2022-05-06 127 }
46e8f49ed7b306 Haijun Liu 2022-05-06 128 }
46e8f49ed7b306 Haijun Liu 2022-05-06 129
46e8f49ed7b306 Haijun Liu 2022-05-06 130 list_add_tail(&pm_entity->entity, &t7xx_dev->md_pm_entities);
46e8f49ed7b306 Haijun Liu 2022-05-06 131 mutex_unlock(&t7xx_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06 132 return 0;
46e8f49ed7b306 Haijun Liu 2022-05-06 133 }
46e8f49ed7b306 Haijun Liu 2022-05-06 134
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 2+ messages in thread* drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]
@ 2022-08-21 7:32 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-08-21 7:32 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4433 bytes --]
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]"
::::::
BCC: lkp(a)intel.com
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Haijun Liu <haijun.liu@mediatek.com>
CC: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
CC: Ricardo Martinez <ricardo.martinez@linux.intel.com>
CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 15b3f48a4339e3c16acf18624e2b7f60bc5e9a2c
commit: 46e8f49ed7b3063f51e28f3ea2084b3da29c1503 net: wwan: t7xx: Introduce power management
date: 3 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 3 months ago
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (cppcheck warning):
# apt-get install cppcheck
git checkout 46e8f49ed7b3063f51e28f3ea2084b3da29c1503
cppcheck --quiet --enable=style,performance,portability --template=gcc FILE
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar]
if (entity->id == pm_entity->id) {
^
drivers/net/wwan/t7xx/t7xx_pci.c:141:15: warning: Uninitialized variable: entity->id [uninitvar]
if (entity->id == pm_entity->id) {
^
>> drivers/net/wwan/t7xx/t7xx_pci.c:382:15: warning: Uninitialized variable: entity->resume_early [uninitvar]
if (entity->resume_early)
^
drivers/net/wwan/t7xx/t7xx_pci.c:309:42: note: Assuming condition is false
if (atomic_read(&t7xx_dev->md_pm_state) <= MTK_PM_INIT) {
^
drivers/net/wwan/t7xx/t7xx_pci.c:382:15: note: Uninitialized variable: entity->resume_early
if (entity->resume_early)
^
--
>> drivers/net/wwan/t7xx/t7xx_port_proxy.c:325:33: warning: Uninitialized variable: port_conf [uninitvar]
if (queue->md_ctrl->hif_id == port_conf->path_id &&
^
drivers/net/wwan/t7xx/t7xx_port_proxy.c:323:48: note: Assignment 'port_conf=port->port_conf', assigned value is <Uninit>
const struct t7xx_port_conf *port_conf = port->port_conf;
^
drivers/net/wwan/t7xx/t7xx_port_proxy.c:325:33: note: Uninitialized variable: port_conf
if (queue->md_ctrl->hif_id == port_conf->path_id &&
^
>> drivers/net/wwan/t7xx/t7xx_port_proxy.c:327:11: warning: Uninitialized variables: port.port_conf, port.wwan_port, port.t7xx_dev, port.dev, port.usage_cnt, port.entry, port.queue_entry, port.rx_skb_list, port.port_update_lock, port.rx_wq, port.rx_length_th, port.chan_enable, port.thread [uninitvar]
return port;
^
vim +124 drivers/net/wwan/t7xx/t7xx_pci.c
46e8f49ed7b306 Haijun Liu 2022-05-06 117
46e8f49ed7b306 Haijun Liu 2022-05-06 118 int t7xx_pci_pm_entity_register(struct t7xx_pci_dev *t7xx_dev, struct md_pm_entity *pm_entity)
46e8f49ed7b306 Haijun Liu 2022-05-06 119 {
46e8f49ed7b306 Haijun Liu 2022-05-06 120 struct md_pm_entity *entity;
46e8f49ed7b306 Haijun Liu 2022-05-06 121
46e8f49ed7b306 Haijun Liu 2022-05-06 122 mutex_lock(&t7xx_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06 123 list_for_each_entry(entity, &t7xx_dev->md_pm_entities, entity) {
46e8f49ed7b306 Haijun Liu 2022-05-06 @124 if (entity->id == pm_entity->id) {
46e8f49ed7b306 Haijun Liu 2022-05-06 125 mutex_unlock(&t7xx_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06 126 return -EEXIST;
46e8f49ed7b306 Haijun Liu 2022-05-06 127 }
46e8f49ed7b306 Haijun Liu 2022-05-06 128 }
46e8f49ed7b306 Haijun Liu 2022-05-06 129
46e8f49ed7b306 Haijun Liu 2022-05-06 130 list_add_tail(&pm_entity->entity, &t7xx_dev->md_pm_entities);
46e8f49ed7b306 Haijun Liu 2022-05-06 131 mutex_unlock(&t7xx_dev->md_pm_entity_mtx);
46e8f49ed7b306 Haijun Liu 2022-05-06 132 return 0;
46e8f49ed7b306 Haijun Liu 2022-05-06 133 }
46e8f49ed7b306 Haijun Liu 2022-05-06 134
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-16 11:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-16 11:24 drivers/net/wwan/t7xx/t7xx_pci.c:124:15: warning: Uninitialized variable: entity->id [uninitvar] kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-08-21 7:32 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.