From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: yegorslists@googlemail.com
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/util-linux: add an option to enable irqtop
Date: Mon, 16 Jan 2023 22:24:44 +0100 [thread overview]
Message-ID: <20230116212444.GH2770@scaer> (raw)
In-Reply-To: <20230116080513.21407-1-yegorslists@googlemail.com>
Yegor, All,
On 2023-01-16 09:05 +0100, yegorslists--- via buildroot spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> irqtop is an IRQ monitoring tool.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/util-linux/Config.in | 7 +++++++
> package/util-linux/util-linux.mk | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
> index 917f1bc2b4..c7e4d2d8bc 100644
> --- a/package/util-linux/Config.in
> +++ b/package/util-linux/Config.in
> @@ -161,6 +161,13 @@ config BR2_PACKAGE_UTIL_LINUX_IPCS
> help
> Show information on IPC facilities
>
> +config BR2_PACKAGE_UTIL_LINUX_IRQTOP
> + bool "irqtop"
> + depends on BR2_USE_MMU # libsmartcols
> + select BR2_PACKAGE_UTIL_LINUX_LIBSMARTCOLS
I was about to apply this, but I am a bit conflicted... Building irqtop
defaults to 'yes' for linux systems, when --disable-irqtop is not
specified (unless I misread util-linux' configure.ac).
So, today we are providing neither --enable-irqtop nor --disable-irqtop,
which means that it is in practice always built.
But with your change, it means that now it is by default disabled.
So I wanted to add 'default y' for legacy reasons, but we have no other
option in util-linux that defaults to 'y', so it would have been a bit
odd to do so...
Or maybe I am just too tired to think straight...
Thoughts?
Regards,
Yann E. MORIN.
> + help
> + Show information on IRQs
> +
> config BR2_PACKAGE_UTIL_LINUX_KILL
> bool "kill"
> help
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index b53b94ec31..87ec3c19d7 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -136,6 +136,7 @@ UTIL_LINUX_CONF_OPTS += \
> $(if $(BR2_PACKAGE_UTIL_LINUX_IPCMK),--enable-ipcmk,--disable-ipcmk) \
> $(if $(BR2_PACKAGE_UTIL_LINUX_IPCRM),--enable-ipcrm,--disable-ipcrm) \
> $(if $(BR2_PACKAGE_UTIL_LINUX_IPCS),--enable-ipcs,--disable-ipcs) \
> + $(if $(BR2_PACKAGE_UTIL_LINUX_IRQTOP),--enable-irqtop,--disable-irqtop) \
> $(if $(BR2_PACKAGE_UTIL_LINUX_KILL),--enable-kill,--disable-kill) \
> $(if $(BR2_PACKAGE_UTIL_LINUX_LAST),--enable-last,--disable-last) \
> $(if $(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),--enable-libblkid,--disable-libblkid) \
> --
> 2.17.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-01-16 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 8:05 [Buildroot] [PATCH] package/util-linux: add an option to enable irqtop yegorslists--- via buildroot
2023-01-16 21:24 ` Yann E. MORIN [this message]
2023-01-17 7:57 ` Yegor Yefremov via buildroot
2023-01-18 20:33 ` Yann E. MORIN
2023-01-23 8:44 ` Yegor Yefremov via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116212444.GH2770@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.