From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, lkp@intel.com,
senozhatsky@chromium.org, akpm@linux-foundation.org
Subject: [to-be-updated] zsmalloc-make-zspage-chain-size-configurable-fix.patch removed from -mm tree
Date: Mon, 16 Jan 2023 13:39:15 -0800 [thread overview]
Message-ID: <20230116213916.7D695C433F1@smtp.kernel.org> (raw)
The quilt patch titled
Subject: zsmalloc: turn chain size config option into UL constant
has been removed from the -mm tree. Its filename was
zsmalloc-make-zspage-chain-size-configurable-fix.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
From: Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: zsmalloc: turn chain size config option into UL constant
Date: Thu, 12 Jan 2023 16:14:43 +0900
This fixes
>> mm/zsmalloc.c:122:59: warning: right shift count >= width of type [-Wshift-count-overflow]
and
>> mm/zsmalloc.c:224:28: error: variably modified 'size_class' at file scope
224 | struct size_class *size_class[ZS_SIZE_CLASSES];
Link: https://lkml.kernel.org/r/20230112071443.1933880-1-senozhatsky@chromium.org
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/mm/zsmalloc.c~zsmalloc-make-zspage-chain-size-configurable-fix
+++ a/mm/zsmalloc.c
@@ -133,9 +133,12 @@
#define MAGIC_VAL_BITS 8
#define MAX(a, b) ((a) >= (b) ? (a) : (b))
+
+#define ZS_MAX_PAGES_PER_ZSPAGE (_AC(CONFIG_ZSMALLOC_CHAIN_SIZE, UL))
+
/* ZS_MIN_ALLOC_SIZE must be multiple of ZS_ALIGN */
#define ZS_MIN_ALLOC_SIZE \
- MAX(32, (CONFIG_ZSMALLOC_CHAIN_SIZE << PAGE_SHIFT >> OBJ_INDEX_BITS))
+ MAX(32, (ZS_MAX_PAGES_PER_ZSPAGE << PAGE_SHIFT >> OBJ_INDEX_BITS))
/* each chunk includes extra space to keep handle */
#define ZS_MAX_ALLOC_SIZE PAGE_SIZE
@@ -1119,7 +1122,7 @@ static struct zspage *alloc_zspage(struc
gfp_t gfp)
{
int i;
- struct page *pages[CONFIG_ZSMALLOC_CHAIN_SIZE];
+ struct page *pages[ZS_MAX_PAGES_PER_ZSPAGE];
struct zspage *zspage = cache_alloc_zspage(pool, gfp);
if (!zspage)
@@ -1986,7 +1989,7 @@ static void replace_sub_page(struct size
struct page *newpage, struct page *oldpage)
{
struct page *page;
- struct page *pages[CONFIG_ZSMALLOC_CHAIN_SIZE] = {NULL, };
+ struct page *pages[ZS_MAX_PAGES_PER_ZSPAGE] = {NULL, };
int idx = 0;
page = get_first_page(zspage);
@@ -2366,7 +2369,7 @@ static int calculate_zspage_chain_size(i
if (is_power_of_2(class_size))
return chain_size;
- for (i = 1; i <= CONFIG_ZSMALLOC_CHAIN_SIZE; i++) {
+ for (i = 1; i <= ZS_MAX_PAGES_PER_ZSPAGE; i++) {
int waste;
waste = (i * PAGE_SIZE) % class_size;
_
Patches currently in -mm which might be from senozhatsky@chromium.org are
zram-correctly-handle-all-next_arg-cases.patch
zsmalloc-set-default-zspage-chain-size-to-8.patch
reply other threads:[~2023-01-16 21:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116213916.7D695C433F1@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mm-commits@vger.kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.