All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: mst@redhat.com
Cc: elic@nvidia.com, Zhu Lingshan <lingshan.zhu@intel.com>,
	Si-Wei Liu <si-wei.liu@oracle.com>,
	qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
	Cindy Lu <lulu@redhat.com>, Gautam Dawar <gdawar@xilinx.com>,
	leiyang@redhat.com
Subject: [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check
Date: Tue, 17 Jan 2023 11:53:08 +0100	[thread overview]
Message-ID: <20230117105308.1337120-1-eperezma@redhat.com> (raw)

VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.

Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
Originally on SUSPEND series, but it is a fix that it is worth to send
and apply individually:
https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg02574.html

---
 net/vhost-vdpa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 1a13a34d35..de5ed8ff22 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -384,7 +384,7 @@ static int vhost_vdpa_net_cvq_start(NetClientState *nc)
             g_strerror(errno), errno);
         return -1;
     }
-    if (!(backend_features & VHOST_BACKEND_F_IOTLB_ASID) ||
+    if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_IOTLB_ASID)) ||
         !vhost_vdpa_net_valid_svq_features(v->dev->features, NULL)) {
         return 0;
     }
--
2.31.1



             reply	other threads:[~2023-01-17 10:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 10:53 Eugenio Pérez [this message]
2023-01-23 13:17 ` [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check Laurent Vivier
2023-01-23 14:39 ` Michael S. Tsirkin
2023-01-29  5:43   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117105308.1337120-1-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=elic@nvidia.com \
    --cc=gdawar@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=si-wei.liu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.