From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8565EC54E76 for ; Tue, 17 Jan 2023 17:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232844AbjAQRPw convert rfc822-to-8bit (ORCPT ); Tue, 17 Jan 2023 12:15:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbjAQRPR (ORCPT ); Tue, 17 Jan 2023 12:15:17 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 160004995F; Tue, 17 Jan 2023 09:14:21 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4NxFl52Jb1z6J6LH; Wed, 18 Jan 2023 01:10:25 +0800 (CST) Received: from localhost (10.45.151.130) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 17 Jan 2023 17:14:19 +0000 Date: Tue, 17 Jan 2023 17:14:17 +0000 From: Jonathan Cameron To: Arnd Bergmann CC: Dmitry Torokhov , Linus Walleij , Arnd Bergmann , , Subject: Re: [PATCH] Input: ipaq-micro-ts - fix DEFINE_SIMPLE_DEV_PM_OPS typo Message-ID: <20230117171417.00002890@Huawei.com> In-Reply-To: <20230117164539.1631336-1-arnd@kernel.org> References: <20230117164539.1631336-1-arnd@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.45.151.130] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, 17 Jan 2023 17:45:33 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > The previous change was not properly build tested and needs > a trivial spelling change: > > ipaq-micro-ts.c:146:8: error: type defaults to 'int' in declaration of 'DEFINE_SIMPLE_DEV_PM' [-Werror=implicit-int] > > Fixes: 144ff5e03d74 ("Input: ipaq-micro-ts - use DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()") > Signed-off-by: Arnd Bergmann Hi Arnd, I clearly messed up my build tests - will look into how that went wrong. >From an initial look, this looks like a driver that could benefit from a || COMPILE_TEST addition to the Kconfig depenencies. Nothing looks to be build time dependent on the related MFD. Thanks for fixing it up. Reviewed-by: Jonathan Cameron > --- > drivers/input/touchscreen/ipaq-micro-ts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/ipaq-micro-ts.c b/drivers/input/touchscreen/ipaq-micro-ts.c > index d8e25b502968..94720c41c9be 100644 > --- a/drivers/input/touchscreen/ipaq-micro-ts.c > +++ b/drivers/input/touchscreen/ipaq-micro-ts.c > @@ -143,8 +143,8 @@ static int micro_ts_resume(struct device *dev) > return 0; > } > > -static DEFINE_SIMPLE_DEV_PM(micro_ts_dev_pm_ops, > - micro_ts_suspend, micro_ts_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(micro_ts_dev_pm_ops, > + micro_ts_suspend, micro_ts_resume); > > static struct platform_driver micro_ts_device_driver = { > .driver = {