From: Rob Herring <robh@kernel.org>
To: "Michał Grzelak" <mchl.grzlk@gmail.com>
Cc: linux-kernel@vger.kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, cosmin.tanislav@analog.com,
jic23@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: addac: adi,74115: Add missing maxItems
Date: Tue, 17 Jan 2023 13:57:23 -0600 [thread overview]
Message-ID: <20230117195723.GA3527095-robh@kernel.org> (raw)
In-Reply-To: <20230115022558.145076-1-mchl.grzlk@gmail.com>
On Sun, Jan 15, 2023 at 03:25:58AM +0100, Michał Grzelak wrote:
> Running 'make dt_binding_check' gives following warnings:
> iio/addac/adi,ad74115.example.dtb:
> addac@0: adi,conv2-range-microvolt: 'oneOf' conditional failed, one must
> be fixed:
> 4282967296 is not one of [-2500000, 0]
> 4282967296 is not one of [-12000000, 0]
> -2500000 was expected
> -104000 was expected
> 625000 was expected
>
> addac@0: Unevaluated properties are not allowed
> ('adi,conv2-range-microvolt' was unexpected)
> From schema: iio/addac/adi,ad74115.yaml
I think your dtschema version is out of date. I don't see this issue.
The issue has to do with signed types and there have been some fixes
related to them.
> As every property with standard suffix has inferred type of array of
> cells, adi,conv2-range-microvolt is required by meta-schemas/cell.yaml
> to have maxItems >= 2. Fix these errors by setting maxItems to 2.
The meta-schemas have nothing to do with warnings in examples. It's like
this: meta-schemas check schemas check examples
>
> Signed-off-by: Michał Grzelak <mchl.grzlk@gmail.com>
> ---
> Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> index 72d2e910f206..cdeb04184f5a 100644
> --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> @@ -87,6 +87,7 @@ properties:
>
> adi,conv2-range-microvolt:
> description: Conversion range for ADC conversion 2.
> + maxItems: 2
> oneOf:
> - items:
> - enum: [-2500000, 0]
> --
> 2.37.3
>
next prev parent reply other threads:[~2023-01-17 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 2:25 [PATCH] dt-bindings: iio: addac: adi,74115: Add missing maxItems Michał Grzelak
2023-01-17 19:57 ` Rob Herring [this message]
2023-01-18 18:11 ` Michał Grzelak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117195723.GA3527095-robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=cosmin.tanislav@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchl.grzlk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.