From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kever.yang@rock-chips.com, sjg@chromium.org,
philipp.tomsich@vrull.eu
Subject: Re: [PATCH v1 1/4] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC
Date: Wed, 18 Jan 2023 09:32:36 -0600 [thread overview]
Message-ID: <20230118153236.GA33699-robh@kernel.org> (raw)
In-Reply-To: <08de3f4b-e33f-95c8-3297-814ea107272a@gmail.com>
On Wed, Jan 18, 2023 at 01:13:23PM +0100, Johan Jonker wrote:
> Currently all Rockchip gpio nodes have the same compatible.
> Replace all the compatibles in gpio nodes to be able to
> give them a consistent ID independent from probe order or alias.
I fail to see how the compatible change affects probe order or aliases.
It is also an ABI break if there is not the existing compatible as a
fallback. State the problem you are trying to solve with this change,
not just what your solution is.
GPIO shouldn't really have an alias either IMO.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kever.yang@rock-chips.com, sjg@chromium.org,
philipp.tomsich@vrull.eu
Subject: Re: [PATCH v1 1/4] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC
Date: Wed, 18 Jan 2023 09:32:36 -0600 [thread overview]
Message-ID: <20230118153236.GA33699-robh@kernel.org> (raw)
In-Reply-To: <08de3f4b-e33f-95c8-3297-814ea107272a@gmail.com>
On Wed, Jan 18, 2023 at 01:13:23PM +0100, Johan Jonker wrote:
> Currently all Rockchip gpio nodes have the same compatible.
> Replace all the compatibles in gpio nodes to be able to
> give them a consistent ID independent from probe order or alias.
I fail to see how the compatible change affects probe order or aliases.
It is also an ABI break if there is not the existing compatible as a
fallback. State the problem you are trying to solve with this change,
not just what your solution is.
GPIO shouldn't really have an alias either IMO.
Rob
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kever.yang@rock-chips.com, sjg@chromium.org,
philipp.tomsich@vrull.eu
Subject: Re: [PATCH v1 1/4] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC
Date: Wed, 18 Jan 2023 09:32:36 -0600 [thread overview]
Message-ID: <20230118153236.GA33699-robh@kernel.org> (raw)
In-Reply-To: <08de3f4b-e33f-95c8-3297-814ea107272a@gmail.com>
On Wed, Jan 18, 2023 at 01:13:23PM +0100, Johan Jonker wrote:
> Currently all Rockchip gpio nodes have the same compatible.
> Replace all the compatibles in gpio nodes to be able to
> give them a consistent ID independent from probe order or alias.
I fail to see how the compatible change affects probe order or aliases.
It is also an ABI break if there is not the existing compatible as a
fallback. State the problem you are trying to solve with this change,
not just what your solution is.
GPIO shouldn't really have an alias either IMO.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-18 15:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 12:13 [PATCH v1 1/4] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC Johan Jonker
2023-01-18 12:13 ` Johan Jonker
2023-01-18 12:13 ` Johan Jonker
2023-01-18 12:14 ` [PATCH v1 2/4] gpio: gpio-rockchip: " Johan Jonker
2023-01-18 12:14 ` Johan Jonker
2023-01-18 12:14 ` Johan Jonker
2023-01-18 14:14 ` Bartosz Golaszewski
2023-01-18 14:14 ` Bartosz Golaszewski
2023-01-18 14:14 ` Bartosz Golaszewski
2023-01-18 15:35 ` Krzysztof Kozlowski
2023-01-18 15:35 ` Krzysztof Kozlowski
2023-01-18 15:35 ` Krzysztof Kozlowski
2023-01-18 12:15 ` [PATCH v1 3/4] ARM: dts: rockchip: replace compatible gpio nodes Johan Jonker
2023-01-18 12:15 ` Johan Jonker
2023-01-18 12:15 ` Johan Jonker
2023-01-18 12:15 ` [PATCH v1 4/4] arm64: " Johan Jonker
2023-01-18 12:15 ` Johan Jonker
2023-01-18 12:15 ` Johan Jonker
2023-01-18 15:32 ` Rob Herring [this message]
2023-01-18 15:32 ` [PATCH v1 1/4] dt-bindings: gpio: rockchip,gpio-bank: add compatible string per SoC Rob Herring
2023-01-18 15:32 ` Rob Herring
2023-01-18 17:12 ` Johan Jonker
2023-01-18 17:12 ` Johan Jonker
2023-01-18 17:12 ` Johan Jonker
2023-01-18 18:32 ` Krzysztof Kozlowski
2023-01-18 18:32 ` Krzysztof Kozlowski
2023-01-18 18:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118153236.GA33699-robh@kernel.org \
--to=robh@kernel.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.