From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: netdev@vger.kernel.org, brouer@redhat.com,
"David S. Miller" <davem@davemloft.net>,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next V2 2/2] net: kfree_skb_list use kmem_cache_free_bulk
Date: Wed, 18 Jan 2023 18:26:00 -0800 [thread overview]
Message-ID: <20230118182600.026c8421@kernel.org> (raw)
In-Reply-To: <6f634864-2937-6e32-ba9d-7fa7f2b576cb@redhat.com>
On Wed, 18 Jan 2023 22:37:47 +0100 Jesper Dangaard Brouer wrote:
> > + skb_mark_not_on_list(segs);
>
> The syzbot[1] bug goes way if I remove this skb_mark_not_on_list().
>
> I don't understand why I cannot clear skb->next here?
Some of the skbs on the list are not private?
IOW we should only unlink them if skb_unref().
next prev parent reply other threads:[~2023-01-19 2:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 13:51 [PATCH net-next V2 0/2] net: use kmem_cache_free_bulk in kfree_skb_list Jesper Dangaard Brouer
2023-01-13 13:51 ` [PATCH net-next V2 1/2] net: fix call location in kfree_skb_list_reason Jesper Dangaard Brouer
2023-01-13 13:52 ` [PATCH net-next V2 2/2] net: kfree_skb_list use kmem_cache_free_bulk Jesper Dangaard Brouer
2023-01-18 16:05 ` Eric Dumazet
2023-01-18 16:42 ` Jesper Dangaard Brouer
2023-01-18 16:42 ` Eric Dumazet
2023-01-18 21:37 ` Jesper Dangaard Brouer
2023-01-19 2:26 ` Jakub Kicinski [this message]
2023-01-19 10:17 ` Jesper Dangaard Brouer
2023-01-19 10:28 ` Eric Dumazet
2023-01-19 11:22 ` Jesper Dangaard Brouer
2023-01-19 11:46 ` Eric Dumazet
2023-01-19 13:18 ` Jesper Dangaard Brouer
2023-01-19 2:39 ` Yunsheng Lin
2023-01-17 9:40 ` [PATCH net-next V2 0/2] net: use kmem_cache_free_bulk in kfree_skb_list patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118182600.026c8421@kernel.org \
--to=kuba@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jbrouer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.