From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/xxhash: set XXH_NO_INLINE_HINTS
Date: Wed, 18 Jan 2023 21:43:12 +0100 [thread overview]
Message-ID: <20230118204312.GL2770@scaer> (raw)
In-Reply-To: <20230118182333.503773-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2023-01-18 19:23 +0100, Fabrice Fontaine spake thusly:
> Set XXH_NO_INLINE_HINTS to marks all internal functions as static,
> giving the compiler full control on whether to inline or not. This will
> fix the following build failure raised since bump to version 0.8.1 in
> commit 5dbdb2535c649ee617595b8c4ae3cbba0ee37b97:
>
> In file included from xxhash.c:43:
> In function 'XXH3_accumulate',
> inlined from 'XXH3_hashLong_internal_loop' at xxhash.h:4390:9,
> inlined from 'XXH3_hashLong_64b_internal' at xxhash.h:4453:5,
> inlined from 'XXH3_hashLong_64b_withSecret' at xxhash.h:4473:12,
> inlined from 'XXH3_64bits_internal' at xxhash.h:4554:12,
> inlined from 'XXH3_64bits_withSecret' at xxhash.h:4570:12:
> xxhash.h:4196:1: error: inlining failed in call to 'always_inline' 'XXH3_accumulate_512_scalar': function not considered for inlining
> 4196 | XXH3_accumulate_512_scalar(void* XXH_RESTRICT acc,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/f2c52238df97cc4c13117d8dc1423235231a094c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/xxhash/xxhash.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/xxhash/xxhash.mk b/package/xxhash/xxhash.mk
> index 04bc98690f..40e3c2696c 100644
> --- a/package/xxhash/xxhash.mk
> +++ b/package/xxhash/xxhash.mk
> @@ -28,6 +28,7 @@ endif
>
> define XXHASH_BUILD_CMDS
> $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> + CFLAGS="$(TARGET_CFLAGS) -DXXH_NO_INLINE_HINTS" \
> $(XXHASH_TARGETS)
> endef
>
> --
> 2.39.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-01-18 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 18:23 [Buildroot] [PATCH 1/1] package/xxhash: set XXH_NO_INLINE_HINTS Fabrice Fontaine
2023-01-18 20:43 ` Yann E. MORIN [this message]
2023-01-29 21:04 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118204312.GL2770@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.