From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings
Date: Thu, 19 Jan 2023 00:50:08 +0800 [thread overview]
Message-ID: <202301190004.9AzNXacp-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230118061256.2689-4-dakr@redhat.com>
References: <20230118061256.2689-4-dakr@redhat.com>
TO: Danilo Krummrich <dakr@redhat.com>
TO: daniel@ffwll.ch
TO: airlied@redhat.com
TO: christian.koenig@amd.com
TO: bskeggs@redhat.com
TO: jason@jlekstrand.net
TO: tzimmermann@suse.de
TO: mripard@kernel.org
TO: corbet@lwn.net
CC: nouveau@lists.freedesktop.org
CC: Danilo Krummrich <dakr@redhat.com>
CC: linux-kernel@vger.kernel.org
CC: dri-devel@lists.freedesktop.org
CC: linux-doc@vger.kernel.org
Hi Danilo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 0b45ac1170ea6416bc1d36798414c04870cd356d]
url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers/20230118-141552
base: 0b45ac1170ea6416bc1d36798414c04870cd356d
patch link: https://lore.kernel.org/r/20230118061256.2689-4-dakr%40redhat.com
patch subject: [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: i386-randconfig-m021-20230116 (https://download.01.org/0day-ci/archive/20230119/202301190004.9AzNXacp-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/gpu/drm/drm_gpuva_mgr.c:739 drm_gpuva_region_destroy() warn: ignoring unreachable code.
vim +739 drivers/gpu/drm/drm_gpuva_mgr.c
fffbb2141e3b96 Danilo Krummrich 2023-01-18 725
fffbb2141e3b96 Danilo Krummrich 2023-01-18 726 /**
fffbb2141e3b96 Danilo Krummrich 2023-01-18 727 * drm_gpuva_region_destroy - destroy a &drm_gpuva_region
fffbb2141e3b96 Danilo Krummrich 2023-01-18 728 * @mgr: the &drm_gpuva_manager holding the region
fffbb2141e3b96 Danilo Krummrich 2023-01-18 729 * @reg: the &drm_gpuva to destroy
fffbb2141e3b96 Danilo Krummrich 2023-01-18 730 *
fffbb2141e3b96 Danilo Krummrich 2023-01-18 731 * This removes the given ® from the underlaying range allocator.
fffbb2141e3b96 Danilo Krummrich 2023-01-18 732 */
fffbb2141e3b96 Danilo Krummrich 2023-01-18 733 void
fffbb2141e3b96 Danilo Krummrich 2023-01-18 734 drm_gpuva_region_destroy(struct drm_gpuva_manager *mgr,
fffbb2141e3b96 Danilo Krummrich 2023-01-18 735 struct drm_gpuva_region *reg)
fffbb2141e3b96 Danilo Krummrich 2023-01-18 736 {
fffbb2141e3b96 Danilo Krummrich 2023-01-18 737 struct drm_gpuva *va;
fffbb2141e3b96 Danilo Krummrich 2023-01-18 738
fffbb2141e3b96 Danilo Krummrich 2023-01-18 @739 drm_gpuva_for_each_va_in_range(va, mgr,
fffbb2141e3b96 Danilo Krummrich 2023-01-18 740 reg->node.start,
fffbb2141e3b96 Danilo Krummrich 2023-01-18 741 reg->node.size) {
fffbb2141e3b96 Danilo Krummrich 2023-01-18 742 WARN(1, "GPU VA region must be empty on destroy.\n");
fffbb2141e3b96 Danilo Krummrich 2023-01-18 743 return;
fffbb2141e3b96 Danilo Krummrich 2023-01-18 744 }
fffbb2141e3b96 Danilo Krummrich 2023-01-18 745
fffbb2141e3b96 Danilo Krummrich 2023-01-18 746 if (®->node == &mgr->kernel_alloc_node) {
fffbb2141e3b96 Danilo Krummrich 2023-01-18 747 WARN(1, "Can't destroy kernel reserved region.\n");
fffbb2141e3b96 Danilo Krummrich 2023-01-18 748 return;
fffbb2141e3b96 Danilo Krummrich 2023-01-18 749 }
fffbb2141e3b96 Danilo Krummrich 2023-01-18 750
fffbb2141e3b96 Danilo Krummrich 2023-01-18 751 drm_mm_remove_node(®->node);
fffbb2141e3b96 Danilo Krummrich 2023-01-18 752 }
fffbb2141e3b96 Danilo Krummrich 2023-01-18 753 EXPORT_SYMBOL(drm_gpuva_region_destroy);
fffbb2141e3b96 Danilo Krummrich 2023-01-18 754
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-01-18 16:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 16:50 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-18 6:12 [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-19 4:14 ` Bagas Sanjaya
2023-01-19 4:14 ` Bagas Sanjaya
2023-01-20 18:32 ` Danilo Krummrich
2023-01-23 23:23 ` Niranjana Vishwanathapura
2023-01-23 23:23 ` Niranjana Vishwanathapura
2023-01-24 0:11 ` Danilo Krummrich
2023-01-24 17:26 ` Niranjana Vishwanathapura
2023-01-26 23:43 ` Matthew Brost
2023-01-26 23:43 ` Matthew Brost
2023-01-27 0:24 ` Matthew Brost
2023-01-27 0:24 ` Matthew Brost
2023-01-28 1:51 ` Danilo Krummrich
2023-02-03 17:37 ` Matthew Brost
2023-02-03 17:37 ` Matthew Brost
2023-02-06 13:35 ` Christian König
2023-02-06 13:35 ` Christian König
2023-02-06 13:46 ` Danilo Krummrich
2023-02-06 13:46 ` Danilo Krummrich
2023-02-14 11:52 ` Danilo Krummrich
2023-02-14 11:52 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301190004.9AzNXacp-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.