From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:907:c68a:b0:84d:2074:29bb with SMTP id ue10csp1184686ejc; Fri, 20 Jan 2023 07:55:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXuxqoUKFAMh6miJr3/s+4u++9LgYjubZPaaHatJ88HKpxcbj+c17frzlrXypqdNXWdBKa9+ X-Received: by 2002:a05:6214:21a8:b0:534:a662:81b2 with SMTP id t8-20020a05621421a800b00534a66281b2mr29766375qvc.19.1674230135496; Fri, 20 Jan 2023 07:55:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674230135; cv=none; d=google.com; s=arc-20160816; b=QzguNF84zy0paag8q6Yy4NRP53xmCIb7YY9lKrrKjawLYdpFCmfvJcKaXGBqz2Grj5 2IyGRy+FFdWgqDS2H+JODwhstBmGsMj5U91Hkmtrg0DiJPlp6ltcXEOIDsKQIVErHXPU MA7YswAbJe167Q4B70fsnHz4KmHFvh65ZjPQ24TxlJhLa/TGZHTR689aL2uWTzzZkO3h 4ZasLfsppuoZEDli/vksZreLjQPTr0KddbHR+Sc/tzlbGIV1HZ4tchlCsAYilsBQ39WY ZNyl8SwCrvc/4daeHjYu4DQNXWlosLDooGUfCMbL7MXbQ3YTMZA/dEf8d7mYLRtXpdy7 wRfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter; bh=hA6UjCPH/KZisJeGGi0Pj05GPCIl4DXwLpG8cQ7M3eA=; b=QletOOd3mMTKrT/VdwL6D6++LEN3J3V4jPTGHrFGDN1x/P5iRIUpSMYv+BeWVgr2Yf WXEPkf6Er71U8hK3kbCw5ObpKlnN5cgR5aZfK7dY/jOsS7mWJ7Bbmb/P8OWW8AUBrdIq a3qClHXl6okjLvyVB19nYKUn/HbEcXvApyCMn0n8/Ve16pdF1tP+dj5yyPFRm5HD1DN9 kWUOttlcb2eltn2g6XgR1ZAv1wGB2/Go+BxBctmRSARcOIAsZKfgCfzOvAoAA/xwf2Ue YQJ+MNKlMUerlW6iA7BhRWg0PzyDOEbQURXJHcmZ7lkgEJd69tkZYJmbj9W69krfqLx6 FMEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=IyTfda6i; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u8-20020ad45aa8000000b005347cdcbb88si15248876qvg.349.2023.01.20.07.55.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Jan 2023 07:55:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=IyTfda6i; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pItjK-0004bB-TB; Fri, 20 Jan 2023 10:55:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pItjH-0004ZX-Rm; Fri, 20 Jan 2023 10:54:59 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pItjG-00069b-Ee; Fri, 20 Jan 2023 10:54:59 -0500 Received: from localhost.localdomain (unknown [77.64.253.186]) by linux.microsoft.com (Postfix) with ESMTPSA id DEEA620E1A54; Fri, 20 Jan 2023 07:54:55 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DEEA620E1A54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674230096; bh=hA6UjCPH/KZisJeGGi0Pj05GPCIl4DXwLpG8cQ7M3eA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IyTfda6i2/pKpCR0Utb/t1/7A+F1PdI8fIRQt/j8sZwa4oNs934QNaOLU1mRCPnBt t3XsnOwucn1SxeboqTVQDESTHy/WPp/p/WVT7TcmyFBSGudASZfDJ3kdSvEwOHjtxm MtvT31xuXlpQ9bgo7XnR2BBH0zgo7fQ5tlW/PuHY= From: Evgeny Iakovlev To: qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v3 3/5] hw/char/pl011: implement a reset method Date: Fri, 20 Jan 2023 16:54:45 +0100 Message-Id: <20230120155447.31702-4-eiakovlev@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230120155447.31702-1-eiakovlev@linux.microsoft.com> References: <20230120155447.31702-1-eiakovlev@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=13.77.154.182; envelope-from=eiakovlev@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -197 X-Spam_score: -19.8 X-Spam_bar: ------------------- X-Spam_report: (-19.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: MVWydTYbu3zg PL011 currently lacks a reset method. Implement it. Signed-off-by: Evgeny Iakovlev --- hw/char/pl011.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 4df649a064..f9413f3703 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -427,11 +427,6 @@ static void pl011_init(Object *obj) s->clk = qdev_init_clock_in(DEVICE(obj), "clk", pl011_clock_update, s, ClockUpdate); - s->read_trigger = 1; - s->ifl = 0x12; - s->cr = 0x300; - s->flags = 0x90; - s->id = pl011_id_arm; } @@ -443,11 +438,32 @@ static void pl011_realize(DeviceState *dev, Error **errp) pl011_event, NULL, s, NULL, true); } +static void pl011_reset(DeviceState *dev) +{ + PL011State *s = PL011(dev); + + s->lcr = 0; + s->rsr = 0; + s->dmacr = 0; + s->int_enabled = 0; + s->int_level = 0; + s->ilpr = 0; + s->ibrd = 0; + s->fbrd = 0; + s->read_pos = 0; + s->read_count = 0; + s->read_trigger = 1; + s->ifl = 0x12; + s->cr = 0x300; + s->flags = 0x90; +} + static void pl011_class_init(ObjectClass *oc, void *data) { DeviceClass *dc = DEVICE_CLASS(oc); dc->realize = pl011_realize; + dc->reset = pl011_reset; dc->vmsd = &vmstate_pl011; device_class_set_props(dc, pl011_properties); } -- 2.34.1