From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v4] ucsi_ccg: Refine the UCSI Interrupt handling
Date: Sat, 21 Jan 2023 05:21:08 +0800 [thread overview]
Message-ID: <202301210542.DHRnbwpr-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230118061523.1537992-1-haotienh@nvidia.com>
References: <20230118061523.1537992-1-haotienh@nvidia.com>
TO: Haotien Hsu <haotienh@nvidia.com>
TO: Heikki Krogerus <heikki.krogerus@linux.intel.com>
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: "Sing-Han Chen" <singhanc@nvidia.com>
CC: Sanket Goswami <Sanket.Goswami@amd.com>
CC: Wayne Chang <waynec@nvidia.com>
CC: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
CC: Jonathan Hunter <jonathanh@nvidia.com>
CC: linux-usb@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Haotien Hsu <haotienh@nvidia.com>
Hi Haotien,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.2-rc4 next-20230120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Haotien-Hsu/ucsi_ccg-Refine-the-UCSI-Interrupt-handling/20230118-143008
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20230118061523.1537992-1-haotienh%40nvidia.com
patch subject: [PATCH v4] ucsi_ccg: Refine the UCSI Interrupt handling
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: ia64-randconfig-m041-20230119 (https://download.01.org/0day-ci/archive/20230121/202301210542.DHRnbwpr-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/usb/typec/ucsi/ucsi_ccg.c:712 ccg_irq_handler() error: uninitialized symbol 'cci'.
vim +/cci +712 drivers/usb/typec/ucsi/ucsi_ccg.c
247c554a14aa16 Ajay Gupta 2018-10-26 678
247c554a14aa16 Ajay Gupta 2018-10-26 679 static irqreturn_t ccg_irq_handler(int irq, void *data)
247c554a14aa16 Ajay Gupta 2018-10-26 680 {
e32fd989ac1c45 Heikki Krogerus 2019-11-04 681 u16 reg = CCGX_RAB_UCSI_DATA_BLOCK(UCSI_CCI);
247c554a14aa16 Ajay Gupta 2018-10-26 682 struct ucsi_ccg *uc = data;
e32fd989ac1c45 Heikki Krogerus 2019-11-04 683 u8 intr_reg;
e32fd989ac1c45 Heikki Krogerus 2019-11-04 684 u32 cci;
d0e0298af0ae5b Sing-Han Chen 2023-01-18 685 int ret = 0;
e32fd989ac1c45 Heikki Krogerus 2019-11-04 686
e32fd989ac1c45 Heikki Krogerus 2019-11-04 687 ret = ccg_read(uc, CCGX_RAB_INTR_REG, &intr_reg, sizeof(intr_reg));
e32fd989ac1c45 Heikki Krogerus 2019-11-04 688 if (ret)
e32fd989ac1c45 Heikki Krogerus 2019-11-04 689 return ret;
e32fd989ac1c45 Heikki Krogerus 2019-11-04 690
d0e0298af0ae5b Sing-Han Chen 2023-01-18 691 if (!intr_reg)
d0e0298af0ae5b Sing-Han Chen 2023-01-18 692 return IRQ_HANDLED;
d0e0298af0ae5b Sing-Han Chen 2023-01-18 693 else if (!(intr_reg & UCSI_READ_INT))
d0e0298af0ae5b Sing-Han Chen 2023-01-18 694 goto err_clear_irq;
d0e0298af0ae5b Sing-Han Chen 2023-01-18 695
e32fd989ac1c45 Heikki Krogerus 2019-11-04 696 ret = ccg_read(uc, reg, (void *)&cci, sizeof(cci));
e32fd989ac1c45 Heikki Krogerus 2019-11-04 697 if (ret)
e32fd989ac1c45 Heikki Krogerus 2019-11-04 698 goto err_clear_irq;
e32fd989ac1c45 Heikki Krogerus 2019-11-04 699
e32fd989ac1c45 Heikki Krogerus 2019-11-04 700 if (UCSI_CCI_CONNECTOR(cci))
e32fd989ac1c45 Heikki Krogerus 2019-11-04 701 ucsi_connector_change(uc->ucsi, UCSI_CCI_CONNECTOR(cci));
247c554a14aa16 Ajay Gupta 2018-10-26 702
d0e0298af0ae5b Sing-Han Chen 2023-01-18 703 /* As per CCGx UCSI interface guide, copy CCI and MESSAGE_IN
d0e0298af0ae5b Sing-Han Chen 2023-01-18 704 * to the OpRegion before clear the UCSI interrupt
d0e0298af0ae5b Sing-Han Chen 2023-01-18 705 */
d0e0298af0ae5b Sing-Han Chen 2023-01-18 706 ccg_op_region_update(uc, cci);
e32fd989ac1c45 Heikki Krogerus 2019-11-04 707
e32fd989ac1c45 Heikki Krogerus 2019-11-04 708 err_clear_irq:
e32fd989ac1c45 Heikki Krogerus 2019-11-04 709 ccg_write(uc, CCGX_RAB_INTR_REG, &intr_reg, sizeof(intr_reg));
247c554a14aa16 Ajay Gupta 2018-10-26 710
d0e0298af0ae5b Sing-Han Chen 2023-01-18 711 if (!ret && test_bit(DEV_CMD_PENDING, &uc->flags) &&
d0e0298af0ae5b Sing-Han Chen 2023-01-18 @712 cci & (UCSI_CCI_ACK_COMPLETE | UCSI_CCI_COMMAND_COMPLETE))
d0e0298af0ae5b Sing-Han Chen 2023-01-18 713 complete(&uc->complete);
d0e0298af0ae5b Sing-Han Chen 2023-01-18 714
247c554a14aa16 Ajay Gupta 2018-10-26 715 return IRQ_HANDLED;
247c554a14aa16 Ajay Gupta 2018-10-26 716 }
247c554a14aa16 Ajay Gupta 2018-10-26 717
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-01-20 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 21:21 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-18 6:15 [PATCH v4] ucsi_ccg: Refine the UCSI Interrupt handling Haotien Hsu
2023-01-19 12:28 ` Greg Kroah-Hartman
2023-01-31 6:29 ` Haotien Hsu
2023-01-31 6:40 ` Greg Kroah-Hartman
2023-02-21 16:40 ` Jon Hunter
2023-02-21 16:59 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301210542.DHRnbwpr-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.