* [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
@ 2023-01-21 7:37 ` Asahi Lina
0 siblings, 0 replies; 11+ messages in thread
From: Asahi Lina @ 2023-01-21 7:37 UTC (permalink / raw)
To: Hector Martin, Sven Peter
Cc: Alyssa Rosenzweig, asahi, linux-arm-kernel, linux-kernel,
Asahi Lina
When the coprocessor crashes, it's useful to get a proper register dump
so we can find out what the firmware was doing. Add a decoder for this.
Originally this had ESR decoding by reusing the ARM64 arch header for
this, but that introduces some module linking and cross-arch compilation
issues, so let's leave that out for now.
Signed-off-by: Asahi Lina <lina@asahilina.net>
---
drivers/soc/apple/rtkit-crashlog.c | 83 ++++++++++++++++++++++++++++++
1 file changed, 83 insertions(+)
diff --git a/drivers/soc/apple/rtkit-crashlog.c b/drivers/soc/apple/rtkit-crashlog.c
index 732deed64660..e29ef0a80ab8 100644
--- a/drivers/soc/apple/rtkit-crashlog.c
+++ b/drivers/soc/apple/rtkit-crashlog.c
@@ -13,6 +13,7 @@
#define APPLE_RTKIT_CRASHLOG_VERSION FOURCC('C', 'v', 'e', 'r')
#define APPLE_RTKIT_CRASHLOG_MBOX FOURCC('C', 'm', 'b', 'x')
#define APPLE_RTKIT_CRASHLOG_TIME FOURCC('C', 't', 'i', 'm')
+#define APPLE_RTKIT_CRASHLOG_REGS FOURCC('C', 'r', 'g', '8')
struct apple_rtkit_crashlog_header {
u32 fourcc;
@@ -31,6 +32,24 @@ struct apple_rtkit_crashlog_mbox_entry {
};
static_assert(sizeof(struct apple_rtkit_crashlog_mbox_entry) == 0x18);
+struct apple_rtkit_crashlog_regs {
+ u32 unk_0;
+ u32 unk_4;
+ u64 regs[31];
+ u64 sp;
+ u64 pc;
+ u64 psr;
+ u64 cpacr;
+ u64 fpsr;
+ u64 fpcr;
+ u64 unk[64];
+ u64 far;
+ u64 unk_X;
+ u64 esr;
+ u64 unk_Z;
+};
+static_assert(sizeof(struct apple_rtkit_crashlog_regs) == 0x350);
+
static void apple_rtkit_crashlog_dump_str(struct apple_rtkit *rtk, u8 *bfr,
size_t size)
{
@@ -94,6 +113,66 @@ static void apple_rtkit_crashlog_dump_mailbox(struct apple_rtkit *rtk, u8 *bfr,
}
}
+static void apple_rtkit_crashlog_dump_regs(struct apple_rtkit *rtk, u8 *bfr,
+ size_t size)
+{
+ struct apple_rtkit_crashlog_regs regs;
+ const char *el;
+ int i;
+
+ if (size < sizeof(regs)) {
+ dev_warn(rtk->dev, "RTKit: Regs section too small: 0x%lx", size);
+ return;
+ }
+
+ memcpy(®s, bfr, sizeof(regs));
+
+ switch (regs.psr & PSR_MODE_MASK) {
+ case PSR_MODE_EL0t:
+ el = "EL0t";
+ break;
+ case PSR_MODE_EL1t:
+ el = "EL1t";
+ break;
+ case PSR_MODE_EL1h:
+ el = "EL1h";
+ break;
+ case PSR_MODE_EL2t:
+ el = "EL2t";
+ break;
+ case PSR_MODE_EL2h:
+ el = "EL2h";
+ break;
+ default:
+ el = "unknown";
+ break;
+ }
+
+ dev_warn(rtk->dev, "RTKit: Exception dump:");
+ dev_warn(rtk->dev, " == Exception taken from %s ==", el);
+ dev_warn(rtk->dev, " PSR = 0x%llx", regs.psr);
+ dev_warn(rtk->dev, " PC = 0x%llx\n", regs.pc);
+ dev_warn(rtk->dev, " ESR = 0x%llx\n", regs.esr);
+ dev_warn(rtk->dev, " FAR = 0x%llx\n", regs.far);
+ dev_warn(rtk->dev, " SP = 0x%llx\n", regs.sp);
+ dev_warn(rtk->dev, "\n");
+
+ for (i = 0; i < 31; i += 4) {
+ if (i < 28)
+ dev_warn(rtk->dev,
+ " x%02d-x%02d = %016llx %016llx %016llx %016llx\n",
+ i, i + 3,
+ regs.regs[i], regs.regs[i + 1],
+ regs.regs[i + 2], regs.regs[i + 3]);
+ else
+ dev_warn(rtk->dev,
+ " x%02d-x%02d = %016llx %016llx %016llx\n", i, i + 3,
+ regs.regs[i], regs.regs[i + 1], regs.regs[i + 2]);
+ }
+
+ dev_warn(rtk->dev, "\n");
+}
+
void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
{
size_t offset;
@@ -140,6 +219,10 @@ void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
apple_rtkit_crashlog_dump_time(rtk, bfr + offset + 16,
section_size);
break;
+ case APPLE_RTKIT_CRASHLOG_REGS:
+ apple_rtkit_crashlog_dump_regs(rtk, bfr + offset + 16,
+ section_size);
+ break;
default:
dev_warn(rtk->dev,
"RTKit: Unknown crashlog section: %x",
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
2023-01-21 7:37 ` Asahi Lina
(?)
@ 2023-01-21 12:13 ` kernel test robot
-1 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2023-01-21 12:13 UTC (permalink / raw)
To: Asahi Lina; +Cc: llvm, oe-kbuild-all
Hi Asahi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on soc/for-next]
[also build test WARNING on linus/master v6.2-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Asahi-Lina/soc-apple-rtkit-Add-register-dump-decoding-to-crashlog/20230121-153927
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/20230121073741.3807-1-lina%40asahilina.net
patch subject: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
config: hexagon-randconfig-r041-20230119 (https://download.01.org/0day-ci/archive/20230121/202301212059.d4SZVT2X-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/91f957dc74ca87a8e0e90a39acac9a4fed0af526
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Asahi-Lina/soc-apple-rtkit-Add-register-dump-decoding-to-crashlog/20230121-153927
git checkout 91f957dc74ca87a8e0e90a39acac9a4fed0af526
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/soc/apple/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/soc/apple/rtkit-crashlog.c:6:
In file included from drivers/soc/apple/rtkit-internal.h:14:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from drivers/soc/apple/rtkit-crashlog.c:6:
In file included from drivers/soc/apple/rtkit-internal.h:14:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from drivers/soc/apple/rtkit-crashlog.c:6:
In file included from drivers/soc/apple/rtkit-internal.h:14:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
>> drivers/soc/apple/rtkit-crashlog.c:124:62: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
dev_warn(rtk->dev, "RTKit: Regs section too small: 0x%lx", size);
~~~ ^~~~
%zx
include/linux/dev_printk.h:146:70: note: expanded from macro 'dev_warn'
dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
_p_func(dev, fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
drivers/soc/apple/rtkit-crashlog.c:130:21: error: use of undeclared identifier 'PSR_MODE_MASK'
switch (regs.psr & PSR_MODE_MASK) {
^
drivers/soc/apple/rtkit-crashlog.c:131:7: error: use of undeclared identifier 'PSR_MODE_EL0t'
case PSR_MODE_EL0t:
^
drivers/soc/apple/rtkit-crashlog.c:134:7: error: use of undeclared identifier 'PSR_MODE_EL1t'
case PSR_MODE_EL1t:
^
drivers/soc/apple/rtkit-crashlog.c:137:7: error: use of undeclared identifier 'PSR_MODE_EL1h'
case PSR_MODE_EL1h:
^
drivers/soc/apple/rtkit-crashlog.c:140:7: error: use of undeclared identifier 'PSR_MODE_EL2t'
case PSR_MODE_EL2t:
^
drivers/soc/apple/rtkit-crashlog.c:143:7: error: use of undeclared identifier 'PSR_MODE_EL2h'
case PSR_MODE_EL2h:
^
7 warnings and 6 errors generated.
vim +124 drivers/soc/apple/rtkit-crashlog.c
115
116 static void apple_rtkit_crashlog_dump_regs(struct apple_rtkit *rtk, u8 *bfr,
117 size_t size)
118 {
119 struct apple_rtkit_crashlog_regs regs;
120 const char *el;
121 int i;
122
123 if (size < sizeof(regs)) {
> 124 dev_warn(rtk->dev, "RTKit: Regs section too small: 0x%lx", size);
125 return;
126 }
127
128 memcpy(®s, bfr, sizeof(regs));
129
130 switch (regs.psr & PSR_MODE_MASK) {
131 case PSR_MODE_EL0t:
132 el = "EL0t";
133 break;
134 case PSR_MODE_EL1t:
135 el = "EL1t";
136 break;
137 case PSR_MODE_EL1h:
138 el = "EL1h";
139 break;
140 case PSR_MODE_EL2t:
141 el = "EL2t";
142 break;
143 case PSR_MODE_EL2h:
144 el = "EL2h";
145 break;
146 default:
147 el = "unknown";
148 break;
149 }
150
151 dev_warn(rtk->dev, "RTKit: Exception dump:");
152 dev_warn(rtk->dev, " == Exception taken from %s ==", el);
153 dev_warn(rtk->dev, " PSR = 0x%llx", regs.psr);
154 dev_warn(rtk->dev, " PC = 0x%llx\n", regs.pc);
155 dev_warn(rtk->dev, " ESR = 0x%llx\n", regs.esr);
156 dev_warn(rtk->dev, " FAR = 0x%llx\n", regs.far);
157 dev_warn(rtk->dev, " SP = 0x%llx\n", regs.sp);
158 dev_warn(rtk->dev, "\n");
159
160 for (i = 0; i < 31; i += 4) {
161 if (i < 28)
162 dev_warn(rtk->dev,
163 " x%02d-x%02d = %016llx %016llx %016llx %016llx\n",
164 i, i + 3,
165 regs.regs[i], regs.regs[i + 1],
166 regs.regs[i + 2], regs.regs[i + 3]);
167 else
168 dev_warn(rtk->dev,
169 " x%02d-x%02d = %016llx %016llx %016llx\n", i, i + 3,
170 regs.regs[i], regs.regs[i + 1], regs.regs[i + 2]);
171 }
172
173 dev_warn(rtk->dev, "\n");
174 }
175
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
2023-01-21 7:37 ` Asahi Lina
@ 2023-01-22 10:19 ` Sven Peter
-1 siblings, 0 replies; 11+ messages in thread
From: Sven Peter @ 2023-01-22 10:19 UTC (permalink / raw)
To: Asahi Lina, Hector Martin
Cc: Alyssa Rosenzweig, asahi, linux-arm-kernel, linux-kernel
On Sat, Jan 21, 2023, at 08:37, Asahi Lina wrote:
> When the coprocessor crashes, it's useful to get a proper register dump
> so we can find out what the firmware was doing. Add a decoder for this.
>
> Originally this had ESR decoding by reusing the ARM64 arch header for
> this, but that introduces some module linking and cross-arch compilation
> issues, so let's leave that out for now.
>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
Reviewed-by: Sven Peter <sven@svenpeter.dev>
thanks,
Sven
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
@ 2023-01-22 10:19 ` Sven Peter
0 siblings, 0 replies; 11+ messages in thread
From: Sven Peter @ 2023-01-22 10:19 UTC (permalink / raw)
To: Asahi Lina, Hector Martin
Cc: Alyssa Rosenzweig, asahi, linux-arm-kernel, linux-kernel
On Sat, Jan 21, 2023, at 08:37, Asahi Lina wrote:
> When the coprocessor crashes, it's useful to get a proper register dump
> so we can find out what the firmware was doing. Add a decoder for this.
>
> Originally this had ESR decoding by reusing the ARM64 arch header for
> this, but that introduces some module linking and cross-arch compilation
> issues, so let's leave that out for now.
>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
Reviewed-by: Sven Peter <sven@svenpeter.dev>
thanks,
Sven
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
2023-01-22 10:19 ` Sven Peter
@ 2023-01-22 17:07 ` Asahi Lina
-1 siblings, 0 replies; 11+ messages in thread
From: Asahi Lina @ 2023-01-22 17:07 UTC (permalink / raw)
To: Sven Peter, Hector Martin
Cc: Alyssa Rosenzweig, asahi, linux-arm-kernel, linux-kernel
On 22/01/2023 19.19, Sven Peter wrote:
> On Sat, Jan 21, 2023, at 08:37, Asahi Lina wrote:
>> When the coprocessor crashes, it's useful to get a proper register dump
>> so we can find out what the firmware was doing. Add a decoder for this.
>>
>> Originally this had ESR decoding by reusing the ARM64 arch header for
>> this, but that introduces some module linking and cross-arch compilation
>> issues, so let's leave that out for now.
>>
>> Signed-off-by: Asahi Lina <lina@asahilina.net>
>> ---
>
> Reviewed-by: Sven Peter <sven@svenpeter.dev>
>
> thanks,
>
> Sven
Thanks for the review! The kernel test robot complained about builds on
non-ARM64, so I'll fix that up and send a v2 ^^
~~ Lina
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
@ 2023-01-22 17:07 ` Asahi Lina
0 siblings, 0 replies; 11+ messages in thread
From: Asahi Lina @ 2023-01-22 17:07 UTC (permalink / raw)
To: Sven Peter, Hector Martin
Cc: Alyssa Rosenzweig, asahi, linux-arm-kernel, linux-kernel
On 22/01/2023 19.19, Sven Peter wrote:
> On Sat, Jan 21, 2023, at 08:37, Asahi Lina wrote:
>> When the coprocessor crashes, it's useful to get a proper register dump
>> so we can find out what the firmware was doing. Add a decoder for this.
>>
>> Originally this had ESR decoding by reusing the ARM64 arch header for
>> this, but that introduces some module linking and cross-arch compilation
>> issues, so let's leave that out for now.
>>
>> Signed-off-by: Asahi Lina <lina@asahilina.net>
>> ---
>
> Reviewed-by: Sven Peter <sven@svenpeter.dev>
>
> thanks,
>
> Sven
Thanks for the review! The kernel test robot complained about builds on
non-ARM64, so I'll fix that up and send a v2 ^^
~~ Lina
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
2023-01-21 7:37 ` Asahi Lina
@ 2023-01-22 12:16 ` Eric Curtin
-1 siblings, 0 replies; 11+ messages in thread
From: Eric Curtin @ 2023-01-22 12:16 UTC (permalink / raw)
To: Asahi Lina
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, asahi,
linux-arm-kernel, linux-kernel
On Sat, 21 Jan 2023 at 07:48, Asahi Lina <lina@asahilina.net> wrote:
>
> When the coprocessor crashes, it's useful to get a proper register dump
> so we can find out what the firmware was doing. Add a decoder for this.
>
> Originally this had ESR decoding by reusing the ARM64 arch header for
> this, but that introduces some module linking and cross-arch compilation
> issues, so let's leave that out for now.
>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Is mise le meas/Regards,
Eric Curtin
> drivers/soc/apple/rtkit-crashlog.c | 83 ++++++++++++++++++++++++++++++
> 1 file changed, 83 insertions(+)
>
> diff --git a/drivers/soc/apple/rtkit-crashlog.c b/drivers/soc/apple/rtkit-crashlog.c
> index 732deed64660..e29ef0a80ab8 100644
> --- a/drivers/soc/apple/rtkit-crashlog.c
> +++ b/drivers/soc/apple/rtkit-crashlog.c
> @@ -13,6 +13,7 @@
> #define APPLE_RTKIT_CRASHLOG_VERSION FOURCC('C', 'v', 'e', 'r')
> #define APPLE_RTKIT_CRASHLOG_MBOX FOURCC('C', 'm', 'b', 'x')
> #define APPLE_RTKIT_CRASHLOG_TIME FOURCC('C', 't', 'i', 'm')
> +#define APPLE_RTKIT_CRASHLOG_REGS FOURCC('C', 'r', 'g', '8')
>
> struct apple_rtkit_crashlog_header {
> u32 fourcc;
> @@ -31,6 +32,24 @@ struct apple_rtkit_crashlog_mbox_entry {
> };
> static_assert(sizeof(struct apple_rtkit_crashlog_mbox_entry) == 0x18);
>
> +struct apple_rtkit_crashlog_regs {
> + u32 unk_0;
> + u32 unk_4;
> + u64 regs[31];
> + u64 sp;
> + u64 pc;
> + u64 psr;
> + u64 cpacr;
> + u64 fpsr;
> + u64 fpcr;
> + u64 unk[64];
> + u64 far;
> + u64 unk_X;
> + u64 esr;
> + u64 unk_Z;
> +};
> +static_assert(sizeof(struct apple_rtkit_crashlog_regs) == 0x350);
> +
> static void apple_rtkit_crashlog_dump_str(struct apple_rtkit *rtk, u8 *bfr,
> size_t size)
> {
> @@ -94,6 +113,66 @@ static void apple_rtkit_crashlog_dump_mailbox(struct apple_rtkit *rtk, u8 *bfr,
> }
> }
>
> +static void apple_rtkit_crashlog_dump_regs(struct apple_rtkit *rtk, u8 *bfr,
> + size_t size)
> +{
> + struct apple_rtkit_crashlog_regs regs;
> + const char *el;
> + int i;
> +
> + if (size < sizeof(regs)) {
> + dev_warn(rtk->dev, "RTKit: Regs section too small: 0x%lx", size);
> + return;
> + }
> +
> + memcpy(®s, bfr, sizeof(regs));
> +
> + switch (regs.psr & PSR_MODE_MASK) {
> + case PSR_MODE_EL0t:
> + el = "EL0t";
> + break;
> + case PSR_MODE_EL1t:
> + el = "EL1t";
> + break;
> + case PSR_MODE_EL1h:
> + el = "EL1h";
> + break;
> + case PSR_MODE_EL2t:
> + el = "EL2t";
> + break;
> + case PSR_MODE_EL2h:
> + el = "EL2h";
> + break;
> + default:
> + el = "unknown";
> + break;
> + }
> +
> + dev_warn(rtk->dev, "RTKit: Exception dump:");
> + dev_warn(rtk->dev, " == Exception taken from %s ==", el);
> + dev_warn(rtk->dev, " PSR = 0x%llx", regs.psr);
> + dev_warn(rtk->dev, " PC = 0x%llx\n", regs.pc);
> + dev_warn(rtk->dev, " ESR = 0x%llx\n", regs.esr);
> + dev_warn(rtk->dev, " FAR = 0x%llx\n", regs.far);
> + dev_warn(rtk->dev, " SP = 0x%llx\n", regs.sp);
> + dev_warn(rtk->dev, "\n");
> +
> + for (i = 0; i < 31; i += 4) {
> + if (i < 28)
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx %016llx\n",
> + i, i + 3,
> + regs.regs[i], regs.regs[i + 1],
> + regs.regs[i + 2], regs.regs[i + 3]);
> + else
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx\n", i, i + 3,
> + regs.regs[i], regs.regs[i + 1], regs.regs[i + 2]);
> + }
> +
> + dev_warn(rtk->dev, "\n");
> +}
> +
> void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> {
> size_t offset;
> @@ -140,6 +219,10 @@ void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> apple_rtkit_crashlog_dump_time(rtk, bfr + offset + 16,
> section_size);
> break;
> + case APPLE_RTKIT_CRASHLOG_REGS:
> + apple_rtkit_crashlog_dump_regs(rtk, bfr + offset + 16,
> + section_size);
> + break;
> default:
> dev_warn(rtk->dev,
> "RTKit: Unknown crashlog section: %x",
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
@ 2023-01-22 12:16 ` Eric Curtin
0 siblings, 0 replies; 11+ messages in thread
From: Eric Curtin @ 2023-01-22 12:16 UTC (permalink / raw)
To: Asahi Lina
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, asahi,
linux-arm-kernel, linux-kernel
On Sat, 21 Jan 2023 at 07:48, Asahi Lina <lina@asahilina.net> wrote:
>
> When the coprocessor crashes, it's useful to get a proper register dump
> so we can find out what the firmware was doing. Add a decoder for this.
>
> Originally this had ESR decoding by reusing the ARM64 arch header for
> this, but that introduces some module linking and cross-arch compilation
> issues, so let's leave that out for now.
>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Is mise le meas/Regards,
Eric Curtin
> drivers/soc/apple/rtkit-crashlog.c | 83 ++++++++++++++++++++++++++++++
> 1 file changed, 83 insertions(+)
>
> diff --git a/drivers/soc/apple/rtkit-crashlog.c b/drivers/soc/apple/rtkit-crashlog.c
> index 732deed64660..e29ef0a80ab8 100644
> --- a/drivers/soc/apple/rtkit-crashlog.c
> +++ b/drivers/soc/apple/rtkit-crashlog.c
> @@ -13,6 +13,7 @@
> #define APPLE_RTKIT_CRASHLOG_VERSION FOURCC('C', 'v', 'e', 'r')
> #define APPLE_RTKIT_CRASHLOG_MBOX FOURCC('C', 'm', 'b', 'x')
> #define APPLE_RTKIT_CRASHLOG_TIME FOURCC('C', 't', 'i', 'm')
> +#define APPLE_RTKIT_CRASHLOG_REGS FOURCC('C', 'r', 'g', '8')
>
> struct apple_rtkit_crashlog_header {
> u32 fourcc;
> @@ -31,6 +32,24 @@ struct apple_rtkit_crashlog_mbox_entry {
> };
> static_assert(sizeof(struct apple_rtkit_crashlog_mbox_entry) == 0x18);
>
> +struct apple_rtkit_crashlog_regs {
> + u32 unk_0;
> + u32 unk_4;
> + u64 regs[31];
> + u64 sp;
> + u64 pc;
> + u64 psr;
> + u64 cpacr;
> + u64 fpsr;
> + u64 fpcr;
> + u64 unk[64];
> + u64 far;
> + u64 unk_X;
> + u64 esr;
> + u64 unk_Z;
> +};
> +static_assert(sizeof(struct apple_rtkit_crashlog_regs) == 0x350);
> +
> static void apple_rtkit_crashlog_dump_str(struct apple_rtkit *rtk, u8 *bfr,
> size_t size)
> {
> @@ -94,6 +113,66 @@ static void apple_rtkit_crashlog_dump_mailbox(struct apple_rtkit *rtk, u8 *bfr,
> }
> }
>
> +static void apple_rtkit_crashlog_dump_regs(struct apple_rtkit *rtk, u8 *bfr,
> + size_t size)
> +{
> + struct apple_rtkit_crashlog_regs regs;
> + const char *el;
> + int i;
> +
> + if (size < sizeof(regs)) {
> + dev_warn(rtk->dev, "RTKit: Regs section too small: 0x%lx", size);
> + return;
> + }
> +
> + memcpy(®s, bfr, sizeof(regs));
> +
> + switch (regs.psr & PSR_MODE_MASK) {
> + case PSR_MODE_EL0t:
> + el = "EL0t";
> + break;
> + case PSR_MODE_EL1t:
> + el = "EL1t";
> + break;
> + case PSR_MODE_EL1h:
> + el = "EL1h";
> + break;
> + case PSR_MODE_EL2t:
> + el = "EL2t";
> + break;
> + case PSR_MODE_EL2h:
> + el = "EL2h";
> + break;
> + default:
> + el = "unknown";
> + break;
> + }
> +
> + dev_warn(rtk->dev, "RTKit: Exception dump:");
> + dev_warn(rtk->dev, " == Exception taken from %s ==", el);
> + dev_warn(rtk->dev, " PSR = 0x%llx", regs.psr);
> + dev_warn(rtk->dev, " PC = 0x%llx\n", regs.pc);
> + dev_warn(rtk->dev, " ESR = 0x%llx\n", regs.esr);
> + dev_warn(rtk->dev, " FAR = 0x%llx\n", regs.far);
> + dev_warn(rtk->dev, " SP = 0x%llx\n", regs.sp);
> + dev_warn(rtk->dev, "\n");
> +
> + for (i = 0; i < 31; i += 4) {
> + if (i < 28)
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx %016llx\n",
> + i, i + 3,
> + regs.regs[i], regs.regs[i + 1],
> + regs.regs[i + 2], regs.regs[i + 3]);
> + else
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx\n", i, i + 3,
> + regs.regs[i], regs.regs[i + 1], regs.regs[i + 2]);
> + }
> +
> + dev_warn(rtk->dev, "\n");
> +}
> +
> void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> {
> size_t offset;
> @@ -140,6 +219,10 @@ void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> apple_rtkit_crashlog_dump_time(rtk, bfr + offset + 16,
> section_size);
> break;
> + case APPLE_RTKIT_CRASHLOG_REGS:
> + apple_rtkit_crashlog_dump_regs(rtk, bfr + offset + 16,
> + section_size);
> + break;
> default:
> dev_warn(rtk->dev,
> "RTKit: Unknown crashlog section: %x",
> --
> 2.35.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
2023-01-21 7:37 ` Asahi Lina
@ 2023-01-22 18:06 ` Eric Curtin
-1 siblings, 0 replies; 11+ messages in thread
From: Eric Curtin @ 2023-01-22 18:06 UTC (permalink / raw)
To: Asahi Lina
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, asahi,
linux-arm-kernel, linux-kernel
On Sat, 21 Jan 2023 at 07:48, Asahi Lina <lina@asahilina.net> wrote:
>
> When the coprocessor crashes, it's useful to get a proper register dump
> so we can find out what the firmware was doing. Add a decoder for this.
>
> Originally this had ESR decoding by reusing the ARM64 arch header for
> this, but that introduces some module linking and cross-arch compilation
> issues, so let's leave that out for now.
>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
Reviewed-by: Eric Curtin <ecurtin@redhat.com>
Is mise le meas/Regards,
Eric Curtin
> drivers/soc/apple/rtkit-crashlog.c | 83 ++++++++++++++++++++++++++++++
> 1 file changed, 83 insertions(+)
>
> diff --git a/drivers/soc/apple/rtkit-crashlog.c b/drivers/soc/apple/rtkit-crashlog.c
> index 732deed64660..e29ef0a80ab8 100644
> --- a/drivers/soc/apple/rtkit-crashlog.c
> +++ b/drivers/soc/apple/rtkit-crashlog.c
> @@ -13,6 +13,7 @@
> #define APPLE_RTKIT_CRASHLOG_VERSION FOURCC('C', 'v', 'e', 'r')
> #define APPLE_RTKIT_CRASHLOG_MBOX FOURCC('C', 'm', 'b', 'x')
> #define APPLE_RTKIT_CRASHLOG_TIME FOURCC('C', 't', 'i', 'm')
> +#define APPLE_RTKIT_CRASHLOG_REGS FOURCC('C', 'r', 'g', '8')
>
> struct apple_rtkit_crashlog_header {
> u32 fourcc;
> @@ -31,6 +32,24 @@ struct apple_rtkit_crashlog_mbox_entry {
> };
> static_assert(sizeof(struct apple_rtkit_crashlog_mbox_entry) == 0x18);
>
> +struct apple_rtkit_crashlog_regs {
> + u32 unk_0;
> + u32 unk_4;
> + u64 regs[31];
> + u64 sp;
> + u64 pc;
> + u64 psr;
> + u64 cpacr;
> + u64 fpsr;
> + u64 fpcr;
> + u64 unk[64];
> + u64 far;
> + u64 unk_X;
> + u64 esr;
> + u64 unk_Z;
> +};
> +static_assert(sizeof(struct apple_rtkit_crashlog_regs) == 0x350);
> +
> static void apple_rtkit_crashlog_dump_str(struct apple_rtkit *rtk, u8 *bfr,
> size_t size)
> {
> @@ -94,6 +113,66 @@ static void apple_rtkit_crashlog_dump_mailbox(struct apple_rtkit *rtk, u8 *bfr,
> }
> }
>
> +static void apple_rtkit_crashlog_dump_regs(struct apple_rtkit *rtk, u8 *bfr,
> + size_t size)
> +{
> + struct apple_rtkit_crashlog_regs regs;
> + const char *el;
> + int i;
> +
> + if (size < sizeof(regs)) {
> + dev_warn(rtk->dev, "RTKit: Regs section too small: 0x%lx", size);
> + return;
> + }
> +
> + memcpy(®s, bfr, sizeof(regs));
> +
> + switch (regs.psr & PSR_MODE_MASK) {
> + case PSR_MODE_EL0t:
> + el = "EL0t";
> + break;
> + case PSR_MODE_EL1t:
> + el = "EL1t";
> + break;
> + case PSR_MODE_EL1h:
> + el = "EL1h";
> + break;
> + case PSR_MODE_EL2t:
> + el = "EL2t";
> + break;
> + case PSR_MODE_EL2h:
> + el = "EL2h";
> + break;
> + default:
> + el = "unknown";
> + break;
> + }
> +
> + dev_warn(rtk->dev, "RTKit: Exception dump:");
> + dev_warn(rtk->dev, " == Exception taken from %s ==", el);
> + dev_warn(rtk->dev, " PSR = 0x%llx", regs.psr);
> + dev_warn(rtk->dev, " PC = 0x%llx\n", regs.pc);
> + dev_warn(rtk->dev, " ESR = 0x%llx\n", regs.esr);
> + dev_warn(rtk->dev, " FAR = 0x%llx\n", regs.far);
> + dev_warn(rtk->dev, " SP = 0x%llx\n", regs.sp);
> + dev_warn(rtk->dev, "\n");
> +
> + for (i = 0; i < 31; i += 4) {
> + if (i < 28)
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx %016llx\n",
> + i, i + 3,
> + regs.regs[i], regs.regs[i + 1],
> + regs.regs[i + 2], regs.regs[i + 3]);
> + else
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx\n", i, i + 3,
> + regs.regs[i], regs.regs[i + 1], regs.regs[i + 2]);
> + }
> +
> + dev_warn(rtk->dev, "\n");
> +}
> +
> void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> {
> size_t offset;
> @@ -140,6 +219,10 @@ void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> apple_rtkit_crashlog_dump_time(rtk, bfr + offset + 16,
> section_size);
> break;
> + case APPLE_RTKIT_CRASHLOG_REGS:
> + apple_rtkit_crashlog_dump_regs(rtk, bfr + offset + 16,
> + section_size);
> + break;
> default:
> dev_warn(rtk->dev,
> "RTKit: Unknown crashlog section: %x",
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
@ 2023-01-22 18:06 ` Eric Curtin
0 siblings, 0 replies; 11+ messages in thread
From: Eric Curtin @ 2023-01-22 18:06 UTC (permalink / raw)
To: Asahi Lina
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, asahi,
linux-arm-kernel, linux-kernel
On Sat, 21 Jan 2023 at 07:48, Asahi Lina <lina@asahilina.net> wrote:
>
> When the coprocessor crashes, it's useful to get a proper register dump
> so we can find out what the firmware was doing. Add a decoder for this.
>
> Originally this had ESR decoding by reusing the ARM64 arch header for
> this, but that introduces some module linking and cross-arch compilation
> issues, so let's leave that out for now.
>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
Reviewed-by: Eric Curtin <ecurtin@redhat.com>
Is mise le meas/Regards,
Eric Curtin
> drivers/soc/apple/rtkit-crashlog.c | 83 ++++++++++++++++++++++++++++++
> 1 file changed, 83 insertions(+)
>
> diff --git a/drivers/soc/apple/rtkit-crashlog.c b/drivers/soc/apple/rtkit-crashlog.c
> index 732deed64660..e29ef0a80ab8 100644
> --- a/drivers/soc/apple/rtkit-crashlog.c
> +++ b/drivers/soc/apple/rtkit-crashlog.c
> @@ -13,6 +13,7 @@
> #define APPLE_RTKIT_CRASHLOG_VERSION FOURCC('C', 'v', 'e', 'r')
> #define APPLE_RTKIT_CRASHLOG_MBOX FOURCC('C', 'm', 'b', 'x')
> #define APPLE_RTKIT_CRASHLOG_TIME FOURCC('C', 't', 'i', 'm')
> +#define APPLE_RTKIT_CRASHLOG_REGS FOURCC('C', 'r', 'g', '8')
>
> struct apple_rtkit_crashlog_header {
> u32 fourcc;
> @@ -31,6 +32,24 @@ struct apple_rtkit_crashlog_mbox_entry {
> };
> static_assert(sizeof(struct apple_rtkit_crashlog_mbox_entry) == 0x18);
>
> +struct apple_rtkit_crashlog_regs {
> + u32 unk_0;
> + u32 unk_4;
> + u64 regs[31];
> + u64 sp;
> + u64 pc;
> + u64 psr;
> + u64 cpacr;
> + u64 fpsr;
> + u64 fpcr;
> + u64 unk[64];
> + u64 far;
> + u64 unk_X;
> + u64 esr;
> + u64 unk_Z;
> +};
> +static_assert(sizeof(struct apple_rtkit_crashlog_regs) == 0x350);
> +
> static void apple_rtkit_crashlog_dump_str(struct apple_rtkit *rtk, u8 *bfr,
> size_t size)
> {
> @@ -94,6 +113,66 @@ static void apple_rtkit_crashlog_dump_mailbox(struct apple_rtkit *rtk, u8 *bfr,
> }
> }
>
> +static void apple_rtkit_crashlog_dump_regs(struct apple_rtkit *rtk, u8 *bfr,
> + size_t size)
> +{
> + struct apple_rtkit_crashlog_regs regs;
> + const char *el;
> + int i;
> +
> + if (size < sizeof(regs)) {
> + dev_warn(rtk->dev, "RTKit: Regs section too small: 0x%lx", size);
> + return;
> + }
> +
> + memcpy(®s, bfr, sizeof(regs));
> +
> + switch (regs.psr & PSR_MODE_MASK) {
> + case PSR_MODE_EL0t:
> + el = "EL0t";
> + break;
> + case PSR_MODE_EL1t:
> + el = "EL1t";
> + break;
> + case PSR_MODE_EL1h:
> + el = "EL1h";
> + break;
> + case PSR_MODE_EL2t:
> + el = "EL2t";
> + break;
> + case PSR_MODE_EL2h:
> + el = "EL2h";
> + break;
> + default:
> + el = "unknown";
> + break;
> + }
> +
> + dev_warn(rtk->dev, "RTKit: Exception dump:");
> + dev_warn(rtk->dev, " == Exception taken from %s ==", el);
> + dev_warn(rtk->dev, " PSR = 0x%llx", regs.psr);
> + dev_warn(rtk->dev, " PC = 0x%llx\n", regs.pc);
> + dev_warn(rtk->dev, " ESR = 0x%llx\n", regs.esr);
> + dev_warn(rtk->dev, " FAR = 0x%llx\n", regs.far);
> + dev_warn(rtk->dev, " SP = 0x%llx\n", regs.sp);
> + dev_warn(rtk->dev, "\n");
> +
> + for (i = 0; i < 31; i += 4) {
> + if (i < 28)
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx %016llx\n",
> + i, i + 3,
> + regs.regs[i], regs.regs[i + 1],
> + regs.regs[i + 2], regs.regs[i + 3]);
> + else
> + dev_warn(rtk->dev,
> + " x%02d-x%02d = %016llx %016llx %016llx\n", i, i + 3,
> + regs.regs[i], regs.regs[i + 1], regs.regs[i + 2]);
> + }
> +
> + dev_warn(rtk->dev, "\n");
> +}
> +
> void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> {
> size_t offset;
> @@ -140,6 +219,10 @@ void apple_rtkit_crashlog_dump(struct apple_rtkit *rtk, u8 *bfr, size_t size)
> apple_rtkit_crashlog_dump_time(rtk, bfr + offset + 16,
> section_size);
> break;
> + case APPLE_RTKIT_CRASHLOG_REGS:
> + apple_rtkit_crashlog_dump_regs(rtk, bfr + offset + 16,
> + section_size);
> + break;
> default:
> dev_warn(rtk->dev,
> "RTKit: Unknown crashlog section: %x",
> --
> 2.35.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread