From: Christoph Hellwig <hch@lst.de>
To: Song Liu <song@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
songliubraving@fb.com, Peter Zijlstra <peterz@infradead.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] module: replace module_layout with module_memory
Date: Mon, 23 Jan 2023 07:57:46 +0100 [thread overview]
Message-ID: <20230123065746.GB30529@lst.de> (raw)
In-Reply-To: <CAPhsuW4snf6cBYSDRbALSNM4OE36-dusir8HQQ90Li7u067ZWA@mail.gmail.com>
On Fri, Jan 20, 2023 at 09:42:26AM -0800, Song Liu wrote:
> So here are the two versions, both with secondary addr_[min|max] for
> CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC.
>
> v2. Just use mod_mem array:
> https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git/commit/?h=remotes/song-md/new_module_alloc_build_test_v2
>
> v3. mod_mem array and the defines:
> #define mod_core_text mod_mem[MOD_MEM_TYPE_TEXT]
> #define mod_core_data mod_mem[MOD_MEM_TYPE_DATA]
> etc.
> https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git/commit/?h=remotes/song-md/new_module_alloc_build_test_v3
I find v2 much preferably. Having magic layouts with different
access methods is horribly confusing. It might be a way changes
things if modifying every caller would be intrusive, but starting
out that way does not seem like a very good idea.
next prev parent reply other threads:[~2023-01-23 6:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 22:09 [PATCH/RFC] module: replace module_layout with module_memory Song Liu
2023-01-09 18:03 ` Christophe Leroy
2023-01-09 18:24 ` Song Liu
2023-01-09 20:51 ` Song Liu
2023-01-10 6:31 ` Christophe Leroy
2023-01-10 6:51 ` Song Liu
2023-01-18 15:07 ` Peter Zijlstra
2023-01-18 17:52 ` Song Liu
2023-01-10 18:31 ` Song Liu
2023-01-17 18:50 ` Song Liu
2023-01-18 7:40 ` Christoph Hellwig
2023-01-18 17:37 ` Song Liu
2023-01-18 21:52 ` Song Liu
2023-01-19 5:35 ` Christoph Hellwig
2023-01-19 8:29 ` Song Liu
2023-01-20 17:42 ` Song Liu
2023-01-23 6:57 ` Christoph Hellwig [this message]
2023-01-24 18:01 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123065746.GB30529@lst.de \
--to=hch@lst.de \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.