All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Markus Armbruster" <armbru@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Cc: "Volker Rümelin" <vr_qemu@t-online.de>,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>
Subject: [PATCH v2 0/2] audio: make audiodev introspectable by management apps
Date: Mon, 23 Jan 2023 09:39:55 +0100	[thread overview]
Message-ID: <20230123083957.20349-1-thuth@redhat.com> (raw)

Here's a respin from Daniel's audiodev introspection patches from
2021. I've rebased them to the current master branch and addressed
the review comments from v1.

The Audiodev QAPI type is not introspectable via query-qmp-schema as
nothing in QMP uses it. "-audiodev" is not introspectable via
query-command-line-options because it avoided legacy QemuOpts.

To fix it, introduce a tiny "query-audiodev" QMP command that uses
the "Audiodev" QAPI structure, so that it shows up in the schema.
Then mark the various backend types with conditionals so that only
the ones that were available at compile time show up in the schema.

Daniel P. Berrangé (2):
  qapi, audio: add query-audiodev command
  qapi, audio: Make introspection reflect build configuration more
    closely

 qapi/audio.json        | 57 +++++++++++++++++++++++++++++++++---------
 audio/audio_template.h | 20 +++++++++++++++
 audio/audio.c          | 32 ++++++++++++++++++++++++
 audio/audio_legacy.c   | 41 +++++++++++++++++++++++++++++-
 4 files changed, 137 insertions(+), 13 deletions(-)

-- 
2.31.1



             reply	other threads:[~2023-01-23  8:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23  8:39 Thomas Huth [this message]
2023-01-23  8:39 ` [PATCH v2 1/2] qapi, audio: add query-audiodev command Thomas Huth
2023-01-23  9:20   ` Philippe Mathieu-Daudé
2023-01-23 11:11     ` Daniel P. Berrangé
2023-01-23 12:05       ` Philippe Mathieu-Daudé
2023-01-23 12:09         ` Daniel P. Berrangé
2023-01-25 11:06           ` Thomas Huth
2023-01-25 12:06             ` Daniel P. Berrangé
2023-01-25 12:04           ` Philippe Mathieu-Daudé
2023-01-23  8:39 ` [PATCH v2 2/2] qapi, audio: Make introspection reflect build configuration more closely Thomas Huth
2023-01-31 10:09 ` [PATCH v2 0/2] audio: make audiodev introspectable by management apps Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230123083957.20349-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.