From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1618C38142 for ; Mon, 23 Jan 2023 11:38:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 077EF415D; Mon, 23 Jan 2023 12:37:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 077EF415D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674473878; bh=piWmNlmE3+MCVvamvJ42lMN6E5O7WJ0RO0N8yjjRmtY=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=pBh6iD4vcXB0xwI+bkteowIqgieOOYX54XauXwV1G2Df/9tcbYqnkCYAmyCXIxZSq oXMhEdCer9HqFFAo06zbkce5JgktE2403y6p/NBbpZ3OEZtyUItfwyYt7ukxkBZk+4 7BTMNo10pZ1kormGyLPYE898sInmusDoGT8+6Kr0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8C007F804A9; Mon, 23 Jan 2023 12:37:07 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 893E2F804C2; Mon, 23 Jan 2023 12:37:06 +0100 (CET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 20A26F800FB for ; Mon, 23 Jan 2023 12:36:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 20A26F800FB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Vvqt8+5/ Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6FC67240008; Mon, 23 Jan 2023 11:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674473815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+igJAl/pqifZR0SzjchX5EdGz+pfJPGF0MNYlXIniw=; b=Vvqt8+5/D4t75o0MWtOWszmDjoeLxz0d8GCcpsXlPFGEQO1h5IYdfDvR0ZBPmABm5ZiMpa ka78Q+jnKGZ43b1E0oh4TOvLRXwDmpLGvLjwiDqiO6hp6nAy2cNcdPyJoKdroPvl3ibrlh M01++3vd0cD96YDOahpAvLZUEfs2hrRS1MQVQlOd9dkRMVWbyPozee6jS0v965m76BM20h QXEkbkYFnAY12818WdmLjliG53OSuBQb4MeEtBbqcB1HDqe4Z4QnpUY/shkyP3x4szYy1p 1rvhbnJoA81ZEiZcFQ0+7E9GUQg/sDWXCr2Qa4tM4nbEOxY+FnNlTOO0427nrw== Date: Mon, 23 Jan 2023 12:36:49 +0100 From: Herve Codina To: Rob Herring Subject: Re: [PATCH v3 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230123123649.63f17dad@bootlin.com> In-Reply-To: <20230117145529.GA3044055-robh@kernel.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-2-herve.codina@bootlin.com> <20230117145529.GA3044055-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Liam Girdwood , Christophe Leroy , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Nicholas Piggin , Krzysztof Kozlowski , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Rob, On Tue, 17 Jan 2023 08:55:29 -0600 Rob Herring wrote: > On Fri, Jan 13, 2023 at 11:37:50AM +0100, Herve Codina wrote: > > Add support for the time slot assigner (TSA) > > available in some PowerQUICC SoC such as MPC885 > > or MPC866. =20 >=20 > An odd line wrap length...=20 Will be changed in v4. >=20 > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,tsa.yaml | 260 ++++++++++++++++++ > > include/dt-bindings/soc/fsl,tsa.h | 13 + > > 2 files changed, 273 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,tsa.yaml > > create mode 100644 include/dt-bindings/soc/fsl,tsa.h > >=20 > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.y= aml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.yaml > > new file mode 100644 > > index 000000000000..eb17b6119abd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.yaml > > @@ -0,0 +1,260 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,tsa.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PowerQUICC CPM Time-slot assigner (TSA) controller > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | =20 >=20 > Don't need '|' if no formatting. Will be changed in v4. >=20 > > + The TSA is the time-slot assigner that can be found on some > > + PowerQUICC SoC. > > + Its purpose is to route some TDM time-slots to other internal > > + serial controllers. =20 >=20 > Wrap at 80. Will be fixed in v4. >=20 > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,mpc885-tsa > > + - fsl,mpc866-tsa > > + - const: fsl,cpm1-tsa > > + > > + reg: > > + items: > > + - description: SI (Serial Interface) register base > > + - description: SI RAM base > > + > > + reg-names: > > + items: > > + - const: si_regs > > + - const: si_ram > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > +patternProperties: > > + '^tdm@[0-1]$': > > + description: > > + The TDM managed by this controller > > + type: object =20 >=20 > additionalProperties: false Will be added in v4. >=20 > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 1 > > + description: > > + The TDM number for this TDM, 0 for TDMa and 1 for TDMb > > + > > + fsl,common-rxtx-pins: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The hardware can use four dedicated pins for Tx clock, > > + Tx sync, Rx clock and Rx sync or use only two pins, > > + Tx/Rx clock and Rx/Rx sync. > > + Without the 'fsl,common-rxtx-pins' property, the four > > + pins are used. With the 'fsl,common-rxtx-pins' property, > > + two pins are used. > > + > > + clocks: > > + minItems: 2 > > + maxItems: 4 > > + > > + clock-names: > > + minItems: 2 > > + maxItems: 4 > > + > > + fsl,mode: =20 >=20 > 'mode' is a bit vague. It's already used as well which can be a problem=20 > if there are differing types. (There's not in this case) What do you think about: fsl,diagnostic-mode: $ref: /schemas/types.yaml#/definitions/string enum: [disabled, echo, internal-loopback, control-loopback] default: disabled description: | The diagnostic mode can be used to diagnose some communication is= sues. It should not be present (or set to 'disabled') when diagnostic i= s not needed. Diagnostic mode: - disabled: Diagnostic disabled (ie. normal operation) - echo: Automatic echo. Rx data is resent on Tx - internal-loopback: The TDM transmitter is connected to the receiver. Data appears on Tx pin. - control-loopback: The TDM transmitter is connected to the receiver. The Tx pin is disconnected. >=20 > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [normal, echo, internal-loopback, control-loopback] > > + default: normal > > + description: | > > + Operational mode: > > + - normal: > > + Normal operation > > + - echo: > > + Automatic echo. Rx data is resent on Tx > > + - internal-loopback: > > + The TDM transmitter is connected to the receiver. > > + Data appears on Tx pin. > > + - control-loopback: > > + The TDM transmitter is connected to the receiver. > > + The Tx pin is disconnected. > > + > > + fsl,rx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] > > + default: 0 > > + description: | > > + Receive frame sync delay in number of bits. > > + Indicates the delay between the Rx sync and the first bit of= the > > + Rx frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits d= elay. > > + > > + fsl,tx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] > > + default: 0 > > + description: | > > + Transmit frame sync delay in number of bits. > > + Indicates the delay between the Tx sync and the first bit of= the > > + Tx frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits d= elay. > > + > > + fsl,clock-falling-edge: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: | > > + Data is sent on falling edge of the clock (and received on t= he > > + rising edge). > > + If 'clock-falling-edge' is not present, data is sent on the > > + rising edge (and received on the falling edge). > > + > > + fsl,fsync-rising-edge: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Frame sync pulses are sampled with the rising edge of the ch= annel > > + clock. If 'fsync-rising-edge' is not present, pulses are sam= ple > > + with e falling edge. > > + > > + fsl,double-speed-clock: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The channel clock is twice the data rate. > > + > > + fsl,tx-ts-routes: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + description: | > > + A list of tupple that indicates the Tx time-slots routes. > > + tx_ts_routes =3D > > + < 2 0 >, /* The first 2 time slots are not used */ > > + < 3 1 >, /* The next 3 ones are route to SCC2 */ > > + < 4 0 >, /* The next 4 ones are not used */ > > + < 2 2 >; /* The nest 2 ones are route to SCC3 */ > > + items: > > + items: > > + - description: > > + The number of time-slots > > + minimum: 1 > > + maximum: 64 > > + - description: | > > + The source serial interface (dt-bindings/soc/fsl,tsa.h > > + defines these values) > > + - 0: No destination > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 > > + - 4: SMC1 > > + - 5: SMC2 > > + enum: [0, 1, 2, 3, 4, 5] > > + minItems: 1 > > + maxItems: 64 > > + > > + fsl,rx-ts-routes: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + description: | > > + A list of tupple that indicates the Rx time-slots routes. > > + tx_ts_routes =3D > > + < 2 0 >, /* The first 2 time slots are not used */ > > + < 3 1 >, /* The next 3 ones are route from SCC2 */ > > + < 4 0 >, /* The next 4 ones are not used */ > > + < 2 2 >; /* The nest 2 ones are route from SCC3 */ > > + items: > > + items: > > + - description: > > + The number of time-slots > > + minimum: 1 > > + maximum: 64 > > + - description: | > > + The destination serial interface (dt-bindings/soc/fsl,= tsa.h > > + defines these values) > > + - 0: No destination > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 > > + - 4: SMC1 > > + - 5: SMC2 > > + enum: [0, 1, 2, 3, 4, 5] > > + minItems: 1 > > + maxItems: 64 > > + > > + allOf: > > + # If fsl,common-rxtx-pins is present, only 2 clocks are needed. > > + # Else, the 4 clocks must be present. > > + - if: > > + required: > > + - fsl,common-rxtx-pins > > + then: > > + properties: > > + clocks: > > + items: > > + - description: External clock connected to L1RSYNC pin > > + - description: External clock connected to L1RCLK pin > > + clock-names: > > + items: > > + - const: l1rsync > > + - const: l1rclk > > + else: > > + properties: > > + clocks: > > + items: > > + - description: External clock connected to L1RSYNC pin > > + - description: External clock connected to L1RCLK pin > > + - description: External clock connected to L1TSYNC pin > > + - description: External clock connected to L1TCLK pin > > + clock-names: > > + items: > > + - const: l1rsync > > + - const: l1rclk > > + - const: l1tsync > > + - const: l1tclk =20 >=20 > As the names are the same, just the length varies between 2 or 4, move=20 > all this to the main definition and here just put constraints on the=20 > length. Ok, will be done in v4. >=20 > > + > > + required: > > + - reg > > + - clocks > > + - clock-names > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - '#address-cells' > > + - '#size-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + tsa@ae0 { > > + compatible =3D "fsl,mpc885-tsa", "fsl,cpm1-tsa"; > > + reg =3D <0xae0 0x10>, > > + <0xc00 0x200>; > > + reg-names =3D "si_regs", "si_ram"; > > + > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + tdm@0 { > > + /* TDMa */ > > + reg =3D <0>; > > + > > + clocks =3D <&clk_l1rsynca>, <&clk_l1rclka>; > > + clock-names =3D "l1rsync", "l1rclk"; > > + > > + fsl,common-rxtx-pins; > > + fsl,fsync-rising-edge; > > + > > + fsl,tx-ts-routes =3D < 2 0 >, /* TS 0..1 */ > > + < 24 FSL_CPM_TSA_SCC4 >, /* TS 2..25 */ > > + < 1 0 >, /* TS 26 */ > > + < 5 FSL_CPM_TSA_SCC3 >; /* TS 27..31 */ > > + > > + fsl,rx-ts-routes =3D < 2 0 >, /* TS 0..1 */ > > + < 24 FSL_CPM_TSA_SCC4 >, /* 2..25 */ > > + < 1 0 >, /* TS 26 */ > > + < 5 FSL_CPM_TSA_SCC3 >; /* TS 27..31 */ > > + }; > > + }; > > diff --git a/include/dt-bindings/soc/fsl,tsa.h b/include/dt-bindings/so= c/fsl,tsa.h > > new file mode 100644 > > index 000000000000..2cc44e867dbe > > --- /dev/null > > +++ b/include/dt-bindings/soc/fsl,tsa.h > > @@ -0,0 +1,13 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > > + > > +#ifndef __DT_BINDINGS_SOC_FSL_TSA_H > > +#define __DT_BINDINGS_SOC_FSL_TSA_H > > + > > +#define FSL_CPM_TSA_NU 0 /* Pseuso Cell Id for not used item */ > > +#define FSL_CPM_TSA_SCC2 1 > > +#define FSL_CPM_TSA_SCC3 2 > > +#define FSL_CPM_TSA_SCC4 3 > > +#define FSL_CPM_TSA_SMC1 4 > > +#define FSL_CPM_TSA_SMC2 5 > > + > > +#endif > > --=20 > > 2.38.1 > > =20 Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0966C05027 for ; Mon, 23 Jan 2023 11:38:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P0p4p0S5Dz3cQV for ; Mon, 23 Jan 2023 22:38:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Vvqt8+5/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::221; helo=relay1-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Vvqt8+5/; dkim-atps=neutral Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P0p3m2P96z3bNg for ; Mon, 23 Jan 2023 22:37:04 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6FC67240008; Mon, 23 Jan 2023 11:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674473815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+igJAl/pqifZR0SzjchX5EdGz+pfJPGF0MNYlXIniw=; b=Vvqt8+5/D4t75o0MWtOWszmDjoeLxz0d8GCcpsXlPFGEQO1h5IYdfDvR0ZBPmABm5ZiMpa ka78Q+jnKGZ43b1E0oh4TOvLRXwDmpLGvLjwiDqiO6hp6nAy2cNcdPyJoKdroPvl3ibrlh M01++3vd0cD96YDOahpAvLZUEfs2hrRS1MQVQlOd9dkRMVWbyPozee6jS0v965m76BM20h QXEkbkYFnAY12818WdmLjliG53OSuBQb4MeEtBbqcB1HDqe4Z4QnpUY/shkyP3x4szYy1p 1rvhbnJoA81ZEiZcFQ0+7E9GUQg/sDWXCr2Qa4tM4nbEOxY+FnNlTOO0427nrw== Date: Mon, 23 Jan 2023 12:36:49 +0100 From: Herve Codina To: Rob Herring Subject: Re: [PATCH v3 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230123123649.63f17dad@bootlin.com> In-Reply-To: <20230117145529.GA3044055-robh@kernel.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-2-herve.codina@bootlin.com> <20230117145529.GA3044055-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Liam Girdwood , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Nicholas Piggin , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Rob, On Tue, 17 Jan 2023 08:55:29 -0600 Rob Herring wrote: > On Fri, Jan 13, 2023 at 11:37:50AM +0100, Herve Codina wrote: > > Add support for the time slot assigner (TSA) > > available in some PowerQUICC SoC such as MPC885 > > or MPC866. =20 >=20 > An odd line wrap length...=20 Will be changed in v4. >=20 > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,tsa.yaml | 260 ++++++++++++++++++ > > include/dt-bindings/soc/fsl,tsa.h | 13 + > > 2 files changed, 273 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,tsa.yaml > > create mode 100644 include/dt-bindings/soc/fsl,tsa.h > >=20 > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.y= aml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.yaml > > new file mode 100644 > > index 000000000000..eb17b6119abd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.yaml > > @@ -0,0 +1,260 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,tsa.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PowerQUICC CPM Time-slot assigner (TSA) controller > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | =20 >=20 > Don't need '|' if no formatting. Will be changed in v4. >=20 > > + The TSA is the time-slot assigner that can be found on some > > + PowerQUICC SoC. > > + Its purpose is to route some TDM time-slots to other internal > > + serial controllers. =20 >=20 > Wrap at 80. Will be fixed in v4. >=20 > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,mpc885-tsa > > + - fsl,mpc866-tsa > > + - const: fsl,cpm1-tsa > > + > > + reg: > > + items: > > + - description: SI (Serial Interface) register base > > + - description: SI RAM base > > + > > + reg-names: > > + items: > > + - const: si_regs > > + - const: si_ram > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > +patternProperties: > > + '^tdm@[0-1]$': > > + description: > > + The TDM managed by this controller > > + type: object =20 >=20 > additionalProperties: false Will be added in v4. >=20 > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 1 > > + description: > > + The TDM number for this TDM, 0 for TDMa and 1 for TDMb > > + > > + fsl,common-rxtx-pins: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The hardware can use four dedicated pins for Tx clock, > > + Tx sync, Rx clock and Rx sync or use only two pins, > > + Tx/Rx clock and Rx/Rx sync. > > + Without the 'fsl,common-rxtx-pins' property, the four > > + pins are used. With the 'fsl,common-rxtx-pins' property, > > + two pins are used. > > + > > + clocks: > > + minItems: 2 > > + maxItems: 4 > > + > > + clock-names: > > + minItems: 2 > > + maxItems: 4 > > + > > + fsl,mode: =20 >=20 > 'mode' is a bit vague. It's already used as well which can be a problem=20 > if there are differing types. (There's not in this case) What do you think about: fsl,diagnostic-mode: $ref: /schemas/types.yaml#/definitions/string enum: [disabled, echo, internal-loopback, control-loopback] default: disabled description: | The diagnostic mode can be used to diagnose some communication is= sues. It should not be present (or set to 'disabled') when diagnostic i= s not needed. Diagnostic mode: - disabled: Diagnostic disabled (ie. normal operation) - echo: Automatic echo. Rx data is resent on Tx - internal-loopback: The TDM transmitter is connected to the receiver. Data appears on Tx pin. - control-loopback: The TDM transmitter is connected to the receiver. The Tx pin is disconnected. >=20 > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [normal, echo, internal-loopback, control-loopback] > > + default: normal > > + description: | > > + Operational mode: > > + - normal: > > + Normal operation > > + - echo: > > + Automatic echo. Rx data is resent on Tx > > + - internal-loopback: > > + The TDM transmitter is connected to the receiver. > > + Data appears on Tx pin. > > + - control-loopback: > > + The TDM transmitter is connected to the receiver. > > + The Tx pin is disconnected. > > + > > + fsl,rx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] > > + default: 0 > > + description: | > > + Receive frame sync delay in number of bits. > > + Indicates the delay between the Rx sync and the first bit of= the > > + Rx frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits d= elay. > > + > > + fsl,tx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] > > + default: 0 > > + description: | > > + Transmit frame sync delay in number of bits. > > + Indicates the delay between the Tx sync and the first bit of= the > > + Tx frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits d= elay. > > + > > + fsl,clock-falling-edge: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: | > > + Data is sent on falling edge of the clock (and received on t= he > > + rising edge). > > + If 'clock-falling-edge' is not present, data is sent on the > > + rising edge (and received on the falling edge). > > + > > + fsl,fsync-rising-edge: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Frame sync pulses are sampled with the rising edge of the ch= annel > > + clock. If 'fsync-rising-edge' is not present, pulses are sam= ple > > + with e falling edge. > > + > > + fsl,double-speed-clock: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The channel clock is twice the data rate. > > + > > + fsl,tx-ts-routes: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + description: | > > + A list of tupple that indicates the Tx time-slots routes. > > + tx_ts_routes =3D > > + < 2 0 >, /* The first 2 time slots are not used */ > > + < 3 1 >, /* The next 3 ones are route to SCC2 */ > > + < 4 0 >, /* The next 4 ones are not used */ > > + < 2 2 >; /* The nest 2 ones are route to SCC3 */ > > + items: > > + items: > > + - description: > > + The number of time-slots > > + minimum: 1 > > + maximum: 64 > > + - description: | > > + The source serial interface (dt-bindings/soc/fsl,tsa.h > > + defines these values) > > + - 0: No destination > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 > > + - 4: SMC1 > > + - 5: SMC2 > > + enum: [0, 1, 2, 3, 4, 5] > > + minItems: 1 > > + maxItems: 64 > > + > > + fsl,rx-ts-routes: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + description: | > > + A list of tupple that indicates the Rx time-slots routes. > > + tx_ts_routes =3D > > + < 2 0 >, /* The first 2 time slots are not used */ > > + < 3 1 >, /* The next 3 ones are route from SCC2 */ > > + < 4 0 >, /* The next 4 ones are not used */ > > + < 2 2 >; /* The nest 2 ones are route from SCC3 */ > > + items: > > + items: > > + - description: > > + The number of time-slots > > + minimum: 1 > > + maximum: 64 > > + - description: | > > + The destination serial interface (dt-bindings/soc/fsl,= tsa.h > > + defines these values) > > + - 0: No destination > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 > > + - 4: SMC1 > > + - 5: SMC2 > > + enum: [0, 1, 2, 3, 4, 5] > > + minItems: 1 > > + maxItems: 64 > > + > > + allOf: > > + # If fsl,common-rxtx-pins is present, only 2 clocks are needed. > > + # Else, the 4 clocks must be present. > > + - if: > > + required: > > + - fsl,common-rxtx-pins > > + then: > > + properties: > > + clocks: > > + items: > > + - description: External clock connected to L1RSYNC pin > > + - description: External clock connected to L1RCLK pin > > + clock-names: > > + items: > > + - const: l1rsync > > + - const: l1rclk > > + else: > > + properties: > > + clocks: > > + items: > > + - description: External clock connected to L1RSYNC pin > > + - description: External clock connected to L1RCLK pin > > + - description: External clock connected to L1TSYNC pin > > + - description: External clock connected to L1TCLK pin > > + clock-names: > > + items: > > + - const: l1rsync > > + - const: l1rclk > > + - const: l1tsync > > + - const: l1tclk =20 >=20 > As the names are the same, just the length varies between 2 or 4, move=20 > all this to the main definition and here just put constraints on the=20 > length. Ok, will be done in v4. >=20 > > + > > + required: > > + - reg > > + - clocks > > + - clock-names > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - '#address-cells' > > + - '#size-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + tsa@ae0 { > > + compatible =3D "fsl,mpc885-tsa", "fsl,cpm1-tsa"; > > + reg =3D <0xae0 0x10>, > > + <0xc00 0x200>; > > + reg-names =3D "si_regs", "si_ram"; > > + > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + tdm@0 { > > + /* TDMa */ > > + reg =3D <0>; > > + > > + clocks =3D <&clk_l1rsynca>, <&clk_l1rclka>; > > + clock-names =3D "l1rsync", "l1rclk"; > > + > > + fsl,common-rxtx-pins; > > + fsl,fsync-rising-edge; > > + > > + fsl,tx-ts-routes =3D < 2 0 >, /* TS 0..1 */ > > + < 24 FSL_CPM_TSA_SCC4 >, /* TS 2..25 */ > > + < 1 0 >, /* TS 26 */ > > + < 5 FSL_CPM_TSA_SCC3 >; /* TS 27..31 */ > > + > > + fsl,rx-ts-routes =3D < 2 0 >, /* TS 0..1 */ > > + < 24 FSL_CPM_TSA_SCC4 >, /* 2..25 */ > > + < 1 0 >, /* TS 26 */ > > + < 5 FSL_CPM_TSA_SCC3 >; /* TS 27..31 */ > > + }; > > + }; > > diff --git a/include/dt-bindings/soc/fsl,tsa.h b/include/dt-bindings/so= c/fsl,tsa.h > > new file mode 100644 > > index 000000000000..2cc44e867dbe > > --- /dev/null > > +++ b/include/dt-bindings/soc/fsl,tsa.h > > @@ -0,0 +1,13 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > > + > > +#ifndef __DT_BINDINGS_SOC_FSL_TSA_H > > +#define __DT_BINDINGS_SOC_FSL_TSA_H > > + > > +#define FSL_CPM_TSA_NU 0 /* Pseuso Cell Id for not used item */ > > +#define FSL_CPM_TSA_SCC2 1 > > +#define FSL_CPM_TSA_SCC3 2 > > +#define FSL_CPM_TSA_SCC4 3 > > +#define FSL_CPM_TSA_SMC1 4 > > +#define FSL_CPM_TSA_SMC2 5 > > + > > +#endif > > --=20 > > 2.38.1 > > =20 Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EF00C38142 for ; Mon, 23 Jan 2023 11:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=49snrWk+fZjEU+aiSCJ1PNIn9TGT8+M9Mn2aD4QTWLo=; b=ICHYdBO+TLzNI7 tsIqQ8dclsJIfI7OYruVUspJlz9j4qZM1ihR/2fW/tv7k1PrqAxGyUDkEVmaQIiMrV+5+w5eRvIhu 6GnUpuytO6nSYEfo6sb0gCUUXobIds91HYZuUXKTjIJzexghJNskxpEt2JJoDTp41v8hgj7bDl6Nw qQQovBNVj+spd6YWrMNI0aUN3vtV/xNCUktM3OHqVisCUeFVJ7wuQjgq3FSCajz8kxVOo3N+arn6K qgdzR4uzSl3fkYmkWRYSb93SJtx1KmE3pPWsr0eI20DDxkXOYu3Z1VYgo7AZqJx/4DG0+xrQ84a0E 0a583B3BkTwCTMBlQCmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJv8M-00Gyz0-TB; Mon, 23 Jan 2023 11:37:07 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJv8I-00Gyy0-Hd for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 11:37:05 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6FC67240008; Mon, 23 Jan 2023 11:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674473815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+igJAl/pqifZR0SzjchX5EdGz+pfJPGF0MNYlXIniw=; b=Vvqt8+5/D4t75o0MWtOWszmDjoeLxz0d8GCcpsXlPFGEQO1h5IYdfDvR0ZBPmABm5ZiMpa ka78Q+jnKGZ43b1E0oh4TOvLRXwDmpLGvLjwiDqiO6hp6nAy2cNcdPyJoKdroPvl3ibrlh M01++3vd0cD96YDOahpAvLZUEfs2hrRS1MQVQlOd9dkRMVWbyPozee6jS0v965m76BM20h QXEkbkYFnAY12818WdmLjliG53OSuBQb4MeEtBbqcB1HDqe4Z4QnpUY/shkyP3x4szYy1p 1rvhbnJoA81ZEiZcFQ0+7E9GUQg/sDWXCr2Qa4tM4nbEOxY+FnNlTOO0427nrw== Date: Mon, 23 Jan 2023 12:36:49 +0100 From: Herve Codina To: Rob Herring Cc: Li Yang , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230123123649.63f17dad@bootlin.com> In-Reply-To: <20230117145529.GA3044055-robh@kernel.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-2-herve.codina@bootlin.com> <20230117145529.GA3044055-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_033702_935960_97856D82 X-CRM114-Status: GOOD ( 38.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9iLAoKT24gVHVlLCAxNyBKYW4gMjAyMyAwODo1NToyOSAtMDYwMApSb2IgSGVycmluZyA8 cm9iaEBrZXJuZWwub3JnPiB3cm90ZToKCj4gT24gRnJpLCBKYW4gMTMsIDIwMjMgYXQgMTE6Mzc6 NTBBTSArMDEwMCwgSGVydmUgQ29kaW5hIHdyb3RlOgo+ID4gQWRkIHN1cHBvcnQgZm9yIHRoZSB0 aW1lIHNsb3QgYXNzaWduZXIgKFRTQSkKPiA+IGF2YWlsYWJsZSBpbiBzb21lIFBvd2VyUVVJQ0Mg U29DIHN1Y2ggYXMgTVBDODg1Cj4gPiBvciBNUEM4NjYuICAKPiAKPiBBbiBvZGQgbGluZSB3cmFw IGxlbmd0aC4uLiAKCldpbGwgYmUgY2hhbmdlZCBpbiB2NC4KCj4gCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IEhlcnZlIENvZGluYSA8aGVydmUuY29kaW5hQGJvb3RsaW4uY29tPgo+ID4gLS0tCj4g PiAgLi4uL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3FlL2ZzbCx0c2EueWFtbCAgICAgIHwgMjYwICsr KysrKysrKysrKysrKysrKwo+ID4gIGluY2x1ZGUvZHQtYmluZGluZ3Mvc29jL2ZzbCx0c2EuaCAg ICAgICAgICAgICB8ICAxMyArCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNzMgaW5zZXJ0aW9ucygr KQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3Mvc29jL2ZzbC9jcG1fcWUvZnNsLHRzYS55YW1sCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGlu Y2x1ZGUvZHQtYmluZGluZ3Mvc29jL2ZzbCx0c2EuaAo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3FlL2ZzbCx0c2EueWFt bCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2MvZnNsL2NwbV9xZS9mc2ws dHNhLnlhbWwKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAu LmViMTdiNjExOWFiZAo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3FlL2ZzbCx0c2EueWFtbAo+ID4gQEAgLTAs MCArMSwyNjAgQEAKPiA+ICsjIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMC1vbmx5 IE9SIEJTRC0yLUNsYXVzZSkKPiA+ICslWUFNTCAxLjIKPiA+ICstLS0KPiA+ICskaWQ6IGh0dHA6 Ly9kZXZpY2V0cmVlLm9yZy9zY2hlbWFzL3NvYy9mc2wvY3BtX3FlL2ZzbCx0c2EueWFtbCMKPiA+ ICskc2NoZW1hOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvbWV0YS1zY2hlbWFzL2NvcmUueWFtbCMK PiA+ICsKPiA+ICt0aXRsZTogUG93ZXJRVUlDQyBDUE0gVGltZS1zbG90IGFzc2lnbmVyIChUU0Ep IGNvbnRyb2xsZXIKPiA+ICsKPiA+ICttYWludGFpbmVyczoKPiA+ICsgIC0gSGVydmUgQ29kaW5h IDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+Cj4gPiArCj4gPiArZGVzY3JpcHRpb246IHwgIAo+ IAo+IERvbid0IG5lZWQgJ3wnIGlmIG5vIGZvcm1hdHRpbmcuCgpXaWxsIGJlIGNoYW5nZWQgaW4g djQuCgo+IAo+ID4gKyAgVGhlIFRTQSBpcyB0aGUgdGltZS1zbG90IGFzc2lnbmVyIHRoYXQgY2Fu IGJlIGZvdW5kIG9uIHNvbWUKPiA+ICsgIFBvd2VyUVVJQ0MgU29DLgo+ID4gKyAgSXRzIHB1cnBv c2UgaXMgdG8gcm91dGUgc29tZSBURE0gdGltZS1zbG90cyB0byBvdGhlciBpbnRlcm5hbAo+ID4g KyAgc2VyaWFsIGNvbnRyb2xsZXJzLiAgCj4gCj4gV3JhcCBhdCA4MC4KCldpbGwgYmUgZml4ZWQg aW4gdjQuCgo+IAo+ID4gKwo+ID4gK3Byb3BlcnRpZXM6Cj4gPiArICBjb21wYXRpYmxlOgo+ID4g KyAgICBpdGVtczoKPiA+ICsgICAgICAtIGVudW06Cj4gPiArICAgICAgICAgIC0gZnNsLG1wYzg4 NS10c2EKPiA+ICsgICAgICAgICAgLSBmc2wsbXBjODY2LXRzYQo+ID4gKyAgICAgIC0gY29uc3Q6 IGZzbCxjcG0xLXRzYQo+ID4gKwo+ID4gKyAgcmVnOgo+ID4gKyAgICBpdGVtczoKPiA+ICsgICAg ICAtIGRlc2NyaXB0aW9uOiBTSSAoU2VyaWFsIEludGVyZmFjZSkgcmVnaXN0ZXIgYmFzZQo+ID4g KyAgICAgIC0gZGVzY3JpcHRpb246IFNJIFJBTSBiYXNlCj4gPiArCj4gPiArICByZWctbmFtZXM6 Cj4gPiArICAgIGl0ZW1zOgo+ID4gKyAgICAgIC0gY29uc3Q6IHNpX3JlZ3MKPiA+ICsgICAgICAt IGNvbnN0OiBzaV9yYW0KPiA+ICsKPiA+ICsgICcjYWRkcmVzcy1jZWxscyc6Cj4gPiArICAgIGNv bnN0OiAxCj4gPiArCj4gPiArICAnI3NpemUtY2VsbHMnOgo+ID4gKyAgICBjb25zdDogMAo+ID4g Kwo+ID4gK3BhdHRlcm5Qcm9wZXJ0aWVzOgo+ID4gKyAgJ150ZG1AWzAtMV0kJzoKPiA+ICsgICAg ZGVzY3JpcHRpb246Cj4gPiArICAgICAgVGhlIFRETSBtYW5hZ2VkIGJ5IHRoaXMgY29udHJvbGxl cgo+ID4gKyAgICB0eXBlOiBvYmplY3QgIAo+IAo+ICAgICAgICBhZGRpdGlvbmFsUHJvcGVydGll czogZmFsc2UKCldpbGwgYmUgYWRkZWQgaW4gdjQuCgo+IAo+ID4gKwo+ID4gKyAgICBwcm9wZXJ0 aWVzOgo+ID4gKyAgICAgIHJlZzoKPiA+ICsgICAgICAgIG1pbmltdW06IDAKPiA+ICsgICAgICAg IG1heGltdW06IDEKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOgo+ID4gKyAgICAgICAgICBUaGUg VERNIG51bWJlciBmb3IgdGhpcyBURE0sIDAgZm9yIFRETWEgYW5kIDEgZm9yIFRETWIKPiA+ICsK PiA+ICsgICAgICBmc2wsY29tbW9uLXJ4dHgtcGluczoKPiA+ICsgICAgICAgICRyZWY6IC9zY2hl bWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL2ZsYWcKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9u Ogo+ID4gKyAgICAgICAgICBUaGUgaGFyZHdhcmUgY2FuIHVzZSBmb3VyIGRlZGljYXRlZCBwaW5z IGZvciBUeCBjbG9jaywKPiA+ICsgICAgICAgICAgVHggc3luYywgUnggY2xvY2sgYW5kIFJ4IHN5 bmMgb3IgdXNlIG9ubHkgdHdvIHBpbnMsCj4gPiArICAgICAgICAgIFR4L1J4IGNsb2NrIGFuZCBS eC9SeCBzeW5jLgo+ID4gKyAgICAgICAgICBXaXRob3V0IHRoZSAnZnNsLGNvbW1vbi1yeHR4LXBp bnMnIHByb3BlcnR5LCB0aGUgZm91cgo+ID4gKyAgICAgICAgICBwaW5zIGFyZSB1c2VkLiBXaXRo IHRoZSAnZnNsLGNvbW1vbi1yeHR4LXBpbnMnIHByb3BlcnR5LAo+ID4gKyAgICAgICAgICB0d28g cGlucyBhcmUgdXNlZC4KPiA+ICsKPiA+ICsgICAgICBjbG9ja3M6Cj4gPiArICAgICAgICBtaW5J dGVtczogMgo+ID4gKyAgICAgICAgbWF4SXRlbXM6IDQKPiA+ICsKPiA+ICsgICAgICBjbG9jay1u YW1lczoKPiA+ICsgICAgICAgIG1pbkl0ZW1zOiAyCj4gPiArICAgICAgICBtYXhJdGVtczogNAo+ ID4gKwo+ID4gKyAgICAgIGZzbCxtb2RlOiAgCj4gCj4gJ21vZGUnIGlzIGEgYml0IHZhZ3VlLiBJ dCdzIGFscmVhZHkgdXNlZCBhcyB3ZWxsIHdoaWNoIGNhbiBiZSBhIHByb2JsZW0gCj4gaWYgdGhl cmUgYXJlIGRpZmZlcmluZyB0eXBlcy4gKFRoZXJlJ3Mgbm90IGluIHRoaXMgY2FzZSkKCldoYXQg ZG8geW91IHRoaW5rIGFib3V0OgogICAgICBmc2wsZGlhZ25vc3RpYy1tb2RlOgogICAgICAgICRy ZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3N0cmluZwogICAgICAgIGVudW06 IFtkaXNhYmxlZCwgZWNobywgaW50ZXJuYWwtbG9vcGJhY2ssIGNvbnRyb2wtbG9vcGJhY2tdCiAg ICAgICAgZGVmYXVsdDogZGlzYWJsZWQKICAgICAgICBkZXNjcmlwdGlvbjogfAogICAgICAgICAg VGhlIGRpYWdub3N0aWMgbW9kZSBjYW4gYmUgdXNlZCB0byBkaWFnbm9zZSBzb21lIGNvbW11bmlj YXRpb24gaXNzdWVzLgogICAgICAgICAgSXQgc2hvdWxkIG5vdCBiZSBwcmVzZW50IChvciBzZXQg dG8gJ2Rpc2FibGVkJykgd2hlbiBkaWFnbm9zdGljIGlzIG5vdAogICAgICAgICAgbmVlZGVkLgog ICAgICAgICAgRGlhZ25vc3RpYyBtb2RlOgogICAgICAgICAgICAtIGRpc2FibGVkOgogICAgICAg ICAgICAgICAgRGlhZ25vc3RpYyBkaXNhYmxlZCAoaWUuIG5vcm1hbCBvcGVyYXRpb24pCiAgICAg ICAgICAgIC0gZWNobzoKICAgICAgICAgICAgICAgIEF1dG9tYXRpYyBlY2hvLiBSeCBkYXRhIGlz IHJlc2VudCBvbiBUeAogICAgICAgICAgICAtIGludGVybmFsLWxvb3BiYWNrOgogICAgICAgICAg ICAgICAgVGhlIFRETSB0cmFuc21pdHRlciBpcyBjb25uZWN0ZWQgdG8gdGhlIHJlY2VpdmVyLgog ICAgICAgICAgICAgICAgRGF0YSBhcHBlYXJzIG9uIFR4IHBpbi4KICAgICAgICAgICAgLSBjb250 cm9sLWxvb3BiYWNrOgogICAgICAgICAgICAgICAgVGhlIFRETSB0cmFuc21pdHRlciBpcyBjb25u ZWN0ZWQgdG8gdGhlIHJlY2VpdmVyLgogICAgICAgICAgICAgICAgVGhlIFR4IHBpbiBpcyBkaXNj b25uZWN0ZWQuCgo+IAo+ID4gKyAgICAgICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVm aW5pdGlvbnMvc3RyaW5nCj4gPiArICAgICAgICBlbnVtOiBbbm9ybWFsLCBlY2hvLCBpbnRlcm5h bC1sb29wYmFjaywgY29udHJvbC1sb29wYmFja10KPiA+ICsgICAgICAgIGRlZmF1bHQ6IG5vcm1h bAo+ID4gKyAgICAgICAgZGVzY3JpcHRpb246IHwKPiA+ICsgICAgICAgICAgT3BlcmF0aW9uYWwg bW9kZToKPiA+ICsgICAgICAgICAgICAtIG5vcm1hbDoKPiA+ICsgICAgICAgICAgICAgICAgTm9y bWFsIG9wZXJhdGlvbgo+ID4gKyAgICAgICAgICAgIC0gZWNobzoKPiA+ICsgICAgICAgICAgICAg ICAgQXV0b21hdGljIGVjaG8uIFJ4IGRhdGEgaXMgcmVzZW50IG9uIFR4Cj4gPiArICAgICAgICAg ICAgLSBpbnRlcm5hbC1sb29wYmFjazoKPiA+ICsgICAgICAgICAgICAgICAgVGhlIFRETSB0cmFu c21pdHRlciBpcyBjb25uZWN0ZWQgdG8gdGhlIHJlY2VpdmVyLgo+ID4gKyAgICAgICAgICAgICAg ICBEYXRhIGFwcGVhcnMgb24gVHggcGluLgo+ID4gKyAgICAgICAgICAgIC0gY29udHJvbC1sb29w YmFjazoKPiA+ICsgICAgICAgICAgICAgICAgVGhlIFRETSB0cmFuc21pdHRlciBpcyBjb25uZWN0 ZWQgdG8gdGhlIHJlY2VpdmVyLgo+ID4gKyAgICAgICAgICAgICAgICBUaGUgVHggcGluIGlzIGRp c2Nvbm5lY3RlZC4KPiA+ICsKPiA+ICsgICAgICBmc2wscngtZnJhbWUtc3luYy1kZWxheS1iaXRz Ogo+ID4gKyAgICAgICAgZW51bTogWzAsIDEsIDIsIDNdCj4gPiArICAgICAgICBkZWZhdWx0OiAw Cj4gPiArICAgICAgICBkZXNjcmlwdGlvbjogfAo+ID4gKyAgICAgICAgICBSZWNlaXZlIGZyYW1l IHN5bmMgZGVsYXkgaW4gbnVtYmVyIG9mIGJpdHMuCj4gPiArICAgICAgICAgIEluZGljYXRlcyB0 aGUgZGVsYXkgYmV0d2VlbiB0aGUgUnggc3luYyBhbmQgdGhlIGZpcnN0IGJpdCBvZiB0aGUKPiA+ ICsgICAgICAgICAgUnggZnJhbWUuIDAgZm9yIG5vIGJpdCBkZWxheS4gMSwgMiBvciAzIGZvciAx LCAyIG9yIDMgYml0cyBkZWxheS4KPiA+ICsKPiA+ICsgICAgICBmc2wsdHgtZnJhbWUtc3luYy1k ZWxheS1iaXRzOgo+ID4gKyAgICAgICAgZW51bTogWzAsIDEsIDIsIDNdCj4gPiArICAgICAgICBk ZWZhdWx0OiAwCj4gPiArICAgICAgICBkZXNjcmlwdGlvbjogfAo+ID4gKyAgICAgICAgICBUcmFu c21pdCBmcmFtZSBzeW5jIGRlbGF5IGluIG51bWJlciBvZiBiaXRzLgo+ID4gKyAgICAgICAgICBJ bmRpY2F0ZXMgdGhlIGRlbGF5IGJldHdlZW4gdGhlIFR4IHN5bmMgYW5kIHRoZSBmaXJzdCBiaXQg b2YgdGhlCj4gPiArICAgICAgICAgIFR4IGZyYW1lLiAwIGZvciBubyBiaXQgZGVsYXkuIDEsIDIg b3IgMyBmb3IgMSwgMiBvciAzIGJpdHMgZGVsYXkuCj4gPiArCj4gPiArICAgICAgZnNsLGNsb2Nr LWZhbGxpbmctZWRnZToKPiA+ICsgICAgICAgICRyZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2Rl ZmluaXRpb25zL2ZsYWcKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOiB8Cj4gPiArICAgICAgICAg IERhdGEgaXMgc2VudCBvbiBmYWxsaW5nIGVkZ2Ugb2YgdGhlIGNsb2NrIChhbmQgcmVjZWl2ZWQg b24gdGhlCj4gPiArICAgICAgICAgIHJpc2luZyBlZGdlKS4KPiA+ICsgICAgICAgICAgSWYgJ2Ns b2NrLWZhbGxpbmctZWRnZScgaXMgbm90IHByZXNlbnQsIGRhdGEgaXMgc2VudCBvbiB0aGUKPiA+ ICsgICAgICAgICAgcmlzaW5nIGVkZ2UgKGFuZCByZWNlaXZlZCBvbiB0aGUgZmFsbGluZyBlZGdl KS4KPiA+ICsKPiA+ICsgICAgICBmc2wsZnN5bmMtcmlzaW5nLWVkZ2U6Cj4gPiArICAgICAgICAk cmVmOiAvc2NoZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy9mbGFnCj4gPiArICAgICAgICBk ZXNjcmlwdGlvbjoKPiA+ICsgICAgICAgICAgRnJhbWUgc3luYyBwdWxzZXMgYXJlIHNhbXBsZWQg d2l0aCB0aGUgcmlzaW5nIGVkZ2Ugb2YgdGhlIGNoYW5uZWwKPiA+ICsgICAgICAgICAgY2xvY2su IElmICdmc3luYy1yaXNpbmctZWRnZScgaXMgbm90IHByZXNlbnQsIHB1bHNlcyBhcmUgc2FtcGxl Cj4gPiArICAgICAgICAgIHdpdGggZSBmYWxsaW5nIGVkZ2UuCj4gPiArCj4gPiArICAgICAgZnNs LGRvdWJsZS1zcGVlZC1jbG9jazoKPiA+ICsgICAgICAgICRyZWY6IC9zY2hlbWFzL3R5cGVzLnlh bWwjL2RlZmluaXRpb25zL2ZsYWcKPiA+ICsgICAgICAgIGRlc2NyaXB0aW9uOgo+ID4gKyAgICAg ICAgICBUaGUgY2hhbm5lbCBjbG9jayBpcyB0d2ljZSB0aGUgZGF0YSByYXRlLgo+ID4gKwo+ID4g KyAgICAgIGZzbCx0eC10cy1yb3V0ZXM6Cj4gPiArICAgICAgICAkcmVmOiAvc2NoZW1hcy90eXBl cy55YW1sIy9kZWZpbml0aW9ucy91aW50MzItbWF0cml4Cj4gPiArICAgICAgICBkZXNjcmlwdGlv bjogfAo+ID4gKyAgICAgICAgICBBIGxpc3Qgb2YgdHVwcGxlIHRoYXQgaW5kaWNhdGVzIHRoZSBU eCB0aW1lLXNsb3RzIHJvdXRlcy4KPiA+ICsgICAgICAgICAgICB0eF90c19yb3V0ZXMgPQo+ID4g KyAgICAgICAgICAgICAgIDwgMiAwID4sIC8qIFRoZSBmaXJzdCAyIHRpbWUgc2xvdHMgYXJlIG5v dCB1c2VkICovCj4gPiArICAgICAgICAgICAgICAgPCAzIDEgPiwgLyogVGhlIG5leHQgMyBvbmVz IGFyZSByb3V0ZSB0byBTQ0MyICovCj4gPiArICAgICAgICAgICAgICAgPCA0IDAgPiwgLyogVGhl IG5leHQgNCBvbmVzIGFyZSBub3QgdXNlZCAqLwo+ID4gKyAgICAgICAgICAgICAgIDwgMiAyID47 IC8qIFRoZSBuZXN0IDIgb25lcyBhcmUgcm91dGUgdG8gU0NDMyAqLwo+ID4gKyAgICAgICAgaXRl bXM6Cj4gPiArICAgICAgICAgIGl0ZW1zOgo+ID4gKyAgICAgICAgICAgIC0gZGVzY3JpcHRpb246 Cj4gPiArICAgICAgICAgICAgICAgIFRoZSBudW1iZXIgb2YgdGltZS1zbG90cwo+ID4gKyAgICAg ICAgICAgICAgbWluaW11bTogMQo+ID4gKyAgICAgICAgICAgICAgbWF4aW11bTogNjQKPiA+ICsg ICAgICAgICAgICAtIGRlc2NyaXB0aW9uOiB8Cj4gPiArICAgICAgICAgICAgICAgIFRoZSBzb3Vy Y2Ugc2VyaWFsIGludGVyZmFjZSAoZHQtYmluZGluZ3Mvc29jL2ZzbCx0c2EuaAo+ID4gKyAgICAg ICAgICAgICAgICBkZWZpbmVzIHRoZXNlIHZhbHVlcykKPiA+ICsgICAgICAgICAgICAgICAgIC0g MDogTm8gZGVzdGluYXRpb24KPiA+ICsgICAgICAgICAgICAgICAgIC0gMTogU0NDMgo+ID4gKyAg ICAgICAgICAgICAgICAgLSAyOiBTQ0MzCj4gPiArICAgICAgICAgICAgICAgICAtIDM6IFNDQzQK PiA+ICsgICAgICAgICAgICAgICAgIC0gNDogU01DMQo+ID4gKyAgICAgICAgICAgICAgICAgLSA1 OiBTTUMyCj4gPiArICAgICAgICAgICAgICBlbnVtOiBbMCwgMSwgMiwgMywgNCwgNV0KPiA+ICsg ICAgICAgIG1pbkl0ZW1zOiAxCj4gPiArICAgICAgICBtYXhJdGVtczogNjQKPiA+ICsKPiA+ICsg ICAgICBmc2wscngtdHMtcm91dGVzOgo+ID4gKyAgICAgICAgJHJlZjogL3NjaGVtYXMvdHlwZXMu eWFtbCMvZGVmaW5pdGlvbnMvdWludDMyLW1hdHJpeAo+ID4gKyAgICAgICAgZGVzY3JpcHRpb246 IHwKPiA+ICsgICAgICAgICAgQSBsaXN0IG9mIHR1cHBsZSB0aGF0IGluZGljYXRlcyB0aGUgUngg dGltZS1zbG90cyByb3V0ZXMuCj4gPiArICAgICAgICAgICAgdHhfdHNfcm91dGVzID0KPiA+ICsg ICAgICAgICAgICAgICA8IDIgMCA+LCAvKiBUaGUgZmlyc3QgMiB0aW1lIHNsb3RzIGFyZSBub3Qg dXNlZCAqLwo+ID4gKyAgICAgICAgICAgICAgIDwgMyAxID4sIC8qIFRoZSBuZXh0IDMgb25lcyBh cmUgcm91dGUgZnJvbSBTQ0MyICovCj4gPiArICAgICAgICAgICAgICAgPCA0IDAgPiwgLyogVGhl IG5leHQgNCBvbmVzIGFyZSBub3QgdXNlZCAqLwo+ID4gKyAgICAgICAgICAgICAgIDwgMiAyID47 IC8qIFRoZSBuZXN0IDIgb25lcyBhcmUgcm91dGUgZnJvbSBTQ0MzICovCj4gPiArICAgICAgICBp dGVtczoKPiA+ICsgICAgICAgICAgaXRlbXM6Cj4gPiArICAgICAgICAgICAgLSBkZXNjcmlwdGlv bjoKPiA+ICsgICAgICAgICAgICAgICAgVGhlIG51bWJlciBvZiB0aW1lLXNsb3RzCj4gPiArICAg ICAgICAgICAgICBtaW5pbXVtOiAxCj4gPiArICAgICAgICAgICAgICBtYXhpbXVtOiA2NAo+ID4g KyAgICAgICAgICAgIC0gZGVzY3JpcHRpb246IHwKPiA+ICsgICAgICAgICAgICAgICAgVGhlIGRl c3RpbmF0aW9uIHNlcmlhbCBpbnRlcmZhY2UgKGR0LWJpbmRpbmdzL3NvYy9mc2wsdHNhLmgKPiA+ ICsgICAgICAgICAgICAgICAgZGVmaW5lcyB0aGVzZSB2YWx1ZXMpCj4gPiArICAgICAgICAgICAg ICAgICAtIDA6IE5vIGRlc3RpbmF0aW9uCj4gPiArICAgICAgICAgICAgICAgICAtIDE6IFNDQzIK PiA+ICsgICAgICAgICAgICAgICAgIC0gMjogU0NDMwo+ID4gKyAgICAgICAgICAgICAgICAgLSAz OiBTQ0M0Cj4gPiArICAgICAgICAgICAgICAgICAtIDQ6IFNNQzEKPiA+ICsgICAgICAgICAgICAg ICAgIC0gNTogU01DMgo+ID4gKyAgICAgICAgICAgICAgZW51bTogWzAsIDEsIDIsIDMsIDQsIDVd Cj4gPiArICAgICAgICBtaW5JdGVtczogMQo+ID4gKyAgICAgICAgbWF4SXRlbXM6IDY0Cj4gPiAr Cj4gPiArICAgIGFsbE9mOgo+ID4gKyAgICAgICMgSWYgZnNsLGNvbW1vbi1yeHR4LXBpbnMgaXMg cHJlc2VudCwgb25seSAyIGNsb2NrcyBhcmUgbmVlZGVkLgo+ID4gKyAgICAgICMgRWxzZSwgdGhl IDQgY2xvY2tzIG11c3QgYmUgcHJlc2VudC4KPiA+ICsgICAgICAtIGlmOgo+ID4gKyAgICAgICAg ICByZXF1aXJlZDoKPiA+ICsgICAgICAgICAgICAtIGZzbCxjb21tb24tcnh0eC1waW5zCj4gPiAr ICAgICAgICB0aGVuOgo+ID4gKyAgICAgICAgICBwcm9wZXJ0aWVzOgo+ID4gKyAgICAgICAgICAg IGNsb2NrczoKPiA+ICsgICAgICAgICAgICAgIGl0ZW1zOgo+ID4gKyAgICAgICAgICAgICAgICAt IGRlc2NyaXB0aW9uOiBFeHRlcm5hbCBjbG9jayBjb25uZWN0ZWQgdG8gTDFSU1lOQyBwaW4KPiA+ ICsgICAgICAgICAgICAgICAgLSBkZXNjcmlwdGlvbjogRXh0ZXJuYWwgY2xvY2sgY29ubmVjdGVk IHRvIEwxUkNMSyBwaW4KPiA+ICsgICAgICAgICAgICBjbG9jay1uYW1lczoKPiA+ICsgICAgICAg ICAgICAgIGl0ZW1zOgo+ID4gKyAgICAgICAgICAgICAgICAtIGNvbnN0OiBsMXJzeW5jCj4gPiAr ICAgICAgICAgICAgICAgIC0gY29uc3Q6IGwxcmNsawo+ID4gKyAgICAgICAgZWxzZToKPiA+ICsg ICAgICAgICAgcHJvcGVydGllczoKPiA+ICsgICAgICAgICAgICBjbG9ja3M6Cj4gPiArICAgICAg ICAgICAgICBpdGVtczoKPiA+ICsgICAgICAgICAgICAgICAgLSBkZXNjcmlwdGlvbjogRXh0ZXJu YWwgY2xvY2sgY29ubmVjdGVkIHRvIEwxUlNZTkMgcGluCj4gPiArICAgICAgICAgICAgICAgIC0g ZGVzY3JpcHRpb246IEV4dGVybmFsIGNsb2NrIGNvbm5lY3RlZCB0byBMMVJDTEsgcGluCj4gPiAr ICAgICAgICAgICAgICAgIC0gZGVzY3JpcHRpb246IEV4dGVybmFsIGNsb2NrIGNvbm5lY3RlZCB0 byBMMVRTWU5DIHBpbgo+ID4gKyAgICAgICAgICAgICAgICAtIGRlc2NyaXB0aW9uOiBFeHRlcm5h bCBjbG9jayBjb25uZWN0ZWQgdG8gTDFUQ0xLIHBpbgo+ID4gKyAgICAgICAgICAgIGNsb2NrLW5h bWVzOgo+ID4gKyAgICAgICAgICAgICAgaXRlbXM6Cj4gPiArICAgICAgICAgICAgICAgIC0gY29u c3Q6IGwxcnN5bmMKPiA+ICsgICAgICAgICAgICAgICAgLSBjb25zdDogbDFyY2xrCj4gPiArICAg ICAgICAgICAgICAgIC0gY29uc3Q6IGwxdHN5bmMKPiA+ICsgICAgICAgICAgICAgICAgLSBjb25z dDogbDF0Y2xrICAKPiAKPiBBcyB0aGUgbmFtZXMgYXJlIHRoZSBzYW1lLCBqdXN0IHRoZSBsZW5n dGggdmFyaWVzIGJldHdlZW4gMiBvciA0LCBtb3ZlIAo+IGFsbCB0aGlzIHRvIHRoZSBtYWluIGRl ZmluaXRpb24gYW5kIGhlcmUganVzdCBwdXQgY29uc3RyYWludHMgb24gdGhlIAo+IGxlbmd0aC4K Ck9rLCB3aWxsIGJlIGRvbmUgaW4gdjQuCgo+IAo+ID4gKwo+ID4gKyAgICByZXF1aXJlZDoKPiA+ ICsgICAgICAtIHJlZwo+ID4gKyAgICAgIC0gY2xvY2tzCj4gPiArICAgICAgLSBjbG9jay1uYW1l cwo+ID4gKwo+ID4gK3JlcXVpcmVkOgo+ID4gKyAgLSBjb21wYXRpYmxlCj4gPiArICAtIHJlZwo+ ID4gKyAgLSByZWctbmFtZXMKPiA+ICsgIC0gJyNhZGRyZXNzLWNlbGxzJwo+ID4gKyAgLSAnI3Np emUtY2VsbHMnCj4gPiArCj4gPiArYWRkaXRpb25hbFByb3BlcnRpZXM6IGZhbHNlCj4gPiArCj4g PiArZXhhbXBsZXM6Cj4gPiArICAtIHwKPiA+ICsgICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL3Nv Yy9mc2wsdHNhLmg+Cj4gPiArCj4gPiArICAgIHRzYUBhZTAgewo+ID4gKyAgICAgICAgY29tcGF0 aWJsZSA9ICJmc2wsbXBjODg1LXRzYSIsICJmc2wsY3BtMS10c2EiOwo+ID4gKyAgICAgICAgcmVn ID0gPDB4YWUwIDB4MTA+LAo+ID4gKyAgICAgICAgICAgICAgPDB4YzAwIDB4MjAwPjsKPiA+ICsg ICAgICAgIHJlZy1uYW1lcyA9ICJzaV9yZWdzIiwgInNpX3JhbSI7Cj4gPiArCj4gPiArICAgICAg ICAjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+ICsgICAgICAgICNzaXplLWNlbGxzID0gPDA+Owo+ ID4gKwo+ID4gKyAgICAgICAgdGRtQDAgewo+ID4gKyAgICAgICAgICAgIC8qIFRETWEgKi8KPiA+ ICsgICAgICAgICAgICByZWcgPSA8MD47Cj4gPiArCj4gPiArICAgICAgICAgICAgY2xvY2tzID0g PCZjbGtfbDFyc3luY2E+LCA8JmNsa19sMXJjbGthPjsKPiA+ICsgICAgICAgICAgICBjbG9jay1u YW1lcyA9ICJsMXJzeW5jIiwgImwxcmNsayI7Cj4gPiArCj4gPiArICAgICAgICAgICAgZnNsLGNv bW1vbi1yeHR4LXBpbnM7Cj4gPiArICAgICAgICAgICAgZnNsLGZzeW5jLXJpc2luZy1lZGdlOwo+ ID4gKwo+ID4gKyAgICAgICAgICAgIGZzbCx0eC10cy1yb3V0ZXMgPSA8IDIgMCA+LCAgICAgICAg ICAgICAvKiBUUyAwLi4xICovCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgPCAyNCBG U0xfQ1BNX1RTQV9TQ0M0ID4sIC8qIFRTIDIuLjI1ICovCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgPCAxIDAgPiwgICAgICAgICAgICAgICAgIC8qIFRTIDI2ICovCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgPCA1IEZTTF9DUE1fVFNBX1NDQzMgPjsgIC8qIFRTIDI3Li4z MSAqLwo+ID4gKwo+ID4gKyAgICAgICAgICAgIGZzbCxyeC10cy1yb3V0ZXMgPSA8IDIgMCA+LCAg ICAgICAgICAgICAvKiBUUyAwLi4xICovCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg PCAyNCBGU0xfQ1BNX1RTQV9TQ0M0ID4sIC8qIDIuLjI1ICovCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgPCAxIDAgPiwgICAgICAgICAgICAgICAgIC8qIFRTIDI2ICovCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgPCA1IEZTTF9DUE1fVFNBX1NDQzMgPjsgIC8qIFRTIDI3 Li4zMSAqLwo+ID4gKyAgICAgICAgfTsKPiA+ICsgICAgfTsKPiA+IGRpZmYgLS1naXQgYS9pbmNs dWRlL2R0LWJpbmRpbmdzL3NvYy9mc2wsdHNhLmggYi9pbmNsdWRlL2R0LWJpbmRpbmdzL3NvYy9m c2wsdHNhLmgKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAu LjJjYzQ0ZTg2N2RiZQo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIvaW5jbHVkZS9kdC1iaW5k aW5ncy9zb2MvZnNsLHRzYS5oCj4gPiBAQCAtMCwwICsxLDEzIEBACj4gPiArLyogU1BEWC1MaWNl bnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seSBPUiBCU0QtMi1DbGF1c2UgKi8KPiA+ICsKPiA+ ICsjaWZuZGVmIF9fRFRfQklORElOR1NfU09DX0ZTTF9UU0FfSAo+ID4gKyNkZWZpbmUgX19EVF9C SU5ESU5HU19TT0NfRlNMX1RTQV9ICj4gPiArCj4gPiArI2RlZmluZSBGU0xfQ1BNX1RTQV9OVQkJ MAkvKiBQc2V1c28gQ2VsbCBJZCBmb3Igbm90IHVzZWQgaXRlbSAqLwo+ID4gKyNkZWZpbmUgRlNM X0NQTV9UU0FfU0NDMgkxCj4gPiArI2RlZmluZSBGU0xfQ1BNX1RTQV9TQ0MzCTIKPiA+ICsjZGVm aW5lIEZTTF9DUE1fVFNBX1NDQzQJMwo+ID4gKyNkZWZpbmUgRlNMX0NQTV9UU0FfU01DMQk0Cj4g PiArI2RlZmluZSBGU0xfQ1BNX1RTQV9TTUMyCTUKPiA+ICsKPiA+ICsjZW5kaWYKPiA+IC0tIAo+ ID4gMi4zOC4xCj4gPiAgIAoKVGhhbmtzIGZvciB0aGUgcmV2aWV3LAoKSGVydsOpCi0tIApIZXJ2 w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcK aHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61AFCC05027 for ; Mon, 23 Jan 2023 11:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbjAWLhA (ORCPT ); Mon, 23 Jan 2023 06:37:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjAWLhA (ORCPT ); Mon, 23 Jan 2023 06:37:00 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DB821E1CB; Mon, 23 Jan 2023 03:36:57 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6FC67240008; Mon, 23 Jan 2023 11:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674473815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+igJAl/pqifZR0SzjchX5EdGz+pfJPGF0MNYlXIniw=; b=Vvqt8+5/D4t75o0MWtOWszmDjoeLxz0d8GCcpsXlPFGEQO1h5IYdfDvR0ZBPmABm5ZiMpa ka78Q+jnKGZ43b1E0oh4TOvLRXwDmpLGvLjwiDqiO6hp6nAy2cNcdPyJoKdroPvl3ibrlh M01++3vd0cD96YDOahpAvLZUEfs2hrRS1MQVQlOd9dkRMVWbyPozee6jS0v965m76BM20h QXEkbkYFnAY12818WdmLjliG53OSuBQb4MeEtBbqcB1HDqe4Z4QnpUY/shkyP3x4szYy1p 1rvhbnJoA81ZEiZcFQ0+7E9GUQg/sDWXCr2Qa4tM4nbEOxY+FnNlTOO0427nrw== Date: Mon, 23 Jan 2023 12:36:49 +0100 From: Herve Codina To: Rob Herring Cc: Li Yang , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230123123649.63f17dad@bootlin.com> In-Reply-To: <20230117145529.GA3044055-robh@kernel.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-2-herve.codina@bootlin.com> <20230117145529.GA3044055-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Tue, 17 Jan 2023 08:55:29 -0600 Rob Herring wrote: > On Fri, Jan 13, 2023 at 11:37:50AM +0100, Herve Codina wrote: > > Add support for the time slot assigner (TSA) > > available in some PowerQUICC SoC such as MPC885 > > or MPC866. =20 >=20 > An odd line wrap length...=20 Will be changed in v4. >=20 > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,tsa.yaml | 260 ++++++++++++++++++ > > include/dt-bindings/soc/fsl,tsa.h | 13 + > > 2 files changed, 273 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,tsa.yaml > > create mode 100644 include/dt-bindings/soc/fsl,tsa.h > >=20 > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.y= aml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.yaml > > new file mode 100644 > > index 000000000000..eb17b6119abd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,tsa.yaml > > @@ -0,0 +1,260 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,tsa.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PowerQUICC CPM Time-slot assigner (TSA) controller > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | =20 >=20 > Don't need '|' if no formatting. Will be changed in v4. >=20 > > + The TSA is the time-slot assigner that can be found on some > > + PowerQUICC SoC. > > + Its purpose is to route some TDM time-slots to other internal > > + serial controllers. =20 >=20 > Wrap at 80. Will be fixed in v4. >=20 > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - fsl,mpc885-tsa > > + - fsl,mpc866-tsa > > + - const: fsl,cpm1-tsa > > + > > + reg: > > + items: > > + - description: SI (Serial Interface) register base > > + - description: SI RAM base > > + > > + reg-names: > > + items: > > + - const: si_regs > > + - const: si_ram > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > +patternProperties: > > + '^tdm@[0-1]$': > > + description: > > + The TDM managed by this controller > > + type: object =20 >=20 > additionalProperties: false Will be added in v4. >=20 > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 1 > > + description: > > + The TDM number for this TDM, 0 for TDMa and 1 for TDMb > > + > > + fsl,common-rxtx-pins: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The hardware can use four dedicated pins for Tx clock, > > + Tx sync, Rx clock and Rx sync or use only two pins, > > + Tx/Rx clock and Rx/Rx sync. > > + Without the 'fsl,common-rxtx-pins' property, the four > > + pins are used. With the 'fsl,common-rxtx-pins' property, > > + two pins are used. > > + > > + clocks: > > + minItems: 2 > > + maxItems: 4 > > + > > + clock-names: > > + minItems: 2 > > + maxItems: 4 > > + > > + fsl,mode: =20 >=20 > 'mode' is a bit vague. It's already used as well which can be a problem=20 > if there are differing types. (There's not in this case) What do you think about: fsl,diagnostic-mode: $ref: /schemas/types.yaml#/definitions/string enum: [disabled, echo, internal-loopback, control-loopback] default: disabled description: | The diagnostic mode can be used to diagnose some communication is= sues. It should not be present (or set to 'disabled') when diagnostic i= s not needed. Diagnostic mode: - disabled: Diagnostic disabled (ie. normal operation) - echo: Automatic echo. Rx data is resent on Tx - internal-loopback: The TDM transmitter is connected to the receiver. Data appears on Tx pin. - control-loopback: The TDM transmitter is connected to the receiver. The Tx pin is disconnected. >=20 > > + $ref: /schemas/types.yaml#/definitions/string > > + enum: [normal, echo, internal-loopback, control-loopback] > > + default: normal > > + description: | > > + Operational mode: > > + - normal: > > + Normal operation > > + - echo: > > + Automatic echo. Rx data is resent on Tx > > + - internal-loopback: > > + The TDM transmitter is connected to the receiver. > > + Data appears on Tx pin. > > + - control-loopback: > > + The TDM transmitter is connected to the receiver. > > + The Tx pin is disconnected. > > + > > + fsl,rx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] > > + default: 0 > > + description: | > > + Receive frame sync delay in number of bits. > > + Indicates the delay between the Rx sync and the first bit of= the > > + Rx frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits d= elay. > > + > > + fsl,tx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] > > + default: 0 > > + description: | > > + Transmit frame sync delay in number of bits. > > + Indicates the delay between the Tx sync and the first bit of= the > > + Tx frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits d= elay. > > + > > + fsl,clock-falling-edge: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: | > > + Data is sent on falling edge of the clock (and received on t= he > > + rising edge). > > + If 'clock-falling-edge' is not present, data is sent on the > > + rising edge (and received on the falling edge). > > + > > + fsl,fsync-rising-edge: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Frame sync pulses are sampled with the rising edge of the ch= annel > > + clock. If 'fsync-rising-edge' is not present, pulses are sam= ple > > + with e falling edge. > > + > > + fsl,double-speed-clock: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + The channel clock is twice the data rate. > > + > > + fsl,tx-ts-routes: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + description: | > > + A list of tupple that indicates the Tx time-slots routes. > > + tx_ts_routes =3D > > + < 2 0 >, /* The first 2 time slots are not used */ > > + < 3 1 >, /* The next 3 ones are route to SCC2 */ > > + < 4 0 >, /* The next 4 ones are not used */ > > + < 2 2 >; /* The nest 2 ones are route to SCC3 */ > > + items: > > + items: > > + - description: > > + The number of time-slots > > + minimum: 1 > > + maximum: 64 > > + - description: | > > + The source serial interface (dt-bindings/soc/fsl,tsa.h > > + defines these values) > > + - 0: No destination > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 > > + - 4: SMC1 > > + - 5: SMC2 > > + enum: [0, 1, 2, 3, 4, 5] > > + minItems: 1 > > + maxItems: 64 > > + > > + fsl,rx-ts-routes: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + description: | > > + A list of tupple that indicates the Rx time-slots routes. > > + tx_ts_routes =3D > > + < 2 0 >, /* The first 2 time slots are not used */ > > + < 3 1 >, /* The next 3 ones are route from SCC2 */ > > + < 4 0 >, /* The next 4 ones are not used */ > > + < 2 2 >; /* The nest 2 ones are route from SCC3 */ > > + items: > > + items: > > + - description: > > + The number of time-slots > > + minimum: 1 > > + maximum: 64 > > + - description: | > > + The destination serial interface (dt-bindings/soc/fsl,= tsa.h > > + defines these values) > > + - 0: No destination > > + - 1: SCC2 > > + - 2: SCC3 > > + - 3: SCC4 > > + - 4: SMC1 > > + - 5: SMC2 > > + enum: [0, 1, 2, 3, 4, 5] > > + minItems: 1 > > + maxItems: 64 > > + > > + allOf: > > + # If fsl,common-rxtx-pins is present, only 2 clocks are needed. > > + # Else, the 4 clocks must be present. > > + - if: > > + required: > > + - fsl,common-rxtx-pins > > + then: > > + properties: > > + clocks: > > + items: > > + - description: External clock connected to L1RSYNC pin > > + - description: External clock connected to L1RCLK pin > > + clock-names: > > + items: > > + - const: l1rsync > > + - const: l1rclk > > + else: > > + properties: > > + clocks: > > + items: > > + - description: External clock connected to L1RSYNC pin > > + - description: External clock connected to L1RCLK pin > > + - description: External clock connected to L1TSYNC pin > > + - description: External clock connected to L1TCLK pin > > + clock-names: > > + items: > > + - const: l1rsync > > + - const: l1rclk > > + - const: l1tsync > > + - const: l1tclk =20 >=20 > As the names are the same, just the length varies between 2 or 4, move=20 > all this to the main definition and here just put constraints on the=20 > length. Ok, will be done in v4. >=20 > > + > > + required: > > + - reg > > + - clocks > > + - clock-names > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - '#address-cells' > > + - '#size-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + tsa@ae0 { > > + compatible =3D "fsl,mpc885-tsa", "fsl,cpm1-tsa"; > > + reg =3D <0xae0 0x10>, > > + <0xc00 0x200>; > > + reg-names =3D "si_regs", "si_ram"; > > + > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + tdm@0 { > > + /* TDMa */ > > + reg =3D <0>; > > + > > + clocks =3D <&clk_l1rsynca>, <&clk_l1rclka>; > > + clock-names =3D "l1rsync", "l1rclk"; > > + > > + fsl,common-rxtx-pins; > > + fsl,fsync-rising-edge; > > + > > + fsl,tx-ts-routes =3D < 2 0 >, /* TS 0..1 */ > > + < 24 FSL_CPM_TSA_SCC4 >, /* TS 2..25 */ > > + < 1 0 >, /* TS 26 */ > > + < 5 FSL_CPM_TSA_SCC3 >; /* TS 27..31 */ > > + > > + fsl,rx-ts-routes =3D < 2 0 >, /* TS 0..1 */ > > + < 24 FSL_CPM_TSA_SCC4 >, /* 2..25 */ > > + < 1 0 >, /* TS 26 */ > > + < 5 FSL_CPM_TSA_SCC3 >; /* TS 27..31 */ > > + }; > > + }; > > diff --git a/include/dt-bindings/soc/fsl,tsa.h b/include/dt-bindings/so= c/fsl,tsa.h > > new file mode 100644 > > index 000000000000..2cc44e867dbe > > --- /dev/null > > +++ b/include/dt-bindings/soc/fsl,tsa.h > > @@ -0,0 +1,13 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > > + > > +#ifndef __DT_BINDINGS_SOC_FSL_TSA_H > > +#define __DT_BINDINGS_SOC_FSL_TSA_H > > + > > +#define FSL_CPM_TSA_NU 0 /* Pseuso Cell Id for not used item */ > > +#define FSL_CPM_TSA_SCC2 1 > > +#define FSL_CPM_TSA_SCC3 2 > > +#define FSL_CPM_TSA_SCC4 3 > > +#define FSL_CPM_TSA_SMC1 4 > > +#define FSL_CPM_TSA_SMC2 5 > > + > > +#endif > > --=20 > > 2.38.1 > > =20 Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com