From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>
Subject: [PATCH v1 1/3] ACPI: video: Fix refcounting in apple_gmux_backlight_present()
Date: Mon, 23 Jan 2023 19:10:04 +0200 [thread overview]
Message-ID: <20230123171006.58274-1-andriy.shevchenko@linux.intel.com> (raw)
acpi_dev_get_first_match_dev() gets ACPI device with the bumped
refcount. The caller must drop it when it's done.
Fix ACPI device refcounting in apple_gmux_backlight_present().
Fixes: 3cf3b7f012f3 ("ACPI: video: Fix Apple GMUX backlight detection")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/video_detect.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 65cec7bb6d96..0ccde0d4c527 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -114,12 +114,14 @@ static bool apple_gmux_backlight_present(void)
{
struct acpi_device *adev;
struct device *dev;
+ bool ret;
adev = acpi_dev_get_first_match_dev(GMUX_ACPI_HID, NULL, -1);
if (!adev)
return false;
- dev = acpi_get_first_physical_node(adev);
+ dev = get_device(acpi_get_first_physical_node(adev));
+ acpi_dev_put(adev);
if (!dev)
return false;
@@ -127,7 +129,9 @@ static bool apple_gmux_backlight_present(void)
* drivers/platform/x86/apple-gmux.c only supports old style
* Apple GMUX with an IO-resource.
*/
- return pnp_get_resource(to_pnp_dev(dev), IORESOURCE_IO, 0) != NULL;
+ ret = pnp_get_resource(to_pnp_dev(dev), IORESOURCE_IO, 0) != NULL;
+ put_device(dev);
+ return ret;
}
/* Force to use vendor driver when the ACPI device is known to be
--
2.39.0
next reply other threads:[~2023-01-23 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 17:10 Andy Shevchenko [this message]
2023-01-23 17:10 ` [PATCH v1 2/3] ACPI: utils: Add acpi_get_first_match_physical_node() Andy Shevchenko
2023-01-25 15:21 ` Andy Shevchenko
2023-01-23 17:10 ` [PATCH v1 3/3] ACPI: video: Switch to use acpi_get_first_match_physical_node() Andy Shevchenko
2023-01-23 17:46 ` [PATCH v1 1/3] ACPI: video: Fix refcounting in apple_gmux_backlight_present() Hans de Goede
2023-01-23 18:18 ` Andy Shevchenko
2023-01-23 19:24 ` Rafael J. Wysocki
2023-01-24 9:04 ` Andy Shevchenko
2023-01-23 22:10 ` Hans de Goede
2023-01-24 9:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123171006.58274-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.