From: Jakub Kicinski <kuba@kernel.org>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Neal Cardwell <ncardwell@google.com>,
selinux@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Eric Paris <eparis@parisplace.org>,
kernel-team@cloudflare.com,
Marek Majkowski <marek@cloudflare.com>
Subject: Re: [PATCH net-next v4 1/2] inet: Add IP_LOCAL_PORT_RANGE socket option
Date: Mon, 23 Jan 2023 19:35:26 -0800 [thread overview]
Message-ID: <20230123193526.065a9879@kernel.org> (raw)
In-Reply-To: <87sfg1vuqj.fsf@cloudflare.com>
On Mon, 23 Jan 2023 21:48:06 +0100 Jakub Sitnicki wrote:
> >> v1 -> v2:
> >> * Fix the corner case when the per-socket range doesn't overlap with the
> >> per-netns range. Fallback correctly to the per-netns range. (Kuniyuki)
> >
> > Please put changelog after "---" trailer, so it will be stripped while
> > applying patch.
>
> I've put the changelog above the "---" on purpose. AFAIK, it is (was?)
> preferred by netdev maintainers to keep the changelog in the
> description.
>
> Do you know if this convention is now a thing of the past? I might have
> missed something.
It used to be, the jury is still out on which way is better.
When Paolo/I apply the patch we add a lore link, so the changelog
can be found easily even if it's cut off from git history.
OTOH DaveM/Linus are not fans of slapping the lore links on every
single patch, so DaveM may still prefer the changelog above ---.
Sorry, that's not very helpful, you're both right in a way.
next prev parent reply other threads:[~2023-01-24 3:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 14:44 [PATCH net-next v4 0/2] Add IP_LOCAL_PORT_RANGE socket option Jakub Sitnicki
2023-01-23 14:44 ` [PATCH net-next v4 1/2] inet: " Jakub Sitnicki
2023-01-23 17:47 ` Leon Romanovsky
2023-01-23 20:48 ` Jakub Sitnicki
2023-01-24 3:35 ` Jakub Kicinski [this message]
2023-01-23 17:55 ` Kuniyuki Iwashima
2023-01-23 20:46 ` Jakub Sitnicki
2023-01-23 14:44 ` [PATCH net-next v4 2/2] selftests/net: Cover the " Jakub Sitnicki
2023-01-23 17:58 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123193526.065a9879@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eparis@parisplace.org \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=kuniyu@amazon.com \
--cc=leon@kernel.org \
--cc=marek@cloudflare.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.