All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [ammarfaizi2-block:google/android/kernel/common/android-4.14-q 1/1] drivers/usb/gadget/function/f_accessory.c:1008:5: warning: no previous declaration for 'acc_ctrlrequest_composite'
Date: Tue, 24 Jan 2023 04:34:03 +0800	[thread overview]
Message-ID: <202301240453.JfRh7ner-lkp@intel.com> (raw)

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android-4.14-q
head:   6e193ecd7a65f41aabc219c33deccd3152fde14c
commit: 6e193ecd7a65f41aabc219c33deccd3152fde14c [1/1] ANDROID: usb: f_accessory: Check buffer size when initialised via composite
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230124/202301240453.JfRh7ner-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/6e193ecd7a65f41aabc219c33deccd3152fde14c
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android-4.14-q
        git checkout 6e193ecd7a65f41aabc219c33deccd3152fde14c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/usb/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/usb/gadget/function/f_accessory.c:897:5: warning: no previous declaration for 'acc_ctrlrequest' [-Wmissing-declarations]
    int acc_ctrlrequest(struct usb_composite_dev *cdev,
        ^~~~~~~~~~~~~~~
>> drivers/usb/gadget/function/f_accessory.c:1008:5: warning: no previous declaration for 'acc_ctrlrequest_composite' [-Wmissing-declarations]
    int acc_ctrlrequest_composite(struct usb_composite_dev *cdev,
        ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/gadget/function/f_accessory.c:1335:6: warning: no previous declaration for 'acc_disconnect' [-Wmissing-declarations]
    void acc_disconnect(void)
         ^~~~~~~~~~~~~~
   drivers/usb/gadget/function/f_accessory.c:1440:5: warning: no previous declaration for 'acc_ctrlrequest_configfs' [-Wmissing-declarations]
    int acc_ctrlrequest_configfs(struct usb_function *f,
        ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/acc_ctrlrequest_composite +1008 drivers/usb/gadget/function/f_accessory.c

  1007	
> 1008	int acc_ctrlrequest_composite(struct usb_composite_dev *cdev,
  1009				      const struct usb_ctrlrequest *ctrl)
  1010	{
  1011		u16 w_length = le16_to_cpu(ctrl->wLength);
  1012	
  1013		if (w_length > USB_COMP_EP0_BUFSIZ) {
  1014			if (ctrl->bRequestType & USB_DIR_IN) {
  1015				/* Cast away the const, we are going to overwrite on purpose. */
  1016				__le16 *temp = (__le16 *)&ctrl->wLength;
  1017	
  1018				*temp = cpu_to_le16(USB_COMP_EP0_BUFSIZ);
  1019				w_length = USB_COMP_EP0_BUFSIZ;
  1020			} else {
  1021				return -EINVAL;
  1022			}
  1023		}
  1024		return acc_ctrlrequest(cdev, ctrl);
  1025	}
  1026	EXPORT_SYMBOL_GPL(acc_ctrlrequest_composite);
  1027	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

                 reply	other threads:[~2023-01-23 20:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202301240453.JfRh7ner-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.