All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 09/25] ASoC: rt: use helper function
Date: Tue, 24 Jan 2023 12:45:34 +0800	[thread overview]
Message-ID: <202301241201.jBsUFSYu-lkp@intel.com> (raw)
In-Reply-To: <87lelsu1gz.wl-kuninori.morimoto.gx@renesas.com>

Hi Kuninori,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on tegra/for-next rockchip/for-next linus/master v6.2-rc5 next-20230123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuninori-Morimoto/ASoC-soc-dai-h-add-missing-snd_soc_dai_set_widget/20230124-102030
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/87lelsu1gz.wl-kuninori.morimoto.gx%40renesas.com
patch subject: [PATCH v2 09/25] ASoC: rt: use helper function
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230124/202301241201.jBsUFSYu-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/26f9b884f20e9f6837c9017ab89747d8381a55c8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kuninori-Morimoto/ASoC-soc-dai-h-add-missing-snd_soc_dai_set_widget/20230124-102030
        git checkout 26f9b884f20e9f6837c9017ab89747d8381a55c8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash sound/soc/codecs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   sound/soc/codecs/rt1318-sdw.c: In function 'rt1318_set_sdw_stream':
   sound/soc/codecs/rt1318-sdw.c:578:12: error: 'struct snd_soc_dai' has no member named 'stream'
     578 |         dai->stream[direction].dma_data = stream;
         |            ^~
>> sound/soc/codecs/rt1318-sdw.c:564:37: warning: parameter 'direction' set but not used [-Wunused-but-set-parameter]
     564 |                                 int direction)
         |                                 ~~~~^~~~~~~~~


vim +/direction +564 sound/soc/codecs/rt1318-sdw.c

6ad73a2b42ea6d Shuming Fan       2022-11-08  562  
6ad73a2b42ea6d Shuming Fan       2022-11-08  563  static int rt1318_set_sdw_stream(struct snd_soc_dai *dai, void *sdw_stream,
6ad73a2b42ea6d Shuming Fan       2022-11-08 @564  				int direction)
6ad73a2b42ea6d Shuming Fan       2022-11-08  565  {
6ad73a2b42ea6d Shuming Fan       2022-11-08  566  	struct sdw_stream_data *stream;
6ad73a2b42ea6d Shuming Fan       2022-11-08  567  
6ad73a2b42ea6d Shuming Fan       2022-11-08  568  	if (!sdw_stream)
6ad73a2b42ea6d Shuming Fan       2022-11-08  569  		return 0;
6ad73a2b42ea6d Shuming Fan       2022-11-08  570  
6ad73a2b42ea6d Shuming Fan       2022-11-08  571  	stream = kzalloc(sizeof(*stream), GFP_KERNEL);
6ad73a2b42ea6d Shuming Fan       2022-11-08  572  	if (!stream)
6ad73a2b42ea6d Shuming Fan       2022-11-08  573  		return -ENOMEM;
6ad73a2b42ea6d Shuming Fan       2022-11-08  574  
6ad73a2b42ea6d Shuming Fan       2022-11-08  575  	stream->sdw_stream = sdw_stream;
6ad73a2b42ea6d Shuming Fan       2022-11-08  576  
6ad73a2b42ea6d Shuming Fan       2022-11-08  577  	/* Use tx_mask or rx_mask to configure stream tag and set dma_data */
26f9b884f20e9f Kuninori Morimoto 2023-01-24  578  	dai->stream[direction].dma_data = stream;
6ad73a2b42ea6d Shuming Fan       2022-11-08  579  
6ad73a2b42ea6d Shuming Fan       2022-11-08  580  	return 0;
6ad73a2b42ea6d Shuming Fan       2022-11-08  581  }
6ad73a2b42ea6d Shuming Fan       2022-11-08  582  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

  reply	other threads:[~2023-01-24  4:45 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24  2:07 [PATCH v2 00/25] ASoC: use helper function and cleanup Kuninori Morimoto
2023-01-24  2:07 ` [PATCH v2 01/25] ASoC: soc-dai.h: add missing snd_soc_dai_set_widget() Kuninori Morimoto
2023-01-24  2:07 ` [PATCH v2 02/25] ASoC: soc-dai.h: add snd_soc_dai_dma_data_set/get() for low level Kuninori Morimoto
2023-01-24  2:08 ` [PATCH v2 03/25] ASoC: soc-dai.h: add snd_soc_dai_tdm_mask_set/get() helper Kuninori Morimoto
2023-01-24  2:08 ` [PATCH v2 04/25] ASoC: soc-dai.h: add snd_soc_dai_get/set_widget_playback/capture() helper Kuninori Morimoto
2023-01-24  2:08 ` [PATCH v2 05/25] ASoC: soc.h: add snd_soc_card_is_instantiated() helper Kuninori Morimoto
2023-01-24  2:08 ` [PATCH v2 06/25] ASoC: hdmi-codec: use helper function Kuninori Morimoto
2023-01-24  2:09 ` [PATCH v2 07/25] ASoC: hda: " Kuninori Morimoto
2023-01-24  2:09 ` [PATCH v2 08/25] ASoC: max: " Kuninori Morimoto
2023-01-24  2:10 ` [PATCH v2 09/25] ASoC: rt: " Kuninori Morimoto
2023-01-24  4:45   ` kernel test robot [this message]
2023-01-24  6:25     ` Kuninori Morimoto
2023-01-30 14:18   ` Mark Brown
2023-01-24  2:10 ` [PATCH v2 10/25] ASoC: cirrus: " Kuninori Morimoto
2023-01-24  2:11 ` [PATCH v2 11/25] ASoC: spear: " Kuninori Morimoto
2023-01-24  2:11 ` [PATCH v2 12/25] ASoC: sdw-mockup: " Kuninori Morimoto
2023-01-24  2:12 ` [PATCH v2 13/25] ASoC: intel: " Kuninori Morimoto
2023-01-24  2:12 ` [PATCH v2 14/25] ASoC: mediatek: " Kuninori Morimoto
2023-01-24  2:12   ` Kuninori Morimoto
2023-01-24  2:12   ` Kuninori Morimoto
2023-01-24 11:03   ` AngeloGioacchino Del Regno
2023-01-24 11:03     ` AngeloGioacchino Del Regno
2023-01-24 11:03     ` AngeloGioacchino Del Regno
2023-01-24  2:13 ` [PATCH v2 15/25] ASoC: meson: " Kuninori Morimoto
2023-01-24  2:13   ` Kuninori Morimoto
2023-01-24  2:13   ` Kuninori Morimoto
2023-01-24  9:29   ` Jerome Brunet
2023-01-24  9:29     ` Jerome Brunet
2023-01-24  9:29     ` Jerome Brunet
2023-01-24  2:13 ` [PATCH v2 16/25] ASoC: rockchip: " Kuninori Morimoto
2023-01-24  2:13   ` Kuninori Morimoto
2023-01-24  2:13   ` Kuninori Morimoto
2023-01-24  2:14 ` [PATCH v2 17/25] ASoC: sof: " Kuninori Morimoto
2023-01-24  2:14 ` [PATCH v2 18/25] ASoC: tegra: " Kuninori Morimoto
2023-01-24  2:14   ` Kuninori Morimoto
2023-01-24  2:15 ` [PATCH v2 19/25] ASoC: ti: " Kuninori Morimoto
2023-01-24  2:15 ` [PATCH v2 20/25] ASoC: soc-core.c: " Kuninori Morimoto
2023-01-24  2:15 ` [PATCH v2 21/25] ASoC: soc-dapm.c: " Kuninori Morimoto
2023-01-24  2:16 ` [PATCH v2 22/25] ASoC: soc-dai.c: " Kuninori Morimoto
2023-01-24  2:16 ` [PATCH v2 23/25] ASoC: soc-pcm.c: " Kuninori Morimoto
2023-01-24  2:17 ` [PATCH v2 24/25] ASoC: soc-topology.c: " Kuninori Morimoto
2023-01-24  2:17 ` [PATCH v2 25/25] ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai Kuninori Morimoto
2023-01-31 22:17 ` [PATCH v2 00/25] ASoC: use helper function and cleanup Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202301241201.jBsUFSYu-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.