From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1023C25B4E for ; Tue, 24 Jan 2023 11:24:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E2B0BDF6; Tue, 24 Jan 2023 12:24:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E2B0BDF6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674559491; bh=ZU+EjLaI/FW1VTHOPa7hxVjbF381hYcc2PgNzQ+aLno=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=U9PgSLvY+mPtKix8h/sj9B+QabeacJ7OJA36gLjN1UKrPNj6CsHioZX7q7gGSv1Wr 5TcbO6508oQd/gom8DE1Wh04scNe8KJRMLifeVy7talhdGbvbEH2Cc58bQDFvokXc7 9Vj9Fjmn1ZUVnU3R7OomchdygJXTGAxtde0we5C4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4A054F8025D; Tue, 24 Jan 2023 12:24:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8FE0BF8027D; Tue, 24 Jan 2023 12:23:59 +0100 (CET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BB76BF800FB for ; Tue, 24 Jan 2023 12:23:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BB76BF800FB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=NFHmt5S1 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EE1DD40003; Tue, 24 Jan 2023 11:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674559433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbYmdWFivLJBG8Pv5/K9k19ry1rzbKQLylHycCbuWNc=; b=NFHmt5S1U+BUZUExL6OMxo6ILWp1xOjzqVQBYDfj00xs/vj7VrSA8WyLsXUrWWzJO2vFgu Cr4mewN/SKd25Vlr4LPbG1RmnyBuql6OvuSKtX7LqGUjOADGdWXtZdqbCqf70llzXc2MgM gh7eqki/cly8NSZheKh/cOaif3gaUwL36fTc/c7tf4VoPbtXcjIlhqFna9u4NYhgiD0nyM LKuhuQx6iBHekcH7quPoCnFbpsrz+VRm0gvzpATBvB8UcNvf1iZ+MMTzHi66V2FDXR1GzD ztM2qnsi+eVF9dkpyWhxPae2i9kmMcC+2PjSxhskT8Ew9B5OqlBkOiUlJlpz/w== Date: Tue, 24 Jan 2023 12:23:47 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124122347.1a531d0f@bootlin.com> In-Reply-To: <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Christophe Leroy , Krzysztof Kozlowski , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 24 Jan 2023 11:02:52 +0100 Krzysztof Kozlowski wrote: > On 24/01/2023 10:42, Herve Codina wrote: > > Hi Krzysztof, > >=20 > > On Tue, 17 Jan 2023 12:31:09 +0100 > > Krzysztof Kozlowski wrote: > > =20 > >> On 13/01/2023 11:37, Herve Codina wrote: =20 > >>> Add support for the QMC (QUICC Multichannel Controller) > >>> available in some PowerQUICC SoC such as MPC885 or MPC866. > >>> > >>> Signed-off-by: Herve Codina > >>> --- > >>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++++= ++ > >>> 1 file changed, 164 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/= fsl,qmc.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc= .yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>> new file mode 100644 > >>> index 000000000000..3ec52f1635c8 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>> @@ -0,0 +1,164 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > >>> + > >>> +maintainers: > >>> + - Herve Codina > >>> + > >>> +description: | > >>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channels= within > >>> + one serial controller using the same TDM physical interface routed= from > >>> + TSA. > >>> + > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - enum: > >>> + - fsl,mpc885-scc-qmc > >>> + - fsl,mpc866-scc-qmc > >>> + - const: fsl,cpm1-scc-qmc > >>> + > >>> + reg: > >>> + items: > >>> + - description: SCC (Serial communication controller) register = base > >>> + - description: SCC parameter ram base > >>> + - description: Dual port ram base > >>> + > >>> + reg-names: > >>> + items: > >>> + - const: scc_regs > >>> + - const: scc_pram > >>> + - const: dpram > >>> + > >>> + interrupts: > >>> + maxItems: 1 > >>> + description: SCC interrupt line in the CPM interrupt controller > >>> + > >>> + fsl,tsa: > >>> + $ref: /schemas/types.yaml#/definitions/phandle > >>> + description: phandle to the TSA > >>> + > >>> + fsl,tsa-cell-id: > >>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>> + enum: [1, 2, 3] > >>> + description: | > >>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > >>> + - 1: SCC2 > >>> + - 2: SCC3 > >>> + - 3: SCC4 =20 > >> > >> Is this used as argument to tsa? If so, this should be part of fsl,tsa > >> property, just like we do for all syscon-like phandles. =20 > >=20 > > Yes, indeed. > > I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle/n= umber > > pair (the phandle to TSA node and the TSA cell id to use) =20 >=20 > Move to fsl,tsa, not from. Well, I plan to remove both fsl,tsa and fsl,tsa-cell-id and use this: fsl,tsa-cell: $ref: /schemas/types.yaml#/definitions/phandle-array items: - items: - description: phandle to TSA node - enum: [1, 2, 3] description: | TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) - 1: SCC2 - 2: SCC3 - 3: SCC4 description: Should be a phandle/number pair. The phandle to TSA node and the TSA cell ID to use. Is that what you were thinking about ? Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BDC7C25B50 for ; Tue, 24 Jan 2023 11:24:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P1PlD2Yqwz3cK6 for ; Tue, 24 Jan 2023 22:24:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=NFHmt5S1; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::222; helo=relay2-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=NFHmt5S1; dkim-atps=neutral Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P1PkB6tmPz3bZl for ; Tue, 24 Jan 2023 22:24:00 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EE1DD40003; Tue, 24 Jan 2023 11:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674559433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbYmdWFivLJBG8Pv5/K9k19ry1rzbKQLylHycCbuWNc=; b=NFHmt5S1U+BUZUExL6OMxo6ILWp1xOjzqVQBYDfj00xs/vj7VrSA8WyLsXUrWWzJO2vFgu Cr4mewN/SKd25Vlr4LPbG1RmnyBuql6OvuSKtX7LqGUjOADGdWXtZdqbCqf70llzXc2MgM gh7eqki/cly8NSZheKh/cOaif3gaUwL36fTc/c7tf4VoPbtXcjIlhqFna9u4NYhgiD0nyM LKuhuQx6iBHekcH7quPoCnFbpsrz+VRm0gvzpATBvB8UcNvf1iZ+MMTzHi66V2FDXR1GzD ztM2qnsi+eVF9dkpyWhxPae2i9kmMcC+2PjSxhskT8Ew9B5OqlBkOiUlJlpz/w== Date: Tue, 24 Jan 2023 12:23:47 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124122347.1a531d0f@bootlin.com> In-Reply-To: <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 24 Jan 2023 11:02:52 +0100 Krzysztof Kozlowski wrote: > On 24/01/2023 10:42, Herve Codina wrote: > > Hi Krzysztof, > >=20 > > On Tue, 17 Jan 2023 12:31:09 +0100 > > Krzysztof Kozlowski wrote: > > =20 > >> On 13/01/2023 11:37, Herve Codina wrote: =20 > >>> Add support for the QMC (QUICC Multichannel Controller) > >>> available in some PowerQUICC SoC such as MPC885 or MPC866. > >>> > >>> Signed-off-by: Herve Codina > >>> --- > >>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++++= ++ > >>> 1 file changed, 164 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/= fsl,qmc.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc= .yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>> new file mode 100644 > >>> index 000000000000..3ec52f1635c8 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>> @@ -0,0 +1,164 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > >>> + > >>> +maintainers: > >>> + - Herve Codina > >>> + > >>> +description: | > >>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channels= within > >>> + one serial controller using the same TDM physical interface routed= from > >>> + TSA. > >>> + > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - enum: > >>> + - fsl,mpc885-scc-qmc > >>> + - fsl,mpc866-scc-qmc > >>> + - const: fsl,cpm1-scc-qmc > >>> + > >>> + reg: > >>> + items: > >>> + - description: SCC (Serial communication controller) register = base > >>> + - description: SCC parameter ram base > >>> + - description: Dual port ram base > >>> + > >>> + reg-names: > >>> + items: > >>> + - const: scc_regs > >>> + - const: scc_pram > >>> + - const: dpram > >>> + > >>> + interrupts: > >>> + maxItems: 1 > >>> + description: SCC interrupt line in the CPM interrupt controller > >>> + > >>> + fsl,tsa: > >>> + $ref: /schemas/types.yaml#/definitions/phandle > >>> + description: phandle to the TSA > >>> + > >>> + fsl,tsa-cell-id: > >>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>> + enum: [1, 2, 3] > >>> + description: | > >>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > >>> + - 1: SCC2 > >>> + - 2: SCC3 > >>> + - 3: SCC4 =20 > >> > >> Is this used as argument to tsa? If so, this should be part of fsl,tsa > >> property, just like we do for all syscon-like phandles. =20 > >=20 > > Yes, indeed. > > I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle/n= umber > > pair (the phandle to TSA node and the TSA cell id to use) =20 >=20 > Move to fsl,tsa, not from. Well, I plan to remove both fsl,tsa and fsl,tsa-cell-id and use this: fsl,tsa-cell: $ref: /schemas/types.yaml#/definitions/phandle-array items: - items: - description: phandle to TSA node - enum: [1, 2, 3] description: | TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) - 1: SCC2 - 2: SCC3 - 3: SCC4 description: Should be a phandle/number pair. The phandle to TSA node and the TSA cell ID to use. Is that what you were thinking about ? Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F877C25B50 for ; Tue, 24 Jan 2023 11:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Ta7afKaZK2JeWSllSV+e97TYmJ4F/PpgZOFOpOUeSU=; b=D4xtO3xr/l+55g Q2XxNDoRXWxIbI0G12qrjs0ok2CXigdsGyChu98h0sE3N57c1FgSRnG3i6zl/Q558uiOHvxhFkM35 cEMUQJ9kT3lkc3wjJ6oVAVMOsFuefg9Kw993m7mCP0ZD4zd3wpfBUkDIcgOqJsPoHUCimXRiS3ohW Uv8epgxGYiMumTQDlvlTZ0ZXy9Cghy3a08k9p4GxQZMuYBZHEDszZMpBfaZQB/iS9aVlPAiVjcS0T raupb4tpf0FKyABTjV1aDDTftlI4f7iW07qQECBipJ1Ueq8mqHj98rLcTDJwzJ0uHI0RIcvOqt0jy wql5Cd8XBtO/aFadpr2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKHPI-003PnH-8R; Tue, 24 Jan 2023 11:24:04 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKHPD-003Pkn-Kr for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 11:24:01 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EE1DD40003; Tue, 24 Jan 2023 11:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674559433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbYmdWFivLJBG8Pv5/K9k19ry1rzbKQLylHycCbuWNc=; b=NFHmt5S1U+BUZUExL6OMxo6ILWp1xOjzqVQBYDfj00xs/vj7VrSA8WyLsXUrWWzJO2vFgu Cr4mewN/SKd25Vlr4LPbG1RmnyBuql6OvuSKtX7LqGUjOADGdWXtZdqbCqf70llzXc2MgM gh7eqki/cly8NSZheKh/cOaif3gaUwL36fTc/c7tf4VoPbtXcjIlhqFna9u4NYhgiD0nyM LKuhuQx6iBHekcH7quPoCnFbpsrz+VRm0gvzpATBvB8UcNvf1iZ+MMTzHi66V2FDXR1GzD ztM2qnsi+eVF9dkpyWhxPae2i9kmMcC+2PjSxhskT8Ew9B5OqlBkOiUlJlpz/w== Date: Tue, 24 Jan 2023 12:23:47 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124122347.1a531d0f@bootlin.com> In-Reply-To: <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_032359_966948_5106B84E X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNCBKYW4gMjAyMyAxMTowMjo1MiArMDEwMApLcnp5c3p0b2YgS296bG93c2tpIDxr cnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgoKPiBPbiAyNC8wMS8yMDIzIDEw OjQyLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiBIaSBLcnp5c3p0b2YsCj4gPiAKPiA+IE9uIFR1 ZSwgMTcgSmFuIDIwMjMgMTI6MzE6MDkgKzAxMDAKPiA+IEtyenlzenRvZiBLb3psb3dza2kgPGty enlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiAgIAo+ID4+IE9uIDEzLzAx LzIwMjMgMTE6MzcsIEhlcnZlIENvZGluYSB3cm90ZTogIAo+ID4+PiBBZGQgc3VwcG9ydCBmb3Ig dGhlIFFNQyAoUVVJQ0MgTXVsdGljaGFubmVsIENvbnRyb2xsZXIpCj4gPj4+IGF2YWlsYWJsZSBp biBzb21lIFBvd2VyUVVJQ0MgU29DIHN1Y2ggYXMgTVBDODg1IG9yIE1QQzg2Ni4KPiA+Pj4KPiA+ Pj4gU2lnbmVkLW9mZi1ieTogSGVydmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+ Cj4gPj4+IC0tLQo+ID4+PiAgLi4uL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3FlL2ZzbCxxbWMueWFt bCAgICAgIHwgMTY0ICsrKysrKysrKysrKysrKysrKwo+ID4+PiAgMSBmaWxlIGNoYW5nZWQsIDE2 NCBpbnNlcnRpb25zKCspCj4gPj4+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3FlL2ZzbCxxbWMueWFtbAo+ID4+Pgo+ID4+ PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wv Y3BtX3FlL2ZzbCxxbWMueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9z b2MvZnNsL2NwbV9xZS9mc2wscW1jLnlhbWwKPiA+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ Pj4gaW5kZXggMDAwMDAwMDAwMDAwLi4zZWM1MmYxNjM1YzgKPiA+Pj4gLS0tIC9kZXYvbnVsbAo+ ID4+PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9jcG1f cWUvZnNsLHFtYy55YW1sCj4gPj4+IEBAIC0wLDAgKzEsMTY0IEBACj4gPj4+ICsjIFNQRFgtTGlj ZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVzZSkKPiA+Pj4gKyVZ QU1MIDEuMgo+ID4+PiArLS0tCj4gPj4+ICskaWQ6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9zY2hl bWFzL3NvYy9mc2wvY3BtX3FlL2ZzbCxxbWMueWFtbCMKPiA+Pj4gKyRzY2hlbWE6IGh0dHA6Ly9k ZXZpY2V0cmVlLm9yZy9tZXRhLXNjaGVtYXMvY29yZS55YW1sIwo+ID4+PiArCj4gPj4+ICt0aXRs ZTogUG93ZXJRVUlDQyBDUE0gUVVJQ0MgTXVsdGljaGFubmVsIENvbnRyb2xsZXIgKFFNQykKPiA+ Pj4gKwo+ID4+PiArbWFpbnRhaW5lcnM6Cj4gPj4+ICsgIC0gSGVydmUgQ29kaW5hIDxoZXJ2ZS5j b2RpbmFAYm9vdGxpbi5jb20+Cj4gPj4+ICsKPiA+Pj4gK2Rlc2NyaXB0aW9uOiB8Cj4gPj4+ICsg IFRoZSBRTUMgKFFVSUNDIE11bHRpY2hhbm5lbCBDb250cm9sbGVyKSBlbXVsYXRlcyB1cCB0byA2 NCBjaGFubmVscyB3aXRoaW4KPiA+Pj4gKyAgb25lIHNlcmlhbCBjb250cm9sbGVyIHVzaW5nIHRo ZSBzYW1lIFRETSBwaHlzaWNhbCBpbnRlcmZhY2Ugcm91dGVkIGZyb20KPiA+Pj4gKyAgVFNBLgo+ ID4+PiArCj4gPj4+ICtwcm9wZXJ0aWVzOgo+ID4+PiArICBjb21wYXRpYmxlOgo+ID4+PiArICAg IGl0ZW1zOgo+ID4+PiArICAgICAgLSBlbnVtOgo+ID4+PiArICAgICAgICAgIC0gZnNsLG1wYzg4 NS1zY2MtcW1jCj4gPj4+ICsgICAgICAgICAgLSBmc2wsbXBjODY2LXNjYy1xbWMKPiA+Pj4gKyAg ICAgIC0gY29uc3Q6IGZzbCxjcG0xLXNjYy1xbWMKPiA+Pj4gKwo+ID4+PiArICByZWc6Cj4gPj4+ ICsgICAgaXRlbXM6Cj4gPj4+ICsgICAgICAtIGRlc2NyaXB0aW9uOiBTQ0MgKFNlcmlhbCBjb21t dW5pY2F0aW9uIGNvbnRyb2xsZXIpIHJlZ2lzdGVyIGJhc2UKPiA+Pj4gKyAgICAgIC0gZGVzY3Jp cHRpb246IFNDQyBwYXJhbWV0ZXIgcmFtIGJhc2UKPiA+Pj4gKyAgICAgIC0gZGVzY3JpcHRpb246 IER1YWwgcG9ydCByYW0gYmFzZQo+ID4+PiArCj4gPj4+ICsgIHJlZy1uYW1lczoKPiA+Pj4gKyAg ICBpdGVtczoKPiA+Pj4gKyAgICAgIC0gY29uc3Q6IHNjY19yZWdzCj4gPj4+ICsgICAgICAtIGNv bnN0OiBzY2NfcHJhbQo+ID4+PiArICAgICAgLSBjb25zdDogZHByYW0KPiA+Pj4gKwo+ID4+PiAr ICBpbnRlcnJ1cHRzOgo+ID4+PiArICAgIG1heEl0ZW1zOiAxCj4gPj4+ICsgICAgZGVzY3JpcHRp b246IFNDQyBpbnRlcnJ1cHQgbGluZSBpbiB0aGUgQ1BNIGludGVycnVwdCBjb250cm9sbGVyCj4g Pj4+ICsKPiA+Pj4gKyAgZnNsLHRzYToKPiA+Pj4gKyAgICAkcmVmOiAvc2NoZW1hcy90eXBlcy55 YW1sIy9kZWZpbml0aW9ucy9waGFuZGxlCj4gPj4+ICsgICAgZGVzY3JpcHRpb246IHBoYW5kbGUg dG8gdGhlIFRTQQo+ID4+PiArCj4gPj4+ICsgIGZzbCx0c2EtY2VsbC1pZDoKPiA+Pj4gKyAgICAk cmVmOiAvc2NoZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy91aW50MzIKPiA+Pj4gKyAgICBl bnVtOiBbMSwgMiwgM10KPiA+Pj4gKyAgICBkZXNjcmlwdGlvbjogfAo+ID4+PiArICAgICAgVFNB IGNlbGwgSUQgKGR0LWJpbmRpbmdzL3NvYy9mc2wsdHNhLmggZGVmaW5lcyB0aGVzZSB2YWx1ZXMp Cj4gPj4+ICsgICAgICAgLSAxOiBTQ0MyCj4gPj4+ICsgICAgICAgLSAyOiBTQ0MzCj4gPj4+ICsg ICAgICAgLSAzOiBTQ0M0ICAgIAo+ID4+Cj4gPj4gSXMgdGhpcyB1c2VkIGFzIGFyZ3VtZW50IHRv IHRzYT8gSWYgc28sIHRoaXMgc2hvdWxkIGJlIHBhcnQgb2YgZnNsLHRzYQo+ID4+IHByb3BlcnR5 LCBqdXN0IGxpa2Ugd2UgZG8gZm9yIGFsbCBzeXNjb24tbGlrZSBwaGFuZGxlcy4gIAo+ID4gCj4g PiBZZXMsIGluZGVlZC4KPiA+IEkgd2lsbCBtb3ZlICdmc2wsdHNhJyB0byAnZnNsLHRzYS1jZWxs JyB3aXRoICdmc2wsdHNhLWNlbGwnIGEgcGhhbmRsZS9udW1iZXIKPiA+IHBhaXIgKHRoZSBwaGFu ZGxlIHRvIFRTQSBub2RlIGFuZCB0aGUgVFNBIGNlbGwgaWQgdG8gdXNlKSAgCj4gCj4gTW92ZSB0 byBmc2wsdHNhLCBub3QgZnJvbS4KCldlbGwsIEkgcGxhbiB0byByZW1vdmUgYm90aCBmc2wsdHNh IGFuZCBmc2wsdHNhLWNlbGwtaWQgYW5kIHVzZSB0aGlzOgogIGZzbCx0c2EtY2VsbDoKICAgICRy ZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUtYXJyYXkKICAgIGl0 ZW1zOgogICAgICAtIGl0ZW1zOgogICAgICAgICAgLSBkZXNjcmlwdGlvbjogcGhhbmRsZSB0byBU U0Egbm9kZQogICAgICAgICAgLSBlbnVtOiBbMSwgMiwgM10KICAgICAgICAgICAgZGVzY3JpcHRp b246IHwKICAgICAgICAgICAgICBUU0EgY2VsbCBJRCAoZHQtYmluZGluZ3Mvc29jL2ZzbCx0c2Eu aCBkZWZpbmVzIHRoZXNlIHZhbHVlcykKICAgICAgICAgICAgICAgLSAxOiBTQ0MyCiAgICAgICAg ICAgICAgIC0gMjogU0NDMwogICAgICAgICAgICAgICAtIDM6IFNDQzQKICAgIGRlc2NyaXB0aW9u OgogICAgICBTaG91bGQgYmUgYSBwaGFuZGxlL251bWJlciBwYWlyLiBUaGUgcGhhbmRsZSB0byBU U0Egbm9kZSBhbmQgdGhlIFRTQQogICAgICBjZWxsIElEIHRvIHVzZS4KCklzIHRoYXQgd2hhdCB5 b3Ugd2VyZSB0aGlua2luZyBhYm91dCA/CgpCZXN0IHJlZ2FyZHMsCkhlcnbDqQoKCi0tIApIZXJ2 w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcK aHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A10D7C25B4E for ; Tue, 24 Jan 2023 11:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233911AbjAXLX5 (ORCPT ); Tue, 24 Jan 2023 06:23:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233925AbjAXLX5 (ORCPT ); Tue, 24 Jan 2023 06:23:57 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 059D876BE; Tue, 24 Jan 2023 03:23:54 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EE1DD40003; Tue, 24 Jan 2023 11:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674559433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbYmdWFivLJBG8Pv5/K9k19ry1rzbKQLylHycCbuWNc=; b=NFHmt5S1U+BUZUExL6OMxo6ILWp1xOjzqVQBYDfj00xs/vj7VrSA8WyLsXUrWWzJO2vFgu Cr4mewN/SKd25Vlr4LPbG1RmnyBuql6OvuSKtX7LqGUjOADGdWXtZdqbCqf70llzXc2MgM gh7eqki/cly8NSZheKh/cOaif3gaUwL36fTc/c7tf4VoPbtXcjIlhqFna9u4NYhgiD0nyM LKuhuQx6iBHekcH7quPoCnFbpsrz+VRm0gvzpATBvB8UcNvf1iZ+MMTzHi66V2FDXR1GzD ztM2qnsi+eVF9dkpyWhxPae2i9kmMcC+2PjSxhskT8Ew9B5OqlBkOiUlJlpz/w== Date: Tue, 24 Jan 2023 12:23:47 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124122347.1a531d0f@bootlin.com> In-Reply-To: <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 24 Jan 2023 11:02:52 +0100 Krzysztof Kozlowski wrote: > On 24/01/2023 10:42, Herve Codina wrote: > > Hi Krzysztof, > >=20 > > On Tue, 17 Jan 2023 12:31:09 +0100 > > Krzysztof Kozlowski wrote: > > =20 > >> On 13/01/2023 11:37, Herve Codina wrote: =20 > >>> Add support for the QMC (QUICC Multichannel Controller) > >>> available in some PowerQUICC SoC such as MPC885 or MPC866. > >>> > >>> Signed-off-by: Herve Codina > >>> --- > >>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++++= ++ > >>> 1 file changed, 164 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/= fsl,qmc.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc= .yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>> new file mode 100644 > >>> index 000000000000..3ec52f1635c8 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>> @@ -0,0 +1,164 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > >>> + > >>> +maintainers: > >>> + - Herve Codina > >>> + > >>> +description: | > >>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channels= within > >>> + one serial controller using the same TDM physical interface routed= from > >>> + TSA. > >>> + > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - enum: > >>> + - fsl,mpc885-scc-qmc > >>> + - fsl,mpc866-scc-qmc > >>> + - const: fsl,cpm1-scc-qmc > >>> + > >>> + reg: > >>> + items: > >>> + - description: SCC (Serial communication controller) register = base > >>> + - description: SCC parameter ram base > >>> + - description: Dual port ram base > >>> + > >>> + reg-names: > >>> + items: > >>> + - const: scc_regs > >>> + - const: scc_pram > >>> + - const: dpram > >>> + > >>> + interrupts: > >>> + maxItems: 1 > >>> + description: SCC interrupt line in the CPM interrupt controller > >>> + > >>> + fsl,tsa: > >>> + $ref: /schemas/types.yaml#/definitions/phandle > >>> + description: phandle to the TSA > >>> + > >>> + fsl,tsa-cell-id: > >>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>> + enum: [1, 2, 3] > >>> + description: | > >>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > >>> + - 1: SCC2 > >>> + - 2: SCC3 > >>> + - 3: SCC4 =20 > >> > >> Is this used as argument to tsa? If so, this should be part of fsl,tsa > >> property, just like we do for all syscon-like phandles. =20 > >=20 > > Yes, indeed. > > I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle/n= umber > > pair (the phandle to TSA node and the TSA cell id to use) =20 >=20 > Move to fsl,tsa, not from. Well, I plan to remove both fsl,tsa and fsl,tsa-cell-id and use this: fsl,tsa-cell: $ref: /schemas/types.yaml#/definitions/phandle-array items: - items: - description: phandle to TSA node - enum: [1, 2, 3] description: | TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) - 1: SCC2 - 2: SCC3 - 3: SCC4 description: Should be a phandle/number pair. The phandle to TSA node and the TSA cell ID to use. Is that what you were thinking about ? Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com